SwingNumberWidget: fix non-integer step size bug

ctrueden · ctrueden · commit 40bd474d8b9b · 2022-05-31T14:44:20.000-05:00
When the parameter is new and has a null default value, it would crash. Fixes scijava/scijava-common#434.
diff --git a/src/main/java/org/scijava/ui/swing/widget/SwingNumberWidget.java b/src/main/java/org/scijava/ui/swing/widget/SwingNumberWidget.java
@@ -341,7 +341,7 @@ private void syncSliders() {
 	/** Generate a suitable format pattern. */
 	private String suitableFormat(Number... values) {
 		Integer maxScale = Arrays.stream(values)
-				.map(n -> new BigDecimal("" + n.doubleValue()).stripTrailingZeros().scale()).max(Integer::compare)
+				.map(n -> new BigDecimal("" + (n == null ? 0.0 : n.doubleValue())).stripTrailingZeros().scale()).max(Integer::compare)
 				.get();
 		return formatForScale(maxScale);
 	}

Original file line number	Diff line number	Diff line change
`@@ -341,7 +341,7 @@ private void syncSliders() {`
`341`	`341`	`/** Generate a suitable format pattern. */`
`342`	`342`	`private String suitableFormat(Number... values) {`
`343`	`343`	`Integer maxScale = Arrays.stream(values)`
`344`		`- .map(n -> new BigDecimal("" + n.doubleValue()).stripTrailingZeros().scale()).max(Integer::compare)`
	`344`	`+ .map(n -> new BigDecimal("" + (n == null ? 0.0 : n.doubleValue())).stripTrailingZeros().scale()).max(Integer::compare)`
`345`	`345`	`.get();`
`346`	`346`	`return formatForScale(maxScale);`
`347`	`347`	`}`