Add note about storing persisted values for list and array inputs

ctrueden · imagejan · commit baaaa55e3524 · 2017-07-21T09:03:59.000+02:00
diff --git a/src/main/java/org/scijava/module/DefaultModuleService.java b/src/main/java/org/scijava/module/DefaultModuleService.java
@@ -297,6 +297,8 @@ public <T> void save(final ModuleItem<T> item, final T value) {
 			return;
 		}
 
+		// FIXME: Convert to string, instead of just calling toString.
+		// Otherwise many things (e.g. File[]) are persisted improperly.
 		final String sValue = value == null ? "" : value.toString();
 
 		// do not persist if object cannot be converted back from a string

Original file line number	Diff line number	Diff line change
`@@ -297,6 +297,8 @@ public <T> void save(final ModuleItem<T> item, final T value) {`
`297`	`297`	`return;`
`298`	`298`	`}`
`299`	`299`
	`300`	`+ // FIXME: Convert to string, instead of just calling toString.`
	`301`	`+ // Otherwise many things (e.g. File[]) are persisted improperly.`
`300`	`302`	`final String sValue = value == null ? "" : value.toString();`
`301`	`303`
`302`	`304`	`// do not persist if object cannot be converted back from a string`