Skip to content

Commit b6e2619

Browse files
committed
DisplayPostprocessor: always name displays
1 parent 6fa80b1 commit b6e2619

File tree

1 file changed

+9
-5
lines changed

1 file changed

+9
-5
lines changed

src/main/java/org/scijava/display/DisplayPostprocessor.java

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,7 @@
3636
import java.util.List;
3737
import java.util.Map;
3838

39+
import org.scijava.Named;
3940
import org.scijava.Priority;
4041
import org.scijava.log.LogService;
4142
import org.scijava.module.Module;
@@ -113,13 +114,16 @@ private void handleOutput(final String defaultName, final Object output) {
113114
}
114115
else {
115116
// create a new display for the output
116-
final Display<?> display = displayService.createDisplay(output);
117+
String name = null;
118+
119+
// TODO rework how displays are named
120+
if (output instanceof Named) name = ((Named)output).getName();
121+
122+
if (name == null) name = defaultName;
123+
124+
final Display<?> display = displayService.createDisplay(name, output);
117125
if (display != null) {
118126
displays.add(display);
119-
if (display.getName() == null) {
120-
// set a default name based on the parameter
121-
display.setName(defaultName);
122-
}
123127
}
124128
}
125129
}

0 commit comments

Comments
 (0)