Skip to content

Commit 950c3f3

Browse files
committed
Rename blacklist to blocklist
See e.g. https://twitter.com/leahculver/status/1269109776983547904
1 parent 73743b0 commit 950c3f3

File tree

2 files changed

+18
-18
lines changed

2 files changed

+18
-18
lines changed

src/main/java/org/scijava/plugin/DefaultPluginFinder.java

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ public class DefaultPluginFinder implements PluginFinder {
5353
/** Class loader to use when querying the annotation indexes. */
5454
private final ClassLoader customClassLoader;
5555

56-
private final PluginBlacklist blacklist;
56+
private final PluginBlocklist blocklist;
5757

5858
// -- Constructors --
5959

@@ -63,7 +63,7 @@ public DefaultPluginFinder() {
6363

6464
public DefaultPluginFinder(final ClassLoader classLoader) {
6565
customClassLoader = classLoader;
66-
blacklist = new SysPropBlacklist();
66+
blocklist = new SysPropBlocklist();
6767
}
6868

6969
// -- PluginFinder methods --
@@ -82,7 +82,7 @@ public HashMap<String, Throwable> findPlugins(
8282

8383
// create a PluginInfo object for each item in the index
8484
for (final IndexItem<Plugin> item : annotationIndex) {
85-
if (blacklist.contains(item.className())) continue;
85+
if (blocklist.contains(item.className())) continue;
8686
try {
8787
final PluginInfo<?> info = createInfo(item, classLoader);
8888
plugins.add(info);
@@ -117,23 +117,23 @@ private ClassLoader getClassLoader() {
117117

118118
// -- Helper classes --
119119

120-
private interface PluginBlacklist {
120+
private interface PluginBlocklist {
121121
boolean contains(String className);
122122
}
123123

124124
/**
125-
* A blacklist defined by the {@code scijava.plugin.blacklist} system
125+
* A blocklist defined by the {@code scijava.plugin.blocklist} system
126126
* property, formatted as a colon-separated list of regexes.
127127
* <p>
128128
* If a plugin class matches any of the regexes, it is excluded from the
129129
* plugin index.
130130
* </p>
131131
*/
132-
private class SysPropBlacklist implements PluginBlacklist {
132+
private class SysPropBlocklist implements PluginBlocklist {
133133
private final List<Pattern> patterns;
134134

135-
public SysPropBlacklist() {
136-
final String sysProp = System.getProperty("scijava.plugin.blacklist");
135+
public SysPropBlocklist() {
136+
final String sysProp = System.getProperty("scijava.plugin.blocklist");
137137
final String[] regexes = //
138138
sysProp == null ? new String[0] : sysProp.split(":");
139139
patterns = new ArrayList<>(regexes.length);
@@ -147,7 +147,7 @@ public SysPropBlacklist() {
147147
}
148148
}
149149

150-
// -- PluginBlacklist methods --
150+
// -- PluginBlocklist methods --
151151

152152
@Override
153153
public boolean contains(final String className) {

src/test/java/org/scijava/plugin/PluginFinderTest.java

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -43,33 +43,33 @@
4343
public class PluginFinderTest {
4444

4545
/**
46-
* Tests that the {@code scijava.plugin.blacklist} system property works to
46+
* Tests that the {@code scijava.plugin.blocklist} system property works to
4747
* exclude plugins from the index, even when they are on the classpath.
4848
*/
4949
@Test
50-
public void testPluginBlacklistSystemProperty() {
50+
public void testPluginBlocklistSystemProperty() {
5151
// check that the plugin is there, normally
5252
Context context = new Context(PluginService.class);
5353
PluginService pluginService = context.service(PluginService.class);
5454
PluginInfo<SciJavaPlugin> plugin = //
55-
pluginService.getPlugin(BlacklistedPlugin.class);
56-
assertSame(BlacklistedPlugin.class.getName(), plugin.getClassName());
55+
pluginService.getPlugin(BlocklistedPlugin.class);
56+
assertSame(BlocklistedPlugin.class.getName(), plugin.getClassName());
5757
context.dispose();
5858

59-
// blacklist the plugin, then check that it is absent
60-
System.setProperty("scijava.plugin.blacklist", ".*BlacklistedPlugin");
59+
// blocklist the plugin, then check that it is absent
60+
System.setProperty("scijava.plugin.blocklist", ".*BlocklistedPlugin");
6161
context = new Context(PluginService.class);
6262
pluginService = context.service(PluginService.class);
63-
plugin = pluginService.getPlugin(BlacklistedPlugin.class);
63+
plugin = pluginService.getPlugin(BlocklistedPlugin.class);
6464
assertNull(plugin);
6565
context.dispose();
6666

6767
// reset the system
68-
System.getProperties().remove("scijava.plugin.blacklist");
68+
System.getProperties().remove("scijava.plugin.blocklist");
6969
}
7070

7171
@Plugin(type = SciJavaPlugin.class)
72-
public static class BlacklistedPlugin implements SciJavaPlugin {
72+
public static class BlocklistedPlugin implements SciJavaPlugin {
7373
// NB: No implementation needed.
7474
}
7575

0 commit comments

Comments
 (0)