Merge pull request ember-learn#240 from 22a/master

samselikoff · web-flow · commit eea81ea59dd3 · 2018-09-13T10:49:23.000-04:00
Omit &lt;a&gt; title attribute if title is null
diff --git a/lib/utils/compile-markdown.js b/lib/utils/compile-markdown.js
@@ -122,6 +122,7 @@ class HBSRenderer extends marked.Renderer {
   }
 
   link(href, title, text) {
-    return `<a href="${href}" title="${title}" class="docs-md__a">${text}</a>`;
+    const titleAttribute = title ? `title="${title}"` : '';
+    return `<a href="${href}" ${titleAttribute} class="docs-md__a">${text}</a>`;
   }
 }
diff --git a/package.json b/package.json
@@ -68,7 +68,7 @@
     "liquid-fire": "^0.29.1",
     "lodash": "^4.17.5",
     "lunr": "^2.1.5",
-    "marked": "^0.3.12",
+    "marked": "^0.5.0",
     "parse-git-config": "^1.1.1",
     "quick-temp": "^0.1.8",
     "resolve": "^1.5.0",
diff --git a/yarn.lock b/yarn.lock
@@ -6332,9 +6332,9 @@ marked@0.3.6:
   version "0.3.6"
   resolved "https://registry.yarnpkg.com/marked/-/marked-0.3.6.tgz#b2c6c618fccece4ef86c4fc6cb8a7cbf5aeda8d7"
 
-marked@^0.3.12:
-  version "0.3.16"
-  resolved "https://registry.yarnpkg.com/marked/-/marked-0.3.16.tgz#2f188b7dfcfa6540fe9940adaf0f3b791c9a5cba"
+marked@^0.5.0:
+  version "0.5.0"
+  resolved "https://registry.yarnpkg.com/marked/-/marked-0.5.0.tgz#9e590bad31584a48ff405b33ab1c0dd25172288e"
 
 match-media@^0.2.0:
   version "0.2.0"

Original file line number	Diff line number	Diff line change
`@@ -122,6 +122,7 @@ class HBSRenderer extends marked.Renderer {`
`122`	`122`	`}`
`123`	`123`
`124`	`124`	`link(href, title, text) {`
`125`		- return `<a href="${href}" title="${title}" class="docs-md__a">${text}</a>`;
	`125`	+ const titleAttribute = title ? `title="${title}"` : '';
	`126`	+ return `<a href="${href}" ${titleAttribute} class="docs-md__a">${text}</a>`;
`126`	`127`	`}`
`127`	`128`	`}`