Skip to content

Commit 02dea7c

Browse files
dbollingersamselikoff
authored andcommitted
Updates ember-keyboard configurations to be more flexible (ember-learn#288)
1 parent 967b19b commit 02dea7c

File tree

5 files changed

+6
-65
lines changed

5 files changed

+6
-65
lines changed

addon/components/docs-header/search-box/component.js

+2-1
Original file line numberDiff line numberDiff line change
@@ -17,10 +17,11 @@ export default Component.extend(EKMixin, {
1717

1818
query: null,
1919

20+
keyboardActivated: true,
21+
2022
didInsertElement() {
2123
this._super();
2224

23-
this.set('keyboardActivated', true);
2425
this.get('fetchProject').perform();
2526
},
2627

addon/components/docs-header/search-results/component.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -19,11 +19,11 @@ export default Component.extend(EKMixin, {
1919
query: null, // passed in
2020
selectedIndex: null,
2121

22+
keyboardActivated: true,
23+
2224
didInsertElement() {
2325
this._super();
2426

25-
this.set('keyboardActivated', true);
26-
2727
// Start downloading the search index immediately
2828
this.get('docsSearch').loadSearchIndex();
2929
},

addon/components/docs-keyboard-shortcuts/component.js

+1-3
Original file line numberDiff line numberDiff line change
@@ -20,9 +20,7 @@ export default Component.extend(EKMixin, {
2020

2121
isShowingKeyboardShortcuts: false,
2222

23-
activateKeyboard: on('init', function() {
24-
this.set('keyboardActivated', true);
25-
}),
23+
keyboardActivated: true,
2624

2725
goto: on(keyUp('KeyG'), function() {
2826
if (!formElementHasFocus()) {

addon/components/docs-viewer/component.js

+1-5
Original file line numberDiff line numberDiff line change
@@ -39,11 +39,7 @@ export default Component.extend(EKMixin, {
3939

4040
classNames: 'docs-viewer docs-flex docs-flex-1',
4141

42-
init() {
43-
this._super();
44-
45-
this.set('keyboardActivated', true);
46-
},
42+
keyboardActivated: true,
4743

4844
willDestroyElement() {
4945
this._super(...arguments);

addon/controllers/application.js

-54
This file was deleted.

0 commit comments

Comments
 (0)