Skip to content

Commit a6da99f

Browse files
committed
Improve code readability
1 parent c40babe commit a6da99f

File tree

1 file changed

+10
-1
lines changed

1 file changed

+10
-1
lines changed

scaleway/tests/test_instance.py

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,6 @@
2222
volume_size = 10
2323
commercial_type = "DEV1-S"
2424
zone = "fr-par-1"
25-
timeout_attach = 10
2625

2726

2827
class TestE2EServerCreation(unittest.TestCase):
@@ -43,19 +42,24 @@ def tearDown(self) -> None:
4342

4443
self.blockAPI.delete_volume(volume_id=volume.id)
4544
logger.info("✅ Volume {volume.id} has been deleted")
45+
4646
if self._server:
4747
self.instanceAPI.delete_server(zone=self.zone, server_id=self._server.id)
4848
logger.info(f"🗑️ Deleted server: {self._server.id}")
4949

5050
def wait_test_instance_server(self, server_id):
5151
interval = interval
52+
5253
for i in range(1, max_retry):
5354
interval *= i
5455
s = self.instanceAPI.get_server(zone=self.zone, server_id=server_id)
56+
5557
if s.state == "running":
5658
logger.info(f"✅ Server {server_id} is running.")
5759
break
60+
5861
time.sleep(interval)
62+
5963
self.fail("Server did not reach 'running' state in time.")
6064

6165
def create_test_instance_server(self) -> Server:
@@ -72,18 +76,23 @@ def create_test_instance_server(self) -> Server:
7276
volumes=volume,
7377
)
7478
logger.info(f"✅ Created server: {server.id}")
79+
7580
self._server = server.server
7681
self.wait_test_instance_server(server_id=server.server.id)
82+
7783
return server.server
7884

7985
def create_test_from_empty_volume(self, number) -> List[Volume]:
8086
volumes: List[Volume] = {}
87+
8188
for i in range(number):
8289
volume = self.blockAPI.create_volume(
8390
from_empty=CreateVolumeRequestFromEmpty(size=10),
8491
)
8592
logger.info("✅ Created server: {volume.id}")
93+
8694
self.blockAPI.wait_for_volume(volume_id=volume.id, zone=self.zone)
95+
8796
self._volumes.append(volume) # Ensure cleanup in tearDown
8897
volumes.append(volume)
8998

0 commit comments

Comments
 (0)