Skip to content

Change MiMa config in scala/scala to check against older versions too? #818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SethTisue opened this issue Sep 29, 2022 · 2 comments
Open

Comments

@SethTisue
Copy link
Member

In scala/scala's project/MimaFilters.scala we currently have:

project/MimaFilters.scala:    mimaReferenceVersion := Some("2.13.9"),
project/MimaFilters.scala:    mimaPreviousArtifacts       := mimaReferenceVersion.value.map(organization.value % name.value % _).toSet,

Are we sure that we don't also need to check against 2.13.0, or against all previous 2.13.x versions? (And same on 2.12.x branch?)

I've opened lightbend-labs/mima#724 as a discussion on this for library maintainers generally, but I'm also opening this separate ticket, since the situation in scala/scala is a bit different than most libraries, since scala-library is checked for both forwards and backwards bincompat. Many library maintainers only maintain backwards bincompat.

@SethTisue SethTisue self-assigned this Sep 29, 2022
@SethTisue SethTisue removed their assignment Mar 3, 2025
@SethTisue
Copy link
Member Author

SethTisue commented Mar 3, 2025

Removing my assignment, as perhaps the status quo on this is just fine, actually.

Anyway,

scala-library is checked for both forwards and backwards bincompat.

This is no longer the case after SIP-51 — we are now backwards-only.

@armanbilge
Copy link

Are we sure that we don't also need to check against 2.13.0, or against all previous 2.13.x versions?

To be safe, you do. To be more specific, you definitely need to if you use the package-private trick, or, we need to change how MiMa works to restore the transitive property for backwards-compatibility-checking. See thread in lightbend-labs/mima#724 (reply in thread).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants