Skip to content

Typo in "WriteableStream" trait name? #754

@raquo

Description

@raquo
Contributor

It seems that the native interface is actually called WritableStream, however Scala trait name has an extra e character in it.

I'm not familiar with this API, the trait is not JSGlobal, and I don't actually see how one could get instances of this trait in scala-js-dom, but nevertheless it should probably match the native name?

Activity

armanbilge

armanbilge commented on Dec 29, 2022

@armanbilge
Member

Thanks, this indeed seems like a mistake :( there are actually many issues with those facades, see #629.

I don't think we can fix this binary-compatibly. Maybe we can add a type alias with the correct name.

added this to the v3.0.0 milestone on Jan 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugdon't PRWe won't accept a PR for this right now

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @raquo@armanbilge

        Issue actions

          Typo in "WriteableStream" trait name? · Issue #754 · scala-js/scala-js-dom