wip

Author: eed3si9n

src/main/java/org/scalasbt/ipcsocket/SocketChannels.java

@@ -146,9 +146,9 @@ public static ByteBuffer readAll(SocketChannel channel, int readTimeoutMillis)
             numOfKeys = sel.select(readTimeoutMillis);
           }
         } else {
-          if (readTimeoutMillis > 0) {
-            throw new IOException("timeout requires JDK 17 and non-Windows");
-          }
+          // if (readTimeoutMillis > 0) {
+          //   throw new IOException("timeout requires JDK 17 and non-Windows");
+          // }
           // The following operation gets blocked on JDK 8
           // channel.register(sel, SelectionKey.OP_READ);
           // numOfKeys = sel.select(readTimeoutMilis);

src/test/java/org/scalasbt/ipcsocket/SocketChannelTest.java

@@ -21,10 +21,8 @@ public void testNonBlockingEchoServer() throws IOException, InterruptedException
         "SocketChannelTest#testNonBlockingEchoServer(" + Boolean.toString(useJNI()) + ")");
     withSocket(
         sock -> {
-          if (isJava17Plus() || ServerSocketChannels.isWin) {
-            String line = nonBlockingEchoServerTest(sock, 100, 600);
-            assertEquals("echo did not return the content", "hello", line);
-          }
+          String line = nonBlockingEchoServerTest(sock, 100, 600);
+          assertEquals("echo did not return the content", "hello", line);
         });
   }
 
@@ -34,10 +32,8 @@ public void testTimeout() throws IOException, InterruptedException {
     System.out.println("SocketChannelTest#testTimeout(" + Boolean.toString(useJNI()) + ")");
     withSocket(
         sock -> {
-          if (isJava17Plus() && !ServerSocketChannels.isWin) {
-            String line = nonBlockingEchoServerTest(sock, 6000, 600);
-            assertEquals("echo did not timeout", "<unavailable>", line);
-          }
+          String line = nonBlockingEchoServerTest(sock, 6000, 600);
+          assertEquals("echo did not timeout", "<unavailable>", line);
         });
   }