Skip to content

Commit d26453a

Browse files
Fix commands.c build issue on merge (redis#10172)
Set commands.c's merge driver to binary so when it conflicts during a merge git will leave the local version unmodified. This way our Makefile will rebuild it based on src/commands/*.json before trying to compile it. Otherwise the file gets modified with merge conflict markers and gets the same timestamp as the *.json files, so the Makefile doesn't attempt to rebuild it before compiling and we get a compilation error.
1 parent ac011eb commit d26453a

File tree

1 file changed

+6
-0
lines changed

1 file changed

+6
-0
lines changed

.gitattributes

+6
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
# We set commands.c's merge driver to `binary` so when it conflicts during a
2+
# merge git will leave the local version unmodified. This way our Makefile
3+
# will rebuild it based on src/commands/*.json before trying to compile it.
4+
# Otherwise the file gets modified and gets the same timestamp as the .json
5+
# files. So the Makefile doesn't attempt to rebuild it before compiling.
6+
src/commands.c merge=binary

0 commit comments

Comments
 (0)