Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for handling SSE with 'event' entries #51

Closed
sashirestela opened this issue Mar 16, 2024 · 2 comments · Fixed by #52, #59 or #60
Closed

Add support for handling SSE with 'event' entries #51

sashirestela opened this issue Mar 16, 2024 · 2 comments · Fixed by #52, #59 or #60
Assignees
Labels
enhancement New feature or request

Comments

@sashirestela
Copy link
Owner

No description provided.

@sashirestela sashirestela added the enhancement New feature or request label Mar 16, 2024
@sashirestela sashirestela self-assigned this Mar 16, 2024
@sashirestela sashirestela linked a pull request Mar 17, 2024 that will close this issue
@sashirestela
Copy link
Owner Author

The approach should be extended to consider stream objects of different classes associated to multiple events.

@sashirestela sashirestela reopened this Mar 21, 2024
@sashirestela sashirestela linked a pull request Mar 22, 2024 that will close this issue
@sashirestela
Copy link
Owner Author

Sending back objects of different types is fine but it is not enough, we are losing the event type that could be valuable for any client using this functionality. It'll be necessary to create a new class Event with two fields: name (String) and data (Object) to keep the full information.

So, the new return types for methods will be: CompletableFuture<Stream<Event>> and Stream<Event>.

@sashirestela sashirestela reopened this Mar 22, 2024
@sashirestela sashirestela linked a pull request Mar 22, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
1 participant