From 9769d8154115c7c0fc685ed6d2f02b741e0d1536 Mon Sep 17 00:00:00 2001 From: Sashir Estela Date: Sun, 28 Jan 2024 16:38:12 -0500 Subject: [PATCH 1/2] Update .devfile.yaml schema version --- .devfile.yaml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.devfile.yaml b/.devfile.yaml index cfcc5cc..1592709 100644 --- a/.devfile.yaml +++ b/.devfile.yaml @@ -1,4 +1,4 @@ -schemaVersion: 2.2.2 +schemaVersion: 2.2.0 metadata: attributes: metadata-name-field: generateName @@ -23,4 +23,4 @@ components: - name: m2 volume: size: 5Gi -commands: [] \ No newline at end of file +commands: [] From 58b34ef00022af46ed0ea3ecd5ac44ca1a885cf2 Mon Sep 17 00:00:00 2001 From: Sashir Estela Date: Mon, 29 Jan 2024 01:34:43 +0000 Subject: [PATCH 2/2] Fixing race condition in unit test --- .../io/github/sashirestela/cleverclient/http/ITest.java | 7 +++++++ .../cleverclient/metadata/InterfaceMetadataStoreTest.java | 4 ++-- 2 files changed, 9 insertions(+), 2 deletions(-) diff --git a/src/test/java/io/github/sashirestela/cleverclient/http/ITest.java b/src/test/java/io/github/sashirestela/cleverclient/http/ITest.java index 003c0d5..e37c591 100644 --- a/src/test/java/io/github/sashirestela/cleverclient/http/ITest.java +++ b/src/test/java/io/github/sashirestela/cleverclient/http/ITest.java @@ -114,6 +114,13 @@ interface SyncService { Stream getDemoStream(@Body RequestDemo request); } + interface NotSavedService { + + @GET("/demos") + CompletableFuture> goodMethod(); + + } + @NoArgsConstructor @AllArgsConstructor @Getter diff --git a/src/test/java/io/github/sashirestela/cleverclient/metadata/InterfaceMetadataStoreTest.java b/src/test/java/io/github/sashirestela/cleverclient/metadata/InterfaceMetadataStoreTest.java index c840e4c..5a03b79 100644 --- a/src/test/java/io/github/sashirestela/cleverclient/metadata/InterfaceMetadataStoreTest.java +++ b/src/test/java/io/github/sashirestela/cleverclient/metadata/InterfaceMetadataStoreTest.java @@ -134,9 +134,9 @@ void shouldSaveInterfaceMetadataWhenAccomplishValidtion() { @Test void shouldThrownExceptionWhenTryingToGetNotPreviouslySavedInterface() { Exception exception = assertThrows(CleverClientException.class, - () -> store.get(ITest.SyncService.class)); + () -> store.get(ITest.NotSavedService.class)); assertTrue(exception.getMessage().equals( - "The interaface SyncService has not been saved yet.")); + "The interaface NotSavedService has not been saved yet.")); } @Test