* [TASK] Setup github actions

s2b · web-flow · commit 00a185fd9d1a · 2020-06-30T18:49:15.000+02:00
diff --git a/.gitattributes b/.gitattributes
@@ -1,4 +1,5 @@
+/.github export-ignore
 /.gitattributes export-ignore
 /.editorconfig export-ignore
+/.ecrc export-ignore
 /Tests/ export-ignore
-/.travis.yml export-ignore
diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml
@@ -0,0 +1,71 @@
+name: tests
+
+on: [push, pull_request]
+
+jobs:
+    lint:
+        name: Source code linting
+        runs-on: ubuntu-latest
+        steps:
+            -
+                uses: actions/checkout@v2
+
+            -
+                name: Validate composer.json
+                run: composer validate
+
+            -
+                name: Cache composer dependencies
+                uses: actions/cache@v1
+                with:
+                    path: ~/.composer/cache
+                    key: composer
+
+            -
+                name: Install composer dependencies
+                run: composer install --prefer-dist --no-progress --no-suggest
+
+            -
+                name: PHP Linting
+                run: composer lint:php
+
+            -
+                name: Editorconfig Linting
+                run: composer lint:editorconfig
+
+
+    test:
+        runs-on: ubuntu-latest
+
+        strategy:
+            max-parallel: 2
+            matrix:
+                php-versions: [7.4, 7.3, 7.2]
+                typo3-versions: [10.4, 9.5]
+
+        name: PHP ${{ matrix.php-versions }} with TYPO3 ${{ matrix.typo3-versions }}
+        steps:
+            -
+                uses: actions/checkout@v2
+
+            -
+                name: Setup PHP
+                uses: shivammathur/setup-php@v2
+                with:
+                    php-version: ${{ matrix.php-versions }}
+                    extensions: intl, mbstring, pdo_sqlite
+
+            -
+                name: Cache composer dependencies
+                uses: actions/cache@v1
+                with:
+                    path: ~/.composer/cache
+                    key: php-${{ matrix.php-versions }}-typo3-${{ matrix.typo3-versions }}
+
+            -
+                name: Install composer dependencies
+                run: composer require typo3/minimal "^${{ matrix.typo3-versions }}" --prefer-dist --no-progress --no-suggest
+
+            -
+                name: Automated Testing
+                run: composer test
diff --git a/.gitignore b/.gitignore
@@ -1,2 +1,3 @@
 .Build
 composer.lock
+/var
diff --git a/.travis.yml b/.travis.yml
diff --git a/Classes/Fluid/ViewHelper/ComponentRenderer.php b/Classes/Fluid/ViewHelper/ComponentRenderer.php
@@ -392,8 +392,7 @@ protected function initializeComponentParams()
                 if ($param['type'] === 'boolean' || $param['type'] === 'bool') {
                     $param['default'] = BooleanNode::convertToBoolean($param['default'], $renderingContext);
                 // Make sure that default value for object parameters is either a valid object or null
-                } elseif (
-                    class_exists($param['type']) &&
+                } elseif (class_exists($param['type']) &&
                     !$param['default'] instanceof $param['type'] &&
                     !$componentArgumentConverter->canTypeBeConvertedToType(gettype($param['default']), $param['type'])
                 ) {
diff --git a/Tests/Unit/ComponentLoaderTest.php b/Tests/Unit/ComponentLoaderTest.php
@@ -6,7 +6,7 @@
 
 class ComponentLoaderTest extends \TYPO3\TestingFramework\Core\Unit\UnitTestCase
 {
-    protected function setUp()
+    protected function setUp(): void
     {
         parent::setUp();
 
diff --git a/Tests/Unit/XsdGeneratorTest.php b/Tests/Unit/XsdGeneratorTest.php
@@ -14,7 +14,7 @@ class XsdGeneratorTest extends \TYPO3\TestingFramework\Core\Unit\UnitTestCase
     protected $fluidNamespaces = null;
     protected $componentLoader = null;
 
-    protected function setUp()
+    protected function setUp(): void
     {
         parent::setUp();
 
@@ -74,7 +74,7 @@ public function getDefaultPrefixForNamespace() {
 
     }
 
-    public function tearDown()
+    public function tearDown(): void
     {
         $GLOBALS['TYPO3_CONF_VARS']['SYS']['fluid']['namespaces'] = $this->fluidNamespaces;
         parent::tearDown();
diff --git a/composer.json b/composer.json
@@ -20,7 +20,7 @@
         "typo3fluid/fluid": "^2"
     },
     "require-dev": {
-        "typo3/testing-framework": "^4.0",
+        "typo3/testing-framework": "^4.0 || ^6.0",
         "squizlabs/php_codesniffer": "^3.0",
         "editorconfig-checker/editorconfig-checker": "^10.0"
     },

Original file line number	Diff line number	Diff line change
`@@ -1,2 +1,3 @@`
`1`	`1`	`.Build`
`2`	`2`	`composer.lock`
	`3`	`+/var`
Original file line number	Diff line number	Diff line change
`@@ -6,7 +6,7 @@`
`6`	`6`
`7`	`7`	`class ComponentLoaderTest extends \TYPO3\TestingFramework\Core\Unit\UnitTestCase`
`8`	`8`	`{`
`9`		`- protected function setUp()`
	`9`	`+ protected function setUp(): void`
`10`	`10`	`{`
`11`	`11`	`parent::setUp();`
`12`	`12`
Original file line number	Diff line number	Diff line change
`@@ -14,7 +14,7 @@ class XsdGeneratorTest extends \TYPO3\TestingFramework\Core\Unit\UnitTestCase`
`14`	`14`	`protected $fluidNamespaces = null;`
`15`	`15`	`protected $componentLoader = null;`
`16`	`16`
`17`		`- protected function setUp()`
	`17`	`+ protected function setUp(): void`
`18`	`18`	`{`
`19`	`19`	`parent::setUp();`
`20`	`20`
`@@ -74,7 +74,7 @@ public function getDefaultPrefixForNamespace() {`
`74`	`74`
`75`	`75`	`}`
`76`	`76`
`77`		`- public function tearDown()`
	`77`	`+ public function tearDown(): void`
`78`	`78`	`{`
`79`	`79`	`$GLOBALS['TYPO3_CONF_VARS']['SYS']['fluid']['namespaces'] = $this->fluidNamespaces;`
`80`	`80`	`parent::tearDown();`