backup

Author: IvanIvanoff

lib/sanbase/menu/menus.ex

@@ -121,19 +121,19 @@ defmodule Sanbase.Menus do
           )
       end
     end)
-    |> Ecto.Multi.run(
-      :get_menu_with_preloads,
-      fn _repo, %{create_menu: menu, maybe_create_menu_item: menu_or_nil} ->
-        # If the menu was created as a sub-menu, then the `maybe_create_menu_item` step
-        # has already returned the menu with preloads. Otherwise, we need to preload it here.
-        case menu_or_nil do
-          %Menu{} = m -> {:ok, m}
-          nil -> get_menu(menu.id, user_id)
-        end
-      end
-    )
+    # |> Ecto.Multi.run(
+    #   :get_menu_with_preloads,
+    #   fn _repo, %{create_menu: menu, maybe_create_menu_item: menu_or_nil} ->
+    #     # If the menu was created as a sub-menu, then the `maybe_create_menu_item` step
+    #     # has already returned the menu with preloads. Otherwise, we need to preload it here.
+    #     case menu_or_nil do
+    #       %Menu{} = m -> {:ok, m}
+    #       nil -> get_menu(menu.id, user_id)
+    #     end
+    #   end
+    # )
     |> Repo.transaction()
-    |> process_transaction_result(:get_menu_with_preloads)
+    |> process_transaction_result(:create_menu)
   end
 
   @doc ~s"""

priv/repo/migrations/20231110093800_create_menus_table.exs

@@ -2,11 +2,12 @@ defmodule Sanbase.Repo.Migrations.CreatesMenusTable do
   use Ecto.Migration
 
   def change do
+    # Create menus table
     create table(:menus) do
       add(:name, :string)
       add(:description, :string)
 
-      add(:parent_id, references(:menus, on_delete: :delete_all))
+      add(:parent_id, references(:menus, on_delete: :nilify_all))
 
       add(:user_id, references(:users, on_delete: :delete_all))
 
@@ -15,12 +16,9 @@ defmodule Sanbase.Repo.Migrations.CreatesMenusTable do
       timestamps()
     end
 
-    # When searching for all sub-menus of a menu, the `where` clause will
-    # find these submenus by the root_parent_id, hence the index. The
-    # parent_id is used only to build the hierarchy after that.
-    create(index(:menus, [:root_parent_id]))
     create(index(:menus, [:user_id]))
 
+    # Create menu_items table
     create table(:menu_items) do
       add(:parent_id, references(:menus, on_delete: :delete_all))
 

priv/repo/structure.sql

@@ -2062,7 +2062,6 @@ CREATE TABLE public.menus (
     name character varying(255),
     description character varying(255),
     parent_id bigint,
-    root_parent_id bigint,
     user_id bigint,
     is_global boolean DEFAULT false,
     inserted_at timestamp without time zone NOT NULL,
@@ -6735,13 +6734,6 @@ CREATE UNIQUE INDEX list_items_user_list_id_project_id_index ON public.list_item
 CREATE UNIQUE INDEX market_segments_name_index ON public.market_segments USING btree (name);
 
 
---
--- Name: menus_root_parent_id_index; Type: INDEX; Schema: public; Owner: -
---
-
-CREATE INDEX menus_root_parent_id_index ON public.menus USING btree (root_parent_id);
-
-
 --
 -- Name: menus_user_id_index; Type: INDEX; Schema: public; Owner: -
 --
@@ -7922,15 +7914,7 @@ ALTER TABLE ONLY public.menu_items
 --
 
 ALTER TABLE ONLY public.menus
-    ADD CONSTRAINT menus_parent_id_fkey FOREIGN KEY (parent_id) REFERENCES public.menus(id) ON DELETE CASCADE;
-
-
---
--- Name: menus menus_root_parent_id_fkey; Type: FK CONSTRAINT; Schema: public; Owner: -
---
-
-ALTER TABLE ONLY public.menus
-    ADD CONSTRAINT menus_root_parent_id_fkey FOREIGN KEY (root_parent_id) REFERENCES public.menus(id) ON DELETE CASCADE;
+    ADD CONSTRAINT menus_parent_id_fkey FOREIGN KEY (parent_id) REFERENCES public.menus(id) ON DELETE SET NULL;
 
 
 --