Fix a Phan issue and improve the uploads example script

Author: samwilson

.phan/baseline.php

@@ -17,11 +17,6 @@
         'src/GroupsPoolsApi.php' => ['PhanUnextractableAnnotation'],
         'src/InterestingnessApi.php' => ['PhanUnextractableAnnotation'],
         'src/MachinetagsApi.php' => ['PhanUnextractableAnnotation'],
-        'src/Oauth/PhpFlickrService.php' => [
-            'PhanUndeclaredClass', 'PhanUndeclaredClassMethod', 'PhanUndeclaredExtendedClass',
-            'PhanUndeclaredMethod', 'PhanUndeclaredProperty', 'PhanUndeclaredTypeParameter',
-            'PhanUnreferencedUseNormal'
-        ],
         'src/PandaApi.php' => ['PhanUnextractableAnnotation'],
         'src/PeopleApi.php' => ['PhanUnextractableAnnotation'],
         'src/PhotosApi.php' => ['PhanTypeMismatchDefault', 'PhanTypeMismatchForeach', 'PhanUnextractableAnnotation'],

examples/uploads.php

@@ -35,5 +35,9 @@
     true,
     true
 );
-$info = $phpFlickr->photos()->getInfo($result['photoid']);
-echo "The new photo is: " . $info['urls']['url'][0]['_content'] . "\n";
+if ($result['stat'] === 'fail') {
+    echo $result['message'] . "\n";
+} else {
+    $info = $phpFlickr->photos()->getInfo($result['photoid']);
+    echo "The new photo is: " . $info['urls']['url'][0]['_content'] . "\n";
+}

src/Oauth/PhpFlickrService.php

@@ -9,6 +9,7 @@
 use OAuth\Common\Storage\TokenStorageInterface;
 use OAuth\OAuth1\Service\Flickr;
 use OAuth\OAuth1\Signature\SignatureInterface;
+use OAuth\OAuth1\Token\TokenInterface;
 
 class PhpFlickrService extends Flickr
 {
@@ -71,6 +72,7 @@ public function service()
     public function getAuthorizationForPostingToAlternateUrl($args, $uri)
     {
         $token = $this->storage->retrieveAccessToken($this->service());
+        assert($token instanceof TokenInterface);
         $this->signature->setTokenSecret($token->getAccessTokenSecret());
         $authParameters = $this->getBasicAuthorizationHeaderInfo();
         if (isset($authParameters['oauth_callback'])) {