Skip to content

Commit 24f8963

Browse files
veblushcopybara-github
authored andcommitted
[Test] Removed obsolete node test from run_tests.py (grpc#35525)
I guess we don't need Node in run_tests.py any more? Closes grpc#35525 COPYBARA_INTEGRATE_REVIEW=grpc#35525 from veblush:node-x 0572935 PiperOrigin-RevId: 599874102
1 parent a329d43 commit 24f8963

File tree

1 file changed

+0
-78
lines changed

1 file changed

+0
-78
lines changed

tools/run_tests/run_tests.py

Lines changed: 0 additions & 78 deletions
Original file line numberDiff line numberDiff line change
@@ -606,81 +606,6 @@ def __str__(self):
606606
return self.lang_suffix
607607

608608

609-
# This tests Node on grpc/grpc-node and will become the standard for Node testing
610-
class RemoteNodeLanguage(object):
611-
def __init__(self):
612-
self.platform = platform_string()
613-
614-
def configure(self, config, args):
615-
self.config = config
616-
self.args = args
617-
# Note: electron ABI only depends on major and minor version, so that's all
618-
# we should specify in the compiler argument
619-
_check_compiler(
620-
self.args.compiler,
621-
[
622-
"default",
623-
"node0.12",
624-
"node4",
625-
"node5",
626-
"node6",
627-
"node7",
628-
"node8",
629-
"electron1.3",
630-
"electron1.6",
631-
],
632-
)
633-
if self.args.compiler == "default":
634-
self.runtime = "node"
635-
self.node_version = "8"
636-
else:
637-
if self.args.compiler.startswith("electron"):
638-
self.runtime = "electron"
639-
self.node_version = self.args.compiler[8:]
640-
else:
641-
self.runtime = "node"
642-
# Take off the word "node"
643-
self.node_version = self.args.compiler[4:]
644-
645-
# TODO: update with Windows/electron scripts when available for grpc/grpc-node
646-
def test_specs(self):
647-
if self.platform == "windows":
648-
return [
649-
self.config.job_spec(
650-
["tools\\run_tests\\helper_scripts\\run_node.bat"]
651-
)
652-
]
653-
else:
654-
return [
655-
self.config.job_spec(
656-
["tools/run_tests/helper_scripts/run_grpc-node.sh"],
657-
None,
658-
environ=_FORCE_ENVIRON_FOR_WRAPPERS,
659-
)
660-
]
661-
662-
def pre_build_steps(self):
663-
return []
664-
665-
def build_steps(self):
666-
return []
667-
668-
def build_steps_environ(self):
669-
"""Extra environment variables set for pre_build_steps and build_steps jobs."""
670-
return {}
671-
672-
def post_tests_steps(self):
673-
return []
674-
675-
def dockerfile_dir(self):
676-
return "tools/dockerfile/test/node_jessie_%s" % _docker_arch_suffix(
677-
self.args.arch
678-
)
679-
680-
def __str__(self):
681-
return "grpc-node"
682-
683-
684609
class Php7Language(object):
685610
def configure(self, config, args):
686611
self.config = config
@@ -1327,7 +1252,6 @@ def __str__(self):
13271252
_LANGUAGES = {
13281253
"c++": CLanguage("cxx", "c++"),
13291254
"c": CLanguage("c", "c"),
1330-
"grpc-node": RemoteNodeLanguage(),
13311255
"php7": Php7Language(),
13321256
"python": PythonLanguage(),
13331257
"ruby": RubyLanguage(),
@@ -1756,8 +1680,6 @@ def _build_and_run(
17561680
"pypy3",
17571681
"python_alpine",
17581682
"all_the_cpythons",
1759-
"electron1.3",
1760-
"electron1.6",
17611683
"coreclr",
17621684
"cmake",
17631685
"cmake_ninja_vs2019",

0 commit comments

Comments
 (0)