Skip to content

Commit 8638cf2

Browse files
szczechaszczecha
committed
replace @ with # in test tags
add changeset
1 parent 80fe18e commit 8638cf2

39 files changed

+161
-156
lines changed

‎.changeset/lucky-windows-sin.md

+5
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"saleor-dashboard": patch
3+
---
4+
5+
Test reports no longer mention users due to test tags matching GitHub usernames.

‎.github/actions/run-pw-tests/action.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -89,7 +89,7 @@ runs:
8989
PROJECT_PARAMS+="--project=${PROJECT} "
9090
done
9191
echo "reportName=all-blob-reports-${SHARD_NUMBER%%/*}" >> $GITHUB_ENV
92-
npx playwright test --grep @e2e $PROJECT_PARAMS --shard "$SHARD_NUMBER"
92+
npx playwright test --grep \"#e2e\" $PROJECT_PARAMS --shard "$SHARD_NUMBER"
9393
9494
- name: Upload blob report to GitHub Actions Artifacts
9595
uses: actions/upload-artifact@v4

‎package.json

+2-2
Original file line numberDiff line numberDiff line change
@@ -280,10 +280,10 @@
280280
"qa:move-videos": "find cypress/videos -type f -name \"*.js.mp4\" -exec mv {} cypress/reports/mochareports/videos \\;",
281281
"qa:artifact-move-screenshots": "find cypress/reports/*/mochareports -type d -name \"*.js\" -exec mv {} cypress/reports/mochareports \\;",
282282
"qa:artifact-move-videos": "find cypress/reports/*/mochareports/videos -type f -name \"*.js.mp4\" -exec mv {} cypress/reports/mochareports/videos \\;",
283-
"qa:pw-e2e": "npx playwright test --grep @e2e",
283+
"qa:pw-e2e": "npx playwright test --grep \"#e2e\"",
284284
"qa:pw-ui": "npx playwright test --ui",
285285
"knip": "knip --reporter markdown",
286286
"knip:fix": "knip --fix"
287287
},
288288
"description": "![Saleor Dashboard](https://user-images.githubusercontent.com/44495184/185379472-2a204c0b-9b7a-4a3e-93c0-2cb85205ed5e.png)"
289-
}
289+
}

‎playwright/tests/apps.spec.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ const PRE_INSTALLATION_TIMEOUT = 20 * 1000;
2121
const INSTALLATION_PENDING_TIMEOUT = 50 * 1000;
2222
const APP_EXPECT_UI_TIMEOUT = 15 * 1000;
2323

24-
test("TC: SALEOR_119 User should be able to install and configure app from manifest @e2e", async ({
24+
test("TC: SALEOR_119 User should be able to install and configure app from manifest #e2e", async ({
2525
page,
2626
}) => {
2727
await appsPage.gotoAppsList();
@@ -56,7 +56,7 @@ test("TC: SALEOR_119 User should be able to install and configure app from manif
5656
await iframeLocator.getByText("Save").click();
5757
await appsPage.expectSuccessBanner({ timeout: INSTALLATION_PENDING_TIMEOUT });
5858
});
59-
test("TC: SALEOR_120 User should be able to delete thirdparty app @e2e", async () => {
59+
test("TC: SALEOR_120 User should be able to delete thirdparty app #e2e", async () => {
6060
await appPage.waitForNetworkIdleAfterAction(() =>
6161
appPage.goToExistingAppPage(APPS.appToBeDeleted.id),
6262
);

‎playwright/tests/attributes.spec.ts

+7-7
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ for (const attr of attributeClasses) {
2222
for (const type of ATTRIBUTES.attributeTypesWithAbilityToAddValues.names) {
2323
const uniqueSlug = `${attr}-${type}-${SALEOR_124_uuid}`.replace(/\s+/g, "-");
2424

25-
test(`TC: SALEOR_124 User should be able to create ${attr} ${type} attribute with ability to add values, required, public @e2e @attributes`, async ({
25+
test(`TC: SALEOR_124 User should be able to create ${attr} ${type} attribute with ability to add values, required, public #e2e #attributes`, async ({
2626
page,
2727
}) => {
2828
await page.context().storageState({ path: "./playwright/.auth/admin.json" });
@@ -56,7 +56,7 @@ for (const attr of attributeClasses) {
5656
for (const type of ATTRIBUTES.attributeTypesWithoutAbilityToAddValues.names) {
5757
const uniqueSlug = `${attr}-${type}-${SALEOR_125_uuid}`.replace(/\s+/g, "-");
5858

59-
test(`TC: SALEOR_125 User should be able to create ${attr} ${type} attribute without ability to add values, NOT required, private @e2e @attributes`, async ({
59+
test(`TC: SALEOR_125 User should be able to create ${attr} ${type} attribute without ability to add values, NOT required, private #e2e #attributes`, async ({
6060
page,
6161
}) => {
6262
await page.context().storageState({ path: "./playwright/.auth/admin.json" });
@@ -91,7 +91,7 @@ for (const attr of attributeClasses) {
9191
for (const entity of ATTRIBUTES.attributeReferencesEntities.names) {
9292
const uniqueSlug = `${attr}-${entity}-${SALEOR_126_uuid}`.replace(/\s+/g, "-");
9393

94-
test(`TC: SALEOR_126 User should be able to create ${attr} References attribute for ${entity}, NOT required, public @e2e @attributes`, async ({
94+
test(`TC: SALEOR_126 User should be able to create ${attr} References attribute for ${entity}, NOT required, public #e2e #attributes`, async ({
9595
page,
9696
}) => {
9797
await page.context().storageState({ path: "./playwright/.auth/admin.json" });
@@ -133,7 +133,7 @@ const contentAttrWithValues = {
133133
const attributesWithValuesToBeUpdated = [productAttrWithValues, contentAttrWithValues];
134134

135135
for (const attribute of attributesWithValuesToBeUpdated) {
136-
test(`TC: SALEOR_127 User should be able to update attribute values in existing ${attribute.name} attribute @e2e @attributes`, async () => {
136+
test(`TC: SALEOR_127 User should be able to update attribute values in existing ${attribute.name} attribute #e2e #attributes`, async () => {
137137
await attributesPage.gotoExistingAttributePage(attribute.id, attribute.name);
138138
await attributesPage.clickDeleteAttrValueButton(attribute.valueToBeDeleted);
139139
await expect(attributesPage.dialog).toBeVisible();
@@ -160,7 +160,7 @@ for (const attribute of attributesWithValuesToBeUpdated) {
160160
}
161161

162162
for (const attr of ATTRIBUTES.attributesToBeUpdated) {
163-
test(`TC: SALEOR_128 User should be able to edit existing ${attr.name} attribute @e2e @attributes`, async () => {
163+
test(`TC: SALEOR_128 User should be able to edit existing ${attr.name} attribute #e2e #attributes`, async () => {
164164
await attributesPage.gotoExistingAttributePage(attr.id, attr.name);
165165

166166
await attributesPage.attributeDefaultLabelInput.fill(`updated ${attr.name}`);
@@ -198,7 +198,7 @@ const contentAttribute = {
198198
const attributesToBeDeleted = [productAttribute, contentAttribute];
199199

200200
for (const attribute of attributesToBeDeleted) {
201-
test(`TC: SALEOR_129 Delete a single ${attribute.name} @e2e @attributes`, async () => {
201+
test(`TC: SALEOR_129 Delete a single ${attribute.name} #e2e #attributes`, async () => {
202202
await attributesPage.gotoExistingAttributePage(attribute.id, attribute.name);
203203
await attributesPage.clickDeleteButton();
204204
await attributesPage.dialog.waitFor({
@@ -212,7 +212,7 @@ for (const attribute of attributesToBeDeleted) {
212212
});
213213
}
214214

215-
test("TC: SALEOR_130 Bulk delete attributes @e2e @attributes", async () => {
215+
test("TC: SALEOR_130 Bulk delete attributes #e2e #attributes", async () => {
216216
await attributesPage.gotoListView();
217217
await attributesPage.searchAndFindRowIndexes("e2e attribute to be bulk deleted");
218218
await attributesPage.clickGridCell(0, 0);

‎playwright/tests/categories.spec.ts

+3-3
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ let categoriesPage: CategoriesPage;
1010
test.beforeEach(({ page }) => {
1111
categoriesPage = new CategoriesPage(page);
1212
});
13-
test("TC: SALEOR_102 Create basic category @e2e @category", async () => {
13+
test("TC: SALEOR_102 Create basic category #e2e #category", async () => {
1414
await categoriesPage.gotoCategoryListView();
1515
await categoriesPage.waitForDatagridLoaderToDisappear();
1616
await categoriesPage.clickCreateNewCategoryButton();
@@ -21,7 +21,7 @@ test("TC: SALEOR_102 Create basic category @e2e @category", async () => {
2121
await categoriesPage.clickSaveButton();
2222
await categoriesPage.expectSuccessBanner();
2323
});
24-
test("TC: SALEOR_103 Edit category @e2e @category", async () => {
24+
test("TC: SALEOR_103 Edit category #e2e #category", async () => {
2525
await categoriesPage.gotoExistingCategoriesPage(CATEGORIES.categoryToBeUpdated.id);
2626
await categoriesPage.typeCategoryName("Updated category");
2727
await categoriesPage.typeCategoryDescription("Utils description updated");
@@ -30,7 +30,7 @@ test("TC: SALEOR_103 Edit category @e2e @category", async () => {
3030
await categoriesPage.expectSuccessBanner();
3131
await expect(categoriesPage.productsGridList).toContainText("beer to be updated");
3232
});
33-
test("TC: SALEOR_104 Bulk delete categories @e2e @category", async () => {
33+
test("TC: SALEOR_104 Bulk delete categories #e2e #category", async () => {
3434
await categoriesPage.gotoCategoryListView();
3535
await categoriesPage.waitForDOMToFullyLoad();
3636
await categoriesPage.checkListRowsBasedOnContainingText(

‎playwright/tests/channels.spec.ts

+4-4
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ test.beforeEach(({ page }) => {
1313
configurationPage = new ConfigurationPage(page);
1414
channelPage = new ChannelPage(page);
1515
});
16-
test("TC: SALEOR_97 Create basic channel @e2e @channels", async () => {
16+
test("TC: SALEOR_97 Create basic channel #e2e #channels", async () => {
1717
const slugName = new Date().toISOString();
1818

1919
await configurationPage.goToConfigurationView();
@@ -27,7 +27,7 @@ test("TC: SALEOR_97 Create basic channel @e2e @channels", async () => {
2727
await channelPage.expectSuccessBanner();
2828
});
2929

30-
test("TC: SALEOR_208 Create channel with all settings @e2e @channels", async () => {
30+
test("TC: SALEOR_208 Create channel with all settings #e2e #channels", async () => {
3131
const slugName = new Date().toISOString();
3232

3333
await configurationPage.goToConfigurationView();
@@ -54,7 +54,7 @@ test("TC: SALEOR_208 Create channel with all settings @e2e @channels", async ()
5454
await expect(channelPage.allowUnpaidOrdersCheckbox).toBeChecked();
5555
});
5656

57-
test("TC: SALEOR_98 Edit channel - transaction flow, allow unpaid, authorize, prio high stock @e2e @channels", async () => {
57+
test("TC: SALEOR_98 Edit channel - transaction flow, allow unpaid, authorize, prio high stock #e2e #channels", async () => {
5858
await channelPage.gotoChannelDetails(CHANNELS.channelToBeEditedSettings.id);
5959
await channelPage.clickTransactionFlowCheckbox();
6060
await channelPage.clickAllowUnpaidOrdersCheckbox();
@@ -66,7 +66,7 @@ test("TC: SALEOR_98 Edit channel - transaction flow, allow unpaid, authorize, pr
6666
await channelPage.clickSaveButton();
6767
await channelPage.expectSuccessBanner();
6868
});
69-
test("TC: SALEOR_99 Delete channel @e2e @channels", async () => {
69+
test("TC: SALEOR_99 Delete channel #e2e #channels", async () => {
7070
await channelPage.gotoChannelList();
7171
await channelPage.clickDeleteButtonOnRowContainingChannelName(CHANNELS.channelToBeDeleted.name);
7272
await channelPage.deleteChannelDialog.clickDeleteButton();

‎playwright/tests/collections.spec.ts

+3-3
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ let collectionsPage: CollectionsPage;
1010
test.beforeEach(({ page }) => {
1111
collectionsPage = new CollectionsPage(page);
1212
});
13-
test("TC: SALEOR_112 Create collection @collections @e2e", async () => {
13+
test("TC: SALEOR_112 Create collection #collections #e2e", async () => {
1414
await collectionsPage.gotoCollectionsListView();
1515
await collectionsPage.waitForDOMToFullyLoad();
1616
await collectionsPage.clickCreateCollectionButton();
@@ -27,7 +27,7 @@ test("TC: SALEOR_112 Create collection @collections @e2e", async () => {
2727
await collectionsPage.clickSaveButton();
2828
await collectionsPage.expectSuccessBanner();
2929
});
30-
test("TC: SALEOR_113 Edit collection: assign product @collections @e2e", async () => {
30+
test("TC: SALEOR_113 Edit collection: assign product #collections #e2e", async () => {
3131
const productToBeAssigned = "Bean Juice";
3232

3333
await collectionsPage.gotoExistingCollectionView(COLLECTIONS.collectionToBeUpdated.id);
@@ -45,7 +45,7 @@ test("TC: SALEOR_113 Edit collection: assign product @collections @e2e", async (
4545
`Only 1 category should be visible in table`,
4646
).toEqual(1);
4747
});
48-
test("TC: SALEOR_114 Bulk delete collections @collections @e2e", async () => {
48+
test("TC: SALEOR_114 Bulk delete collections #collections #e2e", async () => {
4949
await collectionsPage.gotoCollectionsListView();
5050
await collectionsPage.waitForDOMToFullyLoad();
5151
await collectionsPage.checkListRowsBasedOnContainingText(

‎playwright/tests/customers.spec.ts

+11-11
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ test.beforeEach(({ page }) => {
2828
deleteAddressDialog = new DeleteAddressDialog(page);
2929
});
3030

31-
test("TC: SALEOR_199 Create customer @e2e @customer", async () => {
31+
test("TC: SALEOR_199 Create customer #e2e #customer", async () => {
3232
const firstName = faker.name.firstName();
3333
const lastName = faker.name.lastName();
3434
const note = faker.lorem.sentence();
@@ -56,7 +56,7 @@ test("TC: SALEOR_199 Create customer @e2e @customer", async () => {
5656
await expect(customersPage.customerEmailInput).toHaveValue(email.toLowerCase());
5757
});
5858

59-
test("TC: SALEOR_200 As an admin I should not be able to create customer with duplicated email @e2e @customer", async () => {
59+
test("TC: SALEOR_200 As an admin I should not be able to create customer with duplicated email #e2e #customer", async () => {
6060
const firstName = faker.name.firstName();
6161
const lastName = faker.name.lastName();
6262
const note = faker.lorem.sentence();
@@ -78,7 +78,7 @@ test("TC: SALEOR_200 As an admin I should not be able to create customer with du
7878
await customersPage.expectErrorBannerMessage("User with this Email already exists.");
7979
});
8080

81-
test("TC: SALEOR_201 Update customer account info @e2e @customer", async () => {
81+
test("TC: SALEOR_201 Update customer account info #e2e #customer", async () => {
8282
const firstName = faker.name.firstName();
8383
const lastName = faker.name.lastName();
8484
const email = faker.internet.email();
@@ -97,23 +97,23 @@ test("TC: SALEOR_201 Update customer account info @e2e @customer", async () => {
9797
await expect(customersPage.customerEmailInput).toHaveValue(email.toLowerCase());
9898
});
9999

100-
test("TC: SALEOR_202 Deactivate a customer @e2e @customer", async () => {
100+
test("TC: SALEOR_202 Deactivate a customer #e2e #customer", async () => {
101101
await customersPage.gotoCustomerDetailsPage(CUSTOMERS.customerToBeDeactivated.id);
102102
await customersPage.customerActiveCheckbox.click();
103103
await customersPage.saveCustomer();
104104
await customersPage.expectSuccessBanner();
105105
await expect(customersPage.customerActiveCheckbox).not.toBeChecked();
106106
});
107107

108-
test("TC: SALEOR_203 Activate a customer @e2e @customer", async () => {
108+
test("TC: SALEOR_203 Activate a customer #e2e #customer", async () => {
109109
await customersPage.gotoCustomerDetailsPage(CUSTOMERS.customerToBeActivated.id);
110110
await customersPage.customerActiveCheckbox.click();
111111
await customersPage.saveCustomer();
112112
await customersPage.expectSuccessBanner();
113113
await expect(customersPage.customerActiveCheckbox).toBeChecked();
114114
});
115115

116-
test("TC: SALEOR_204 Delete customer from the details page @e2e @customer", async () => {
116+
test("TC: SALEOR_204 Delete customer from the details page #e2e #customer", async () => {
117117
await customersPage.gotoCustomerDetailsPage(CUSTOMERS.deleteCustomer.id);
118118
await customersPage.deleteCustomer();
119119
await customersPage.deleteDialog.clickDeleteButton();
@@ -123,7 +123,7 @@ test("TC: SALEOR_204 Delete customer from the details page @e2e @customer", asyn
123123
await expect(customersPage.emptyDataGridListView).toBeVisible();
124124
});
125125

126-
test("TC: SALEOR_205 Bulk delete customers @e2e @customer", async () => {
126+
test("TC: SALEOR_205 Bulk delete customers #e2e #customer", async () => {
127127
const customersToBeBulkDeleted = CUSTOMERS.customersToBeBulkDeleted.names;
128128

129129
await customersPage.goToCustomersListView();
@@ -139,7 +139,7 @@ test("TC: SALEOR_205 Bulk delete customers @e2e @customer", async () => {
139139
await expect(customersPage.emptyDataGridListView).toBeVisible();
140140
});
141141

142-
test("TC: SALEOR_206 As an admin I want to add address to the customer and set it as default shipping @e2e @customer", async () => {
142+
test("TC: SALEOR_206 As an admin I want to add address to the customer and set it as default shipping #e2e #customer", async () => {
143143
await customersPage.gotoCustomerDetailsPage(CUSTOMERS.editCustomer.id);
144144
await addressesListPage.clickManageAddresses();
145145
await addressesListPage.clickAddAddressButton();
@@ -167,7 +167,7 @@ test("TC: SALEOR_206 As an admin I want to add address to the customer and set i
167167
);
168168
});
169169

170-
test("TC: SALEOR_209 As an admin I want to update customer's address and set it as default billing @e2e @customer", async () => {
170+
test("TC: SALEOR_209 As an admin I want to update customer's address and set it as default billing #e2e #customer", async () => {
171171
await customersPage.gotoCustomerDetailsPage(CUSTOMERS.editCustomer.id);
172172
await addressesListPage.clickManageAddresses();
173173
await addressesListPage.clickShowMoreMenu(CUSTOMERS.editCustomer.initialShippingAddress.lastName);
@@ -198,7 +198,7 @@ test("TC: SALEOR_209 As an admin I want to update customer's address and set it
198198
);
199199
});
200200

201-
test("TC: SALEOR_210 Delete customer's address @e2e @customer", async () => {
201+
test("TC: SALEOR_210 Delete customer's address #e2e #customer", async () => {
202202
await customersPage.gotoCustomerDetailsPage(CUSTOMERS.editCustomer.id);
203203
await addressesListPage.clickManageAddresses();
204204
await addressesListPage.clickShowMoreMenu(CUSTOMERS.editCustomer.initialBillingAddress.lastName);
@@ -211,7 +211,7 @@ test("TC: SALEOR_210 Delete customer's address @e2e @customer", async () => {
211211
).not.toBeVisible();
212212
});
213213

214-
test("TC: SALEOR_207 Issue a new gift card for the customer @e2e @customer", async () => {
214+
test("TC: SALEOR_207 Issue a new gift card for the customer #e2e #customer", async () => {
215215
const amount = faker.datatype.number(1000).toPrecision(2).toString();
216216

217217
await customersPage.gotoCustomerDetailsPage(CUSTOMERS.editCustomer.id);

0 commit comments

Comments
 (0)