Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: change listview in GenreMoodPage into gridview #67

Open
rgrnetalk opened this issue Jan 27, 2019 · 1 comment
Open

Proposal: change listview in GenreMoodPage into gridview #67

rgrnetalk opened this issue Jan 27, 2019 · 1 comment

Comments

@rgrnetalk
Copy link

rgrnetalk commented Jan 27, 2019

I have changed the listview in the genremoodpage into a gridview. This has two advantages:

  1. scrolling is limited
  2. you can have all genres in one page *)
    and one disadvantage:
  3. long genre names don't fit.
    *) Only when the retrieve genre call is changed so that all genres are retreived in one call (then you don't have to use the load previous/next set menu), this can be done by changing the line property int limit: app.searchLimit.value into property int limit: 45
    Here's the new page (with the original app.searchLimit.value):
    genremoodspage
@ksiazkowicz
Copy link
Contributor

  1. What about making genre name multiline?
  2. Can you make a PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants