Skip to content

Commit d2bc0c2

Browse files
authored
Revert "Verify early OK behavior"
1 parent eb8af5c commit d2bc0c2

File tree

7 files changed

+28
-374
lines changed

7 files changed

+28
-374
lines changed

src/python/grpcio_tests/tests/tests.json

-162
Original file line numberDiff line numberDiff line change
@@ -38,168 +38,6 @@
3838
"unit._cython.cygrpc_test.InsecureServerInsecureClient",
3939
"unit._cython.cygrpc_test.SecureServerSecureClient",
4040
"unit._cython.cygrpc_test.TypeSmokeTest",
41-
"unit._early_ok_test.ManyEmptyRequestsTwoReadManyEmptyResponsesEarlyOKTest",
42-
"unit._early_ok_test.ManyEmptyRequestsTwoReadManyLargeResponsesEarlyOKTest",
43-
"unit._early_ok_test.ManyEmptyRequestsTwoReadManySmallResponsesEarlyOKTest",
44-
"unit._early_ok_test.ManyEmptyRequestsTwoReadTwoEmptyResponsesEarlyOKTest",
45-
"unit._early_ok_test.ManyEmptyRequestsTwoReadTwoLargeResponsesEarlyOKTest",
46-
"unit._early_ok_test.ManyEmptyRequestsTwoReadTwoSmallResponsesEarlyOKTest",
47-
"unit._early_ok_test.ManyEmptyRequestsTwoReadZeroEmptyResponsesEarlyOKTest",
48-
"unit._early_ok_test.ManyEmptyRequestsTwoReadZeroLargeResponsesEarlyOKTest",
49-
"unit._early_ok_test.ManyEmptyRequestsTwoReadZeroSmallResponsesEarlyOKTest",
50-
"unit._early_ok_test.ManyEmptyRequestsZeroReadManyEmptyResponsesEarlyOKTest",
51-
"unit._early_ok_test.ManyEmptyRequestsZeroReadManyLargeResponsesEarlyOKTest",
52-
"unit._early_ok_test.ManyEmptyRequestsZeroReadManySmallResponsesEarlyOKTest",
53-
"unit._early_ok_test.ManyEmptyRequestsZeroReadTwoEmptyResponsesEarlyOKTest",
54-
"unit._early_ok_test.ManyEmptyRequestsZeroReadTwoLargeResponsesEarlyOKTest",
55-
"unit._early_ok_test.ManyEmptyRequestsZeroReadTwoSmallResponsesEarlyOKTest",
56-
"unit._early_ok_test.ManyEmptyRequestsZeroReadZeroEmptyResponsesEarlyOKTest",
57-
"unit._early_ok_test.ManyEmptyRequestsZeroReadZeroLargeResponsesEarlyOKTest",
58-
"unit._early_ok_test.ManyEmptyRequestsZeroReadZeroSmallResponsesEarlyOKTest",
59-
"unit._early_ok_test.ManyLargeRequestsTwoReadManyEmptyResponsesEarlyOKTest",
60-
"unit._early_ok_test.ManyLargeRequestsTwoReadManyLargeResponsesEarlyOKTest",
61-
"unit._early_ok_test.ManyLargeRequestsTwoReadManySmallResponsesEarlyOKTest",
62-
"unit._early_ok_test.ManyLargeRequestsTwoReadTwoEmptyResponsesEarlyOKTest",
63-
"unit._early_ok_test.ManyLargeRequestsTwoReadTwoLargeResponsesEarlyOKTest",
64-
"unit._early_ok_test.ManyLargeRequestsTwoReadTwoSmallResponsesEarlyOKTest",
65-
"unit._early_ok_test.ManyLargeRequestsTwoReadZeroEmptyResponsesEarlyOKTest",
66-
"unit._early_ok_test.ManyLargeRequestsTwoReadZeroLargeResponsesEarlyOKTest",
67-
"unit._early_ok_test.ManyLargeRequestsTwoReadZeroSmallResponsesEarlyOKTest",
68-
"unit._early_ok_test.ManyLargeRequestsZeroReadManyEmptyResponsesEarlyOKTest",
69-
"unit._early_ok_test.ManyLargeRequestsZeroReadManyLargeResponsesEarlyOKTest",
70-
"unit._early_ok_test.ManyLargeRequestsZeroReadManySmallResponsesEarlyOKTest",
71-
"unit._early_ok_test.ManyLargeRequestsZeroReadTwoEmptyResponsesEarlyOKTest",
72-
"unit._early_ok_test.ManyLargeRequestsZeroReadTwoLargeResponsesEarlyOKTest",
73-
"unit._early_ok_test.ManyLargeRequestsZeroReadTwoSmallResponsesEarlyOKTest",
74-
"unit._early_ok_test.ManyLargeRequestsZeroReadZeroEmptyResponsesEarlyOKTest",
75-
"unit._early_ok_test.ManyLargeRequestsZeroReadZeroLargeResponsesEarlyOKTest",
76-
"unit._early_ok_test.ManyLargeRequestsZeroReadZeroSmallResponsesEarlyOKTest",
77-
"unit._early_ok_test.ManySmallRequestsTwoReadManyEmptyResponsesEarlyOKTest",
78-
"unit._early_ok_test.ManySmallRequestsTwoReadManyLargeResponsesEarlyOKTest",
79-
"unit._early_ok_test.ManySmallRequestsTwoReadManySmallResponsesEarlyOKTest",
80-
"unit._early_ok_test.ManySmallRequestsTwoReadTwoEmptyResponsesEarlyOKTest",
81-
"unit._early_ok_test.ManySmallRequestsTwoReadTwoLargeResponsesEarlyOKTest",
82-
"unit._early_ok_test.ManySmallRequestsTwoReadTwoSmallResponsesEarlyOKTest",
83-
"unit._early_ok_test.ManySmallRequestsTwoReadZeroEmptyResponsesEarlyOKTest",
84-
"unit._early_ok_test.ManySmallRequestsTwoReadZeroLargeResponsesEarlyOKTest",
85-
"unit._early_ok_test.ManySmallRequestsTwoReadZeroSmallResponsesEarlyOKTest",
86-
"unit._early_ok_test.ManySmallRequestsZeroReadManyEmptyResponsesEarlyOKTest",
87-
"unit._early_ok_test.ManySmallRequestsZeroReadManyLargeResponsesEarlyOKTest",
88-
"unit._early_ok_test.ManySmallRequestsZeroReadManySmallResponsesEarlyOKTest",
89-
"unit._early_ok_test.ManySmallRequestsZeroReadTwoEmptyResponsesEarlyOKTest",
90-
"unit._early_ok_test.ManySmallRequestsZeroReadTwoLargeResponsesEarlyOKTest",
91-
"unit._early_ok_test.ManySmallRequestsZeroReadTwoSmallResponsesEarlyOKTest",
92-
"unit._early_ok_test.ManySmallRequestsZeroReadZeroEmptyResponsesEarlyOKTest",
93-
"unit._early_ok_test.ManySmallRequestsZeroReadZeroLargeResponsesEarlyOKTest",
94-
"unit._early_ok_test.ManySmallRequestsZeroReadZeroSmallResponsesEarlyOKTest",
95-
"unit._early_ok_test.TwoEmptyRequestsTwoReadManyEmptyResponsesEarlyOKTest",
96-
"unit._early_ok_test.TwoEmptyRequestsTwoReadManyLargeResponsesEarlyOKTest",
97-
"unit._early_ok_test.TwoEmptyRequestsTwoReadManySmallResponsesEarlyOKTest",
98-
"unit._early_ok_test.TwoEmptyRequestsTwoReadTwoEmptyResponsesEarlyOKTest",
99-
"unit._early_ok_test.TwoEmptyRequestsTwoReadTwoLargeResponsesEarlyOKTest",
100-
"unit._early_ok_test.TwoEmptyRequestsTwoReadTwoSmallResponsesEarlyOKTest",
101-
"unit._early_ok_test.TwoEmptyRequestsTwoReadZeroEmptyResponsesEarlyOKTest",
102-
"unit._early_ok_test.TwoEmptyRequestsTwoReadZeroLargeResponsesEarlyOKTest",
103-
"unit._early_ok_test.TwoEmptyRequestsTwoReadZeroSmallResponsesEarlyOKTest",
104-
"unit._early_ok_test.TwoEmptyRequestsZeroReadManyEmptyResponsesEarlyOKTest",
105-
"unit._early_ok_test.TwoEmptyRequestsZeroReadManyLargeResponsesEarlyOKTest",
106-
"unit._early_ok_test.TwoEmptyRequestsZeroReadManySmallResponsesEarlyOKTest",
107-
"unit._early_ok_test.TwoEmptyRequestsZeroReadTwoEmptyResponsesEarlyOKTest",
108-
"unit._early_ok_test.TwoEmptyRequestsZeroReadTwoLargeResponsesEarlyOKTest",
109-
"unit._early_ok_test.TwoEmptyRequestsZeroReadTwoSmallResponsesEarlyOKTest",
110-
"unit._early_ok_test.TwoEmptyRequestsZeroReadZeroEmptyResponsesEarlyOKTest",
111-
"unit._early_ok_test.TwoEmptyRequestsZeroReadZeroLargeResponsesEarlyOKTest",
112-
"unit._early_ok_test.TwoEmptyRequestsZeroReadZeroSmallResponsesEarlyOKTest",
113-
"unit._early_ok_test.TwoLargeRequestsTwoReadManyEmptyResponsesEarlyOKTest",
114-
"unit._early_ok_test.TwoLargeRequestsTwoReadManyLargeResponsesEarlyOKTest",
115-
"unit._early_ok_test.TwoLargeRequestsTwoReadManySmallResponsesEarlyOKTest",
116-
"unit._early_ok_test.TwoLargeRequestsTwoReadTwoEmptyResponsesEarlyOKTest",
117-
"unit._early_ok_test.TwoLargeRequestsTwoReadTwoLargeResponsesEarlyOKTest",
118-
"unit._early_ok_test.TwoLargeRequestsTwoReadTwoSmallResponsesEarlyOKTest",
119-
"unit._early_ok_test.TwoLargeRequestsTwoReadZeroEmptyResponsesEarlyOKTest",
120-
"unit._early_ok_test.TwoLargeRequestsTwoReadZeroLargeResponsesEarlyOKTest",
121-
"unit._early_ok_test.TwoLargeRequestsTwoReadZeroSmallResponsesEarlyOKTest",
122-
"unit._early_ok_test.TwoLargeRequestsZeroReadManyEmptyResponsesEarlyOKTest",
123-
"unit._early_ok_test.TwoLargeRequestsZeroReadManyLargeResponsesEarlyOKTest",
124-
"unit._early_ok_test.TwoLargeRequestsZeroReadManySmallResponsesEarlyOKTest",
125-
"unit._early_ok_test.TwoLargeRequestsZeroReadTwoEmptyResponsesEarlyOKTest",
126-
"unit._early_ok_test.TwoLargeRequestsZeroReadTwoLargeResponsesEarlyOKTest",
127-
"unit._early_ok_test.TwoLargeRequestsZeroReadTwoSmallResponsesEarlyOKTest",
128-
"unit._early_ok_test.TwoLargeRequestsZeroReadZeroEmptyResponsesEarlyOKTest",
129-
"unit._early_ok_test.TwoLargeRequestsZeroReadZeroLargeResponsesEarlyOKTest",
130-
"unit._early_ok_test.TwoLargeRequestsZeroReadZeroSmallResponsesEarlyOKTest",
131-
"unit._early_ok_test.TwoSmallRequestsTwoReadManyEmptyResponsesEarlyOKTest",
132-
"unit._early_ok_test.TwoSmallRequestsTwoReadManyLargeResponsesEarlyOKTest",
133-
"unit._early_ok_test.TwoSmallRequestsTwoReadManySmallResponsesEarlyOKTest",
134-
"unit._early_ok_test.TwoSmallRequestsTwoReadTwoEmptyResponsesEarlyOKTest",
135-
"unit._early_ok_test.TwoSmallRequestsTwoReadTwoLargeResponsesEarlyOKTest",
136-
"unit._early_ok_test.TwoSmallRequestsTwoReadTwoSmallResponsesEarlyOKTest",
137-
"unit._early_ok_test.TwoSmallRequestsTwoReadZeroEmptyResponsesEarlyOKTest",
138-
"unit._early_ok_test.TwoSmallRequestsTwoReadZeroLargeResponsesEarlyOKTest",
139-
"unit._early_ok_test.TwoSmallRequestsTwoReadZeroSmallResponsesEarlyOKTest",
140-
"unit._early_ok_test.TwoSmallRequestsZeroReadManyEmptyResponsesEarlyOKTest",
141-
"unit._early_ok_test.TwoSmallRequestsZeroReadManyLargeResponsesEarlyOKTest",
142-
"unit._early_ok_test.TwoSmallRequestsZeroReadManySmallResponsesEarlyOKTest",
143-
"unit._early_ok_test.TwoSmallRequestsZeroReadTwoEmptyResponsesEarlyOKTest",
144-
"unit._early_ok_test.TwoSmallRequestsZeroReadTwoLargeResponsesEarlyOKTest",
145-
"unit._early_ok_test.TwoSmallRequestsZeroReadTwoSmallResponsesEarlyOKTest",
146-
"unit._early_ok_test.TwoSmallRequestsZeroReadZeroEmptyResponsesEarlyOKTest",
147-
"unit._early_ok_test.TwoSmallRequestsZeroReadZeroLargeResponsesEarlyOKTest",
148-
"unit._early_ok_test.TwoSmallRequestsZeroReadZeroSmallResponsesEarlyOKTest",
149-
"unit._early_ok_test.ZeroEmptyRequestsTwoReadManyEmptyResponsesEarlyOKTest",
150-
"unit._early_ok_test.ZeroEmptyRequestsTwoReadManyLargeResponsesEarlyOKTest",
151-
"unit._early_ok_test.ZeroEmptyRequestsTwoReadManySmallResponsesEarlyOKTest",
152-
"unit._early_ok_test.ZeroEmptyRequestsTwoReadTwoEmptyResponsesEarlyOKTest",
153-
"unit._early_ok_test.ZeroEmptyRequestsTwoReadTwoLargeResponsesEarlyOKTest",
154-
"unit._early_ok_test.ZeroEmptyRequestsTwoReadTwoSmallResponsesEarlyOKTest",
155-
"unit._early_ok_test.ZeroEmptyRequestsTwoReadZeroEmptyResponsesEarlyOKTest",
156-
"unit._early_ok_test.ZeroEmptyRequestsTwoReadZeroLargeResponsesEarlyOKTest",
157-
"unit._early_ok_test.ZeroEmptyRequestsTwoReadZeroSmallResponsesEarlyOKTest",
158-
"unit._early_ok_test.ZeroEmptyRequestsZeroReadManyEmptyResponsesEarlyOKTest",
159-
"unit._early_ok_test.ZeroEmptyRequestsZeroReadManyLargeResponsesEarlyOKTest",
160-
"unit._early_ok_test.ZeroEmptyRequestsZeroReadManySmallResponsesEarlyOKTest",
161-
"unit._early_ok_test.ZeroEmptyRequestsZeroReadTwoEmptyResponsesEarlyOKTest",
162-
"unit._early_ok_test.ZeroEmptyRequestsZeroReadTwoLargeResponsesEarlyOKTest",
163-
"unit._early_ok_test.ZeroEmptyRequestsZeroReadTwoSmallResponsesEarlyOKTest",
164-
"unit._early_ok_test.ZeroEmptyRequestsZeroReadZeroEmptyResponsesEarlyOKTest",
165-
"unit._early_ok_test.ZeroEmptyRequestsZeroReadZeroLargeResponsesEarlyOKTest",
166-
"unit._early_ok_test.ZeroEmptyRequestsZeroReadZeroSmallResponsesEarlyOKTest",
167-
"unit._early_ok_test.ZeroLargeRequestsTwoReadManyEmptyResponsesEarlyOKTest",
168-
"unit._early_ok_test.ZeroLargeRequestsTwoReadManyLargeResponsesEarlyOKTest",
169-
"unit._early_ok_test.ZeroLargeRequestsTwoReadManySmallResponsesEarlyOKTest",
170-
"unit._early_ok_test.ZeroLargeRequestsTwoReadTwoEmptyResponsesEarlyOKTest",
171-
"unit._early_ok_test.ZeroLargeRequestsTwoReadTwoLargeResponsesEarlyOKTest",
172-
"unit._early_ok_test.ZeroLargeRequestsTwoReadTwoSmallResponsesEarlyOKTest",
173-
"unit._early_ok_test.ZeroLargeRequestsTwoReadZeroEmptyResponsesEarlyOKTest",
174-
"unit._early_ok_test.ZeroLargeRequestsTwoReadZeroLargeResponsesEarlyOKTest",
175-
"unit._early_ok_test.ZeroLargeRequestsTwoReadZeroSmallResponsesEarlyOKTest",
176-
"unit._early_ok_test.ZeroLargeRequestsZeroReadManyEmptyResponsesEarlyOKTest",
177-
"unit._early_ok_test.ZeroLargeRequestsZeroReadManyLargeResponsesEarlyOKTest",
178-
"unit._early_ok_test.ZeroLargeRequestsZeroReadManySmallResponsesEarlyOKTest",
179-
"unit._early_ok_test.ZeroLargeRequestsZeroReadTwoEmptyResponsesEarlyOKTest",
180-
"unit._early_ok_test.ZeroLargeRequestsZeroReadTwoLargeResponsesEarlyOKTest",
181-
"unit._early_ok_test.ZeroLargeRequestsZeroReadTwoSmallResponsesEarlyOKTest",
182-
"unit._early_ok_test.ZeroLargeRequestsZeroReadZeroEmptyResponsesEarlyOKTest",
183-
"unit._early_ok_test.ZeroLargeRequestsZeroReadZeroLargeResponsesEarlyOKTest",
184-
"unit._early_ok_test.ZeroLargeRequestsZeroReadZeroSmallResponsesEarlyOKTest",
185-
"unit._early_ok_test.ZeroSmallRequestsTwoReadManyEmptyResponsesEarlyOKTest",
186-
"unit._early_ok_test.ZeroSmallRequestsTwoReadManyLargeResponsesEarlyOKTest",
187-
"unit._early_ok_test.ZeroSmallRequestsTwoReadManySmallResponsesEarlyOKTest",
188-
"unit._early_ok_test.ZeroSmallRequestsTwoReadTwoEmptyResponsesEarlyOKTest",
189-
"unit._early_ok_test.ZeroSmallRequestsTwoReadTwoLargeResponsesEarlyOKTest",
190-
"unit._early_ok_test.ZeroSmallRequestsTwoReadTwoSmallResponsesEarlyOKTest",
191-
"unit._early_ok_test.ZeroSmallRequestsTwoReadZeroEmptyResponsesEarlyOKTest",
192-
"unit._early_ok_test.ZeroSmallRequestsTwoReadZeroLargeResponsesEarlyOKTest",
193-
"unit._early_ok_test.ZeroSmallRequestsTwoReadZeroSmallResponsesEarlyOKTest",
194-
"unit._early_ok_test.ZeroSmallRequestsZeroReadManyEmptyResponsesEarlyOKTest",
195-
"unit._early_ok_test.ZeroSmallRequestsZeroReadManyLargeResponsesEarlyOKTest",
196-
"unit._early_ok_test.ZeroSmallRequestsZeroReadManySmallResponsesEarlyOKTest",
197-
"unit._early_ok_test.ZeroSmallRequestsZeroReadTwoEmptyResponsesEarlyOKTest",
198-
"unit._early_ok_test.ZeroSmallRequestsZeroReadTwoLargeResponsesEarlyOKTest",
199-
"unit._early_ok_test.ZeroSmallRequestsZeroReadTwoSmallResponsesEarlyOKTest",
200-
"unit._early_ok_test.ZeroSmallRequestsZeroReadZeroEmptyResponsesEarlyOKTest",
201-
"unit._early_ok_test.ZeroSmallRequestsZeroReadZeroLargeResponsesEarlyOKTest",
202-
"unit._early_ok_test.ZeroSmallRequestsZeroReadZeroSmallResponsesEarlyOKTest",
20341
"unit._empty_message_test.EmptyMessageTest",
20442
"unit._exit_test.ExitTest",
20543
"unit._interceptor_test.InterceptorTest",

src/python/grpcio_tests/tests/unit/_compression_test.py

+4-2
Original file line numberDiff line numberDiff line change
@@ -32,10 +32,12 @@ def handle_unary(request, servicer_context):
3232

3333

3434
def handle_stream(request_iterator, servicer_context):
35+
# TODO(issue:#6891) We should be able to remove this loop,
36+
# and replace with return; yield
3537
servicer_context.send_initial_metadata([('grpc-internal-encoding-request',
3638
'gzip')])
37-
return
38-
yield
39+
for request in request_iterator:
40+
yield request
3941

4042

4143
class _MethodHandler(grpc.RpcMethodHandler):

src/python/grpcio_tests/tests/unit/_early_ok_test.py

-206
This file was deleted.

0 commit comments

Comments
 (0)