more sha1 cleanup

Author: williamstein

src/packages/frontend/client/nats.ts

@@ -7,7 +7,7 @@ import { redux } from "../app-framework";
 import * as jetstream from "@nats-io/jetstream";
 import { createSyncTable, type SyncTable } from "@cocalc/nats/sync/synctable";
 import { parse_query } from "@cocalc/sync/table/util";
-import sha1 from "sha1";
+import { sha1 } from "@cocalc/util/misc";
 import { keys } from "lodash";
 import { type HubApi, initHubApi } from "@cocalc/nats/api/index";
 

src/packages/frontend/frame-editors/terminal-editor/nats-terminal-connection.ts

@@ -1,9 +1,8 @@
 import { webapp_client } from "@cocalc/frontend/webapp-client";
 import { EventEmitter } from "events";
 import { JSONCodec } from "nats.ws";
-import sha1 from "sha1";
 import { reuseInFlight } from "@cocalc/util/reuse-in-flight";
-import { uuid } from "@cocalc/util/misc";
+import { sha1, uuid } from "@cocalc/util/misc";
 import { delay } from "awaiting";
 
 const jc = JSONCodec();

src/packages/nats/README.md

@@ -0,0 +1,4 @@
+### NOTES
+
+- we are using sha1 hashes a lot because we have to store various data, e.g., arbitrary file paths, as nats segments, so MUST have a bounded size string with simple characters.
+  The very low probability of a collision is discussed here: https://crypto.stackexchange.com/questions/2583/is-it-fair-to-assume-that-sha1-collisions-wont-occur-on-a-set-of-100k-strings

src/packages/nats/sync/synctable-kv-atomic.ts

@@ -1,7 +1,7 @@
-import sha1 from "sha1";
 import { keys } from "lodash";
 import { client_db } from "@cocalc/util/db-schema/client-db";
 import { getKv, toKey, type NatsEnv, natsKeyPrefix } from "./synctable-kv";
+import { sha1 } from "@cocalc/util/misc";
 
 export class SyncTableKVAtomic {
   private kv?;

src/packages/nats/sync/synctable-kv.ts

@@ -9,7 +9,7 @@ It uses a SINGLE NATS key-value store to represent
 */
 
 import { Kvm } from "@nats-io/kv";
-import sha1 from "sha1";
+import { sha1 } from "@cocalc/util/misc";
 import jsonStableStringify from "json-stable-stringify";
 import { keys } from "lodash";
 import { client_db } from "@cocalc/util/db-schema/client-db";

src/packages/nats/sync/synctable-stream.ts

@@ -10,10 +10,9 @@ It uses a NATS stream to store the elements in a well defined order.
 */
 
 import { jetstreamManager, jetstream } from "@nats-io/jetstream";
-import sha1 from "sha1";
 import jsonStableStringify from "json-stable-stringify";
 import { keys } from "lodash";
-import { cmp_Date, is_array, isValidUUID } from "@cocalc/util/misc";
+import { cmp_Date, is_array, isValidUUID, sha1 } from "@cocalc/util/misc";
 import { client_db } from "@cocalc/util/db-schema/client-db";
 import { EventEmitter } from "events";
 

src/packages/project/nats/synctable.ts

@@ -24,7 +24,11 @@ const synctable = reuseInFlight(
         }
       }
       query[table][0].project_id = project_id;
-      const s = createSyncTable({ ...options, query, env: { sha1, jc, nc } });
+      const s = createSyncTable({
+        ...options,
+        query,
+        env: { sha1, jc, nc },
+      });
       await s.init();
       cache[key] = s;
     }