fix some suggested details

Author: fchapoton

src/sage/combinat/designs/orthogonal_arrays_find_recursive.pyx

@@ -145,7 +145,7 @@ cpdef find_product_decomposition(int k,int n):
         sage: _ = f(*args)
     """
     cdef int n1,n2
-    for n1 in range(2,n):
+    for n1 in range(2, n):
         n2 = n/n1  # n2 is decreasing along the loop
         if n2 < n1:
             break
@@ -296,7 +296,7 @@ cpdef find_construction_3_3(int k,int n):
         if not(is_available(k, mm) and is_available(k, mm + 1)):
             continue
 
-        for nn in range(2,n//mm+1):
+        for nn in range(2, n//mm+1):
             i = n-nn*mm
             if i <= 0:
                 continue
@@ -335,7 +335,7 @@ cpdef find_construction_3_4(int k, int n):
             not is_available(k,mm+2)):
             continue
 
-        for nn in range(2,n/mm+1):
+        for nn in range(2, n//mm+1):
             i = n-nn*mm
             if i<=0:
                 continue
@@ -372,14 +372,14 @@ cpdef find_construction_3_5(int k, int n):
         sage: find_construction_3_5(9,24)
     """
     cdef int mm,i,nn,r,s,t
-    for mm in range(2,n/2+1):
+    for mm in range(2, n//2+1):
         if (mm+3 >= n or
             not is_available(k,mm+1) or
             not is_available(k,mm+2) or
             not is_available(k,mm+3)):
             continue
 
-        for nn in range(2,n/mm+1):
+        for nn in range(2, n//mm+1):
             i = n-nn*mm
             if i<=0:
                 continue
@@ -429,7 +429,7 @@ cpdef find_construction_3_6(int k,int n):
             not is_available(k,mm+2)):
             continue
 
-        for nn in range(2,n/mm+1):
+        for nn in range(2, n//mm+1):
             i = n-nn*mm
             if i<=0:
                 continue
@@ -909,7 +909,7 @@ cpdef find_brouwer_van_rees_with_one_truncated_column(int k,int n):
     cdef tuple values
 
     # We write n=rm+remainder
-    for m in range(2,n//2):
+    for m in range(2, n//2):
         if not is_available(k,m):
             continue
 
@@ -931,7 +931,7 @@ cpdef find_brouwer_van_rees_with_one_truncated_column(int k,int n):
             continue
 
         max_multiplier = max(available_multipliers)
-        for r in range(2,n//m+1):
+        for r in range(2, n//m+1):
             remainder = n-r*m
             if (remainder > r*max_multiplier or
                 not is_available(k+1,r) or

src/sage/libs/giac/giac.pyx

@@ -887,15 +887,15 @@ cdef class Pygen(GiacMethods_base):
             return result
         else:
             sig_on()
-            result = str(self.type)+"\nResult is too big for Display. If you really want to see it use print"
+            result = str(self.type) + "\nResult is too big for Display. If you really want to see it use print"
             sig_off()
             return result
 
     def __str__(self):
         #if self.gptr == NULL:
         #  return ''
         sig_on()
-        result=decstring23(GIAC_print(self.gptr[0], context_ptr).c_str()) #python3
+        result = decstring23(GIAC_print(self.gptr[0], context_ptr).c_str())
         sig_off()
         return result
 
@@ -960,15 +960,15 @@ cdef class Pygen(GiacMethods_base):
                     if(i<0):
                         i=i+n
                     sig_on()
-                    result=self.gptr[0][<int>i]
+                    result = self.gptr[0][<int>i]
                     sig_off()
                     return _wrap_gen(result)
                 else:
                     raise IndexError('list index %s out of range'%(i))
             else:
                 if isinstance(i,slice):
                     sig_on()
-                    result=gen(_getgiacslice(self,i),<short int>self._subtype)
+                    result = gen(_getgiacslice(self,i),<short int>self._subtype)
                     sig_off()
                     return _wrap_gen(result)
                 # add support for multi indexes
@@ -1065,7 +1065,7 @@ cdef class Pygen(GiacMethods_base):
     def eval(self):
         cdef gen result
         sig_on()
-        result=GIAC_protecteval(self.gptr[0],giacsettings.eval_level,context_ptr)
+        result = GIAC_protecteval(self.gptr[0],giacsettings.eval_level,context_ptr)
         sig_off()
         return _wrap_gen(result)
 
@@ -1078,7 +1078,7 @@ cdef class Pygen(GiacMethods_base):
         if not isinstance(self, Pygen):
             self=Pygen(self)
         sig_on()
-        result= (<Pygen>self).gptr[0] + (<Pygen>right).gptr[0]
+        result = (<Pygen>self).gptr[0] + (<Pygen>right).gptr[0]
         sig_off()
         return _wrap_gen(result)
 
@@ -1128,7 +1128,7 @@ cdef class Pygen(GiacMethods_base):
         if not isinstance(self, Pygen):
             self=Pygen(self)
         sig_on()
-        result= (<Pygen>self).gptr[0] - (<Pygen>right).gptr[0]
+        result = (<Pygen>self).gptr[0] - (<Pygen>right).gptr[0]
         sig_off()
         return _wrap_gen(result)
 
@@ -1147,7 +1147,7 @@ cdef class Pygen(GiacMethods_base):
             right = Pygen(right)
         if not isinstance(self, Pygen):
             self = Pygen(self)
-        #result= (<Pygen>self).gptr[0] * (<Pygen>right).gptr[0]
+        #result = (<Pygen>self).gptr[0] * (<Pygen>right).gptr[0]
         #NB: with the natural previous method, the following error generated by
         #giac causes python to quit instead of an error message.
         #l=Pygen([1,2]);l.transpose()*l;
@@ -1184,7 +1184,7 @@ cdef class Pygen(GiacMethods_base):
         if not isinstance(self, Pygen):
             self = Pygen(self)
         sig_on()
-        result= (<Pygen>self).gptr[0] / (<Pygen>right).gptr[0]
+        result = (<Pygen>self).gptr[0] / (<Pygen>right).gptr[0]
         sig_off()
         return _wrap_gen(result)
 
@@ -1195,7 +1195,7 @@ cdef class Pygen(GiacMethods_base):
         if not isinstance(self, Pygen):
             self = Pygen(self)
         sig_on()
-        result= GIAC_pow((<Pygen>self).gptr[0], (<Pygen>right).gptr[0], context_ptr )
+        result = GIAC_pow((<Pygen>self).gptr[0], (<Pygen>right).gptr[0], context_ptr )
         sig_off()
         return _wrap_gen(result)
 
@@ -1205,12 +1205,12 @@ cdef class Pygen(GiacMethods_base):
             right = Pygen(right)
         if not isinstance(self, Pygen):
             self = Pygen(self)
-        #result= gen(GIAC_makenewvecteur((<Pygen>self).gptr[0],(<Pygen>right).gptr[0]),<short int>1)
+        #result = gen(GIAC_makenewvecteur((<Pygen>self).gptr[0],(<Pygen>right).gptr[0]),<short int>1)
         #to have an integer output:
-        #result= GIAC_smod(result,context_ptr)
+        #result = GIAC_smod(result,context_ptr)
         #we give a modular output:
         sig_on()
-        result= GIAC_giacmod((<Pygen>self).gptr[0], (<Pygen>right).gptr[0],context_ptr)
+        result = GIAC_giacmod((<Pygen>self).gptr[0], (<Pygen>right).gptr[0],context_ptr)
         sig_off()
         return _wrap_gen(result)
 
@@ -1338,7 +1338,7 @@ cdef class Pygen(GiacMethods_base):
             \frac{...x^{4}...-...y...}{...y^{2}-3...x...}
         """
         sig_on()
-        result=decstring23(GIAC_gen2tex(self.gptr[0], context_ptr).c_str()) #python3
+        result = decstring23(GIAC_gen2tex(self.gptr[0], context_ptr).c_str())
         sig_off()
         return result
 
@@ -1547,7 +1547,7 @@ cdef class Pygen(GiacMethods_base):
                 raise NotImplementedError("Unable to parse Giac output: %s" % self.__repr__())
         else:
             try:
-                result=R(self.__str__())
+                result = R(self.__str__())
                 return result
 
             except Exception:
@@ -1668,7 +1668,7 @@ cdef class Pygen(GiacMethods_base):
         if not isinstance(self, Pygen):
             self = Pygen(self)
         sig_on()
-        result= giacgenrichcmp((<Pygen>self).gptr[0],(<Pygen>other).gptr[0], op, context_ptr )
+        result = giacgenrichcmp((<Pygen>self).gptr[0],(<Pygen>other).gptr[0], op, context_ptr )
         sig_off()
         return result == 1
 
@@ -1686,7 +1686,7 @@ cdef class Pygen(GiacMethods_base):
     property _subtype:
         def __get__(self):
             sig_on()
-            result=self.gptr.subtype
+            result = self.gptr.subtype
             sig_off()
             return result
 
@@ -1862,7 +1862,7 @@ cdef  gen pylongtogen(a) except +:
 #def giaceval(Pygen self):
 #    cdef gen result
 #    try:
-#      result=GIAC_protecteval(self.gptr[0],1,context_ptr)
+#      result = GIAC_protecteval(self.gptr[0],1,context_ptr)
 #      return _wrap_gen(result)
 #    except:
 #      raise
@@ -1872,7 +1872,7 @@ cdef  gen pylongtogen(a) except +:
 #
 #    cdef gen result
 #    try:
-#      result=GIAC_factor(self.gptr[0],context_ptr)
+#      result = GIAC_factor(self.gptr[0],context_ptr)
 #      return _wrap_gen(result)
 #    except:
 #      raise
@@ -1882,7 +1882,7 @@ cdef  gen pylongtogen(a) except +:
 #def giacfactors(Pygen self):
 #    cdef gen result
 #    try:
-#      result=GIAC_factors(self.gptr[0],context_ptr)
+#      result = GIAC_factors(self.gptr[0],context_ptr)
 #      return _wrap_gen(result)
 #    except:
 #      raise
@@ -1893,7 +1893,7 @@ cdef  gen pylongtogen(a) except +:
 #def giacnormal(Pygen self):
 #    cdef gen result
 #    try:
-#      result=GIAC_normal(self.gptr[0],context_ptr)
+#      result = GIAC_normal(self.gptr[0],context_ptr)
 #      return _wrap_gen(result)
 #    except:
 #      raise
@@ -1902,8 +1902,8 @@ cdef  gen pylongtogen(a) except +:
 #def giacgcd(Pygen a, Pygen b):
 #    cdef gen result
 #    try:
-#      result=gen( GIAC_makenewvecteur(a.gptr[0],b.gptr[0]) ,<short int>1)
-#      result=GIAC_gcd(result,context_ptr)
+#      result = gen( GIAC_makenewvecteur(a.gptr[0],b.gptr[0]) ,<short int>1)
+#      result = GIAC_gcd(result,context_ptr)
 #      return _wrap_gen(result)
 #    except:
 #      raise
@@ -1983,7 +1983,7 @@ for i in moremethods:
     GiacMethods[i] = tmp
 
 for i in mostkeywords+moremethods:
-    GiacMethods[i].__doc__ = eval("Pygen."+i+".__doc__")
+    GiacMethods[i].__doc__ = eval("Pygen." + i + ".__doc__")
 
 # To avoid conflicts we export only these few ones.  Most giac keywords will be
 # available through: libgiac.keywordname
@@ -2016,7 +2016,7 @@ def loadgiacgen(str filename):
     """
     cdef gen result
     sig_on()
-    result=GIAC_unarchive( <string>encstring23(filename), context_ptr)
+    result = GIAC_unarchive( <string>encstring23(filename), context_ptr)
     sig_off()
     return _wrap_gen(result)
 

src/sage/matrix/matrix_dense.pyx

@@ -171,7 +171,7 @@ cdef class Matrix_dense(matrix.Matrix):
             [4|1]
             [3|0]
         """
-        nc, nr = (self.ncols(), self.nrows())
+        nc, nr = self.ncols(), self.nrows()
         cdef Matrix_dense atrans
         atrans = self.new_matrix(nrows=nc, ncols=nr,
                                  copy=False, coerce=False)
@@ -256,7 +256,7 @@ cdef class Matrix_dense(matrix.Matrix):
         prod = self.new_matrix(nr, nc, copy=False, coerce=False)
         for r in range(nr):
             for c in range(nc):
-                entry = self.get_unsafe(r,c)*other.get_unsafe(r,c)
+                entry = self.get_unsafe(r, c)*other.get_unsafe(r,c)
                 prod.set_unsafe(r,c,entry)
         return prod
 

src/sage/matrix/matrix_integer_dense.pyx

@@ -5697,12 +5697,12 @@ cdef class Matrix_integer_dense(Matrix_dense):
             [4|1]
             [3|0]
         """
-        nr, nc = (self._nrows, self._ncols)
+        nr, nc = self._nrows, self._ncols
 
         cdef Matrix_integer_dense A
         A = self._new(nc,nr)
         cdef Py_ssize_t i, j
-        cdef Py_ssize_t ri, rj # reversed i and j
+        cdef Py_ssize_t ri, rj  # reversed i and j
         sig_on()
         ri = nr
         for i from 0 <= i < nr: