Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subscribe #16

Open
nakul91 opened this issue Sep 28, 2017 · 14 comments
Open

Subscribe #16

nakul91 opened this issue Sep 28, 2017 · 14 comments

Comments

@nakul91
Copy link

nakul91 commented Sep 28, 2017

Need to pass the arguments to subscribe as an issue of security.

@sacOO7
Copy link
Owner

sacOO7 commented Sep 28, 2017

Can you describe your problem in detail?

@joysonvd
Copy link

joysonvd commented Oct 23, 2017

Hey Sachin,

In the javascript client I can do the following when subscribing to a channel.
channel = socket.subscribe(${userid}, {
data : {userid : ${userid}, token : 'eyJhbGciOiJSUzI1NiIsInR5cCI6Ikp'}
});

So we want to know if a similar thing can be done in the Android client as well. We use the user id and token to authenticate the subscribe request.

Regards,
Joyson.

@nakul91
Copy link
Author

nakul91 commented Jan 24, 2018

any update on the above issue.

@sacOO7
Copy link
Owner

sacOO7 commented Jan 24, 2018

Hi @nakul91 can you describe your problem in more detail?

@nakul91
Copy link
Author

nakul91 commented Jan 25, 2018

Hi @sacOO7 right now we cannot authenticate the subscribe functionality as its just a call back function as follow:
socket.createChannel(" XX ").subscribe(new Ack() {
@OverRide
public void call(String name, Object error, Object data) {

        }
    });

in the backend, they have updated the authentication with the token as specified by @joysonvd in the above posts. So how can we update the token while subscribing, in android?

@kuhnp
Copy link

kuhnp commented Mar 16, 2018

I have the same problem, I need to add a jwt token in the data payload. But unfortunately, this is not exposed by the subscribe method. Any update?

@nakul91
Copy link
Author

nakul91 commented Apr 5, 2018

@sacOO7 this issue got fixed in ios but not in the android can you pls fix this up.

@nakul91
Copy link
Author

nakul91 commented Apr 5, 2018

@sacOO7
Copy link
Owner

sacOO7 commented Apr 5, 2018

Yes sure @nakul91 , I will take a look at it....

@nakul91
Copy link
Author

nakul91 commented Apr 5, 2018

@sacOO7 thanks 👍

@joysonvd
Copy link

joysonvd commented Jun 1, 2018

Hi @sacOO7, Have you been able to get through to this.

@sacOO7
Copy link
Owner

sacOO7 commented Jun 1, 2018 via email

@nakul91
Copy link
Author

nakul91 commented Jul 26, 2018

Hi @sacOO7 any update on this issue

@sacOO7
Copy link
Owner

sacOO7 commented Jul 26, 2018

Hi @nakul91 , I am currently porting all functionality from js client to java. You can find updated here. Since I am working on Unity client, this will take some time to complete. https://github.com/sacOO7/socketcluster-client-java/tree/feature/syncJsClient.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants