Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase limit of comparison stars a user may select #1337

Open
ivenzor opened this issue Oct 23, 2024 · 4 comments
Open

Increase limit of comparison stars a user may select #1337

ivenzor opened this issue Oct 23, 2024 · 4 comments
Assignees

Comments

@ivenzor
Copy link
Contributor

ivenzor commented Oct 23, 2024

There is a hardcoded limit of 10 comparison stars that a user may select. If there are more than 10, the user must re-enter the comparison stars. We could change the limit to 20. If a user takes the time to manually choose 10 or more comparison stars, the additional runtime likely wouldn’t be a significant issue.
See this conversation on Slack: https://uol-ets.slack.com/archives/CJJRP4QKV/p1729586384135459

The current limit is hardcoded in inputs.py within the comparison_star_coords function:

def comparison_star_coords(comp_stars, rt_bool):
    if isinstance(comp_stars, list) and 1 <= len(comp_stars) <= 10 and \
            all(isinstance(star, list) for star in comp_stars):
    ...
    else:
        comp_stars = []

    if not comp_stars:
        while True:
            if not rt_bool:
                num_comp_stars = user_input("\nHow many Comparison Stars would you like to use? (1-10): ", type_=int)
                ...

@ivenzor
Copy link
Contributor Author

ivenzor commented Oct 23, 2024

I'm working on a PR.

@tamimfatahi
Copy link
Collaborator

Let's hold off on increasing the limit. I recommend we keep it at 10 since too many comparison stars can increase the runtime exponentially. Maybe we ignore the limit when adding AAVSO comp star.

@tamimfatahi
Copy link
Collaborator

Once Issue #1316 is merged into develop, please implement the suggestion above. I don't want you working on a solution when the code is being changed.

@tamimfatahi
Copy link
Collaborator

@ivenzor You can begin working on this issue if you'd like. Please use the inputs.py file in PR #1337 as reference.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants