Do not forcibly regenerate the session when session data changes

rvm-peercode · rvm-peercode · commit 965ba680dd88 · 2023-10-04T09:05:57.000+02:00
This is the responsibility of upper layers. Closes: mezzio#43 Signed-off-by: Roel van Meer <roel.van.meer@peercode.nl>
diff --git a/src/CacheSessionPersistence.php b/src/CacheSessionPersistence.php
@@ -139,8 +139,7 @@ public function persistSession(SessionInterface $session, ResponseInterface $res
         // Regenerate the session if:
         // - we have no session identifier
         // - the session is marked as regenerated
-        // - the session has changed (data is different)
-        if ('' === $id || $session->isRegenerated() || $session->hasChanged()) {
+        if ('' === $id || $session->isRegenerated()) {
             $id = $this->regenerateSession($id);
         }
 

Original file line number	Diff line number	Diff line change
`@@ -139,8 +139,7 @@ public function persistSession(SessionInterface $session, ResponseInterface $res`
`139`	`139`	`// Regenerate the session if:`
`140`	`140`	`// - we have no session identifier`
`141`	`141`	`// - the session is marked as regenerated`
`142`		`- // - the session has changed (data is different)`
`143`		`- if ('' === $id \|\| $session->isRegenerated() \|\| $session->hasChanged()) {`
	`142`	`+ if ('' === $id \|\| $session->isRegenerated()) {`
`144`	`143`	`$id = $this->regenerateSession($id);`
`145`	`144`	`}`
`146`	`145`