Skip to content

Commit faed391

Browse files
authored
Merge pull request #193 from SoryRawyer/remove-quicli-result
Remove result prefix and std import, now that quicli is no longer a d…
2 parents d71a7e4 + 072bbc6 commit faed391

File tree

1 file changed

+12
-19
lines changed

1 file changed

+12
-19
lines changed

src/command/init.rs

Lines changed: 12 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -8,14 +8,11 @@ use manifest;
88
use progressbar::Step;
99
use readme;
1010
use slog::Logger;
11+
use std::fs;
1112
use std::time::Instant;
12-
use std::{fs, result};
1313
use PBAR;
1414

15-
// quicli::prelude::* imports a different result struct which gets
16-
// precedence over the std::result::Result, so have had to specify
17-
// the correct type here.
18-
pub fn create_pkg_dir(path: &str, step: &Step) -> result::Result<(), Error> {
15+
pub fn create_pkg_dir(path: &str, step: &Step) -> Result<(), Error> {
1916
let msg = format!("{}Creating a pkg directory...", emoji::FOLDER);
2017
PBAR.step(step, &msg);
2118
let pkg_dir_path = format!("{}/pkg", path);
@@ -38,7 +35,7 @@ pub struct Init {
3835
crate_name: String,
3936
}
4037

41-
type InitStep = fn(&mut Init, &Step, &Logger) -> result::Result<(), Error>;
38+
type InitStep = fn(&mut Init, &Step, &Logger) -> Result<(), Error>;
4239

4340
impl Init {
4441
pub fn new(
@@ -95,7 +92,7 @@ impl Init {
9592
}
9693
}
9794

98-
pub fn process(&mut self, log: &Logger, mode: InitMode) -> result::Result<(), Error> {
95+
pub fn process(&mut self, log: &Logger, mode: InitMode) -> Result<(), Error> {
9996
let process_steps = Init::get_process_steps(mode);
10097

10198
let mut step_counter = Step::new(process_steps.len());
@@ -124,21 +121,21 @@ impl Init {
124121
Ok(())
125122
}
126123

127-
fn step_check_crate_config(&mut self, step: &Step, log: &Logger) -> result::Result<(), Error> {
124+
fn step_check_crate_config(&mut self, step: &Step, log: &Logger) -> Result<(), Error> {
128125
info!(&log, "Checking crate configuration...");
129126
manifest::check_crate_config(&self.crate_path, step)?;
130127
info!(&log, "Crate is correctly configured.");
131128
Ok(())
132129
}
133130

134-
fn step_add_wasm_target(&mut self, step: &Step, log: &Logger) -> result::Result<(), Error> {
131+
fn step_add_wasm_target(&mut self, step: &Step, log: &Logger) -> Result<(), Error> {
135132
info!(&log, "Adding wasm-target...");
136133
build::rustup_add_wasm_target(step)?;
137134
info!(&log, "Adding wasm-target was successful.");
138135
Ok(())
139136
}
140137

141-
fn step_build_wasm(&mut self, step: &Step, log: &Logger) -> result::Result<(), Error> {
138+
fn step_build_wasm(&mut self, step: &Step, log: &Logger) -> Result<(), Error> {
142139
info!(&log, "Building wasm...");
143140
build::cargo_build_wasm(&self.crate_path, self.debug, step)?;
144141

@@ -155,14 +152,14 @@ impl Init {
155152
Ok(())
156153
}
157154

158-
fn step_create_dir(&mut self, step: &Step, log: &Logger) -> result::Result<(), Error> {
155+
fn step_create_dir(&mut self, step: &Step, log: &Logger) -> Result<(), Error> {
159156
info!(&log, "Creating a pkg directory...");
160157
create_pkg_dir(&self.crate_path, step)?;
161158
info!(&log, "Created a pkg directory at {}.", &self.crate_path);
162159
Ok(())
163160
}
164161

165-
fn step_create_json(&mut self, step: &Step, log: &Logger) -> result::Result<(), Error> {
162+
fn step_create_json(&mut self, step: &Step, log: &Logger) -> Result<(), Error> {
166163
info!(&log, "Writing a package.json...");
167164
manifest::write_package_json(&self.crate_path, &self.scope, self.disable_dts, step)?;
168165
#[cfg(not(target_os = "windows"))]
@@ -178,7 +175,7 @@ impl Init {
178175
Ok(())
179176
}
180177

181-
fn step_copy_readme(&mut self, step: &Step, log: &Logger) -> result::Result<(), Error> {
178+
fn step_copy_readme(&mut self, step: &Step, log: &Logger) -> Result<(), Error> {
182179
info!(&log, "Copying readme from crate...");
183180
readme::copy_from_crate(&self.crate_path, step)?;
184181
#[cfg(not(target_os = "windows"))]
@@ -194,11 +191,7 @@ impl Init {
194191
Ok(())
195192
}
196193

197-
fn step_install_wasm_bindgen(
198-
&mut self,
199-
step: &Step,
200-
log: &Logger,
201-
) -> result::Result<(), Error> {
194+
fn step_install_wasm_bindgen(&mut self, step: &Step, log: &Logger) -> Result<(), Error> {
202195
info!(&log, "Installing wasm-bindgen-cli...");
203196
bindgen::cargo_install_wasm_bindgen(step)?;
204197
info!(&log, "Installing wasm-bindgen-cli was successful.");
@@ -222,7 +215,7 @@ impl Init {
222215
Ok(())
223216
}
224217

225-
fn step_run_wasm_bindgen(&mut self, step: &Step, log: &Logger) -> result::Result<(), Error> {
218+
fn step_run_wasm_bindgen(&mut self, step: &Step, log: &Logger) -> Result<(), Error> {
226219
info!(&log, "Building the wasm bindings...");
227220
bindgen::wasm_bindgen_build(
228221
&self.crate_path,

0 commit comments

Comments
 (0)