feat(build): add rustc check

Author: ashleygwilliams

Cargo.lock

@@ -19,6 +19,7 @@ indicatif = "0.9.0"
 lazy_static = "1.1.0"
 openssl = { version = '0.10.11', optional = true }
 parking_lot = "0.6"
+rustc_version = "0.2.3"
 serde = "1.0.74"
 serde_derive = "1.0.74"
 serde_json = "1.0.26"

Cargo.toml

@@ -3,10 +3,26 @@
 use emoji;
 use error::Error;
 use progressbar::Step;
+use rustc_version::{version, Version};
 use std::path::Path;
 use std::process::Command;
 use PBAR;
 
+/// Ensure that `rustc` is present and that it is >= 1.30.0
+pub fn check_rustc_version(step: &Step) -> Result<String, Error> {
+    let msg = format!("{}Checking `rustc` version...", emoji::TARGET);
+    PBAR.step(step, &msg);
+    let local_version = version()?;
+    let minimum_version = Version::parse("1.30.0").unwrap();
+    if local_version < minimum_version {
+        return Err(Error::RustcVersion {
+          message: format!("Your version of Rust, '{}', is not supported.", local_version.to_string()),
+          local_version: local_version.to_string(),
+        });
+    }
+    Ok(local_version.to_string())
+}
+
 /// Ensure that `rustup` has the `wasm32-unknown-unknown` target installed for
 /// the `nightly` toolchain.
 pub fn rustup_add_wasm_target(step: &Step) -> Result<(), Error> {

src/build.rs

@@ -155,6 +155,7 @@ impl Build {
         }
         match &mode {
             BuildMode::Normal => steps![
+                step_check_rustc_version,
                 step_check_crate_config,
                 step_add_wasm_target,
                 step_build_wasm,
@@ -165,6 +166,7 @@ impl Build {
                 step_run_wasm_bindgen,
             ],
             BuildMode::Noinstall => steps![
+                step_check_rustc_version,
                 step_check_crate_config,
                 step_build_wasm,
                 step_create_dir,
@@ -175,6 +177,14 @@ impl Build {
         }
     }
 
+    fn step_check_rustc_version(&mut self, step: &Step, log: &Logger) -> Result<(), Error> {
+        info!(&log, "Checking rustc version...");
+        let version = build::check_rustc_version(step)?;
+        let msg = format!("rustc version is {}.", version);
+        info!(&log, "{}", &msg);
+        Ok(())
+    }
+
     fn step_check_crate_config(&mut self, step: &Step, log: &Logger) -> Result<(), Error> {
         info!(&log, "Checking crate configuration...");
         manifest::check_crate_config(&self.crate_path, step)?;

src/command/build.rs

@@ -1,5 +1,6 @@
 //! Code related to error handling for wasm-pack
 use curl;
+use rustc_version;
 use serde_json;
 use std::borrow::Cow;
 use std::io;
@@ -29,6 +30,19 @@ pub enum Error {
     /// An error handling zip archives.
     Zip(#[cause] zip::result::ZipError),
 
+    #[fail(display = "{}", _0)]
+    /// An error in parsing your rustc version.
+    Rustc(#[cause] rustc_version::Error),
+
+    #[fail(display = "{}", _0)]
+    /// An error from having an unsupported rustc version.
+    RustcVersion {
+      /// Error message
+      message: String,
+      /// The version of the local rust
+      local_version: String,
+    },
+
     /// An error invoking another CLI tool.
     #[fail(display = "{}. stderr:\n\n{}", message, stderr)]
     Cli {
@@ -112,13 +126,26 @@ impl Error {
         }
     }
 
+    /// Construct a rustc version error.
+    pub fn rustc_version_error(message: &str, local_version: &str) -> Self {
+        Error::RustcVersion {
+            message: message.to_string(),
+            local_version: local_version.to_string(),
+        }
+    }
+
     /// Get a string description of this error's type.
     pub fn error_type(&self) -> String {
         match self {
             Error::Io(_) => "There was an I/O error. Details:\n\n",
             Error::SerdeJson(_) => "There was an JSON error. Details:\n\n",
             Error::SerdeToml(_) => "There was an TOML error. Details:\n\n",
             Error::Zip(_) => "There was an error handling zip files. Details:\n\n",
+            Error::Rustc(_) => "Your rustc version isn't parsable- which means you might not have Rust installed. Please install Rust version 1.30.0.",
+            Error::RustcVersion {
+              message: _,
+              local_version: _,
+            } => "Your rustc version is not supported. Please install version 1.30.0 or higher.",
             Error::Cli {
                 message: _,
                 stderr: _,
@@ -161,6 +188,12 @@ impl From<zip::result::ZipError> for Error {
     }
 }
 
+impl From<rustc_version::Error> for Error {
+    fn from(e: rustc_version::Error) -> Self {
+        Error::Rustc(e)
+    }
+}
+
 impl From<toml::de::Error> for Error {
     fn from(e: toml::de::Error) -> Self {
         Error::SerdeToml(e)

src/error.rs

@@ -11,6 +11,7 @@ extern crate indicatif;
 #[macro_use]
 extern crate lazy_static;
 extern crate parking_lot;
+extern crate rustc_version;
 #[macro_use]
 extern crate serde_derive;
 extern crate serde_json;