Skip to content

Remove our custom thread local stuff in the anyref module #1523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
fitzgen opened this issue May 10, 2019 · 0 comments · Fixed by #1531
Closed

Remove our custom thread local stuff in the anyref module #1523

fitzgen opened this issue May 10, 2019 · 0 comments · Fixed by #1531
Labels
question

Comments

@fitzgen
Copy link
Member

fitzgen commented May 10, 2019

When rust-lang/rust#55518 is in the stable channel (is that now? what is the easiest way to check?), we should remove our custom thread local crap in the anyref module.

https://github.com/rustwasm/wasm-bindgen/blob/3348ece/src/anyref.rs#L124-L139

cc @alexcrichton
alexcrichton added a commit to alexcrichton/wasm-bindgen that referenced this issue May 13, 2019
@alexcrichton
Remove thread_local! weirdness in anyref.rs
d3e95b7 
Resolves an old comment long since been fixed, and confirmed that we
still don't generate extra cruft!

Closes rustwasm#1523
@alexcrichton alexcrichton mentioned this issue May 13, 2019
Merged
alexcrichton added a commit to alexcrichton/wasm-bindgen that referenced this issue May 13, 2019
@alexcrichton
Remove thread_local! weirdness in anyref.rs

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
79dba40 
Resolves an old comment long since been fixed, and confirmed that we
still don't generate extra cruft!

Closes rustwasm#1523
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
question
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove thread_local! weirdness in anyref.rs alexcrichton/wasm-bindgen
1 participant
@fitzgen