Skip to content

JsString::from_char_code1 and family should take u16 not u32 #1460

Open
@RReverser

Description

@RReverser

String.prototype.charCodeAt can accept only UTF-16 code units which translate to u16, but current Rust bindings take u32 instead.

This would be a breaking change.

Metadata

Metadata

Assignees

No one assigned

    Labels

    breaking-changeTracking breaking changes for the next major version bump (if ever)js-sysIssues related to the `js-sys` crate

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions