Use #[automatically_derived] instead of #[coverage(off)]

daxpedda · daxpedda · commit ba801cda012f · 2024-08-18T14:50:16.000+02:00
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -11,6 +11,9 @@
 * Fixed incorrect deprecation warning when passing no parameter into `default()` (`init()`) or `initSync()`.
   [#4074](https://github.com/rustwasm/wasm-bindgen/pull/4074)
 
+* Fixed many proc-macro generated `impl` blocks missing `#[automatically_derived]`, affecting test coverage.
+  [#4078](https://github.com/rustwasm/wasm-bindgen/pull/4078)
+
 --------------------------------------------------------------------------------
 
 ## [0.2.93](https://github.com/rustwasm/wasm-bindgen/compare/0.2.92...0.2.93)
diff --git a/crates/backend/src/codegen.rs b/crates/backend/src/codegen.rs
@@ -222,7 +222,6 @@ impl ToTokens for ast::Struct {
         (quote! {
             #[automatically_derived]
             impl #wasm_bindgen::describe::WasmDescribe for #name {
-                #[cfg_attr(wasm_bindgen_unstable_test_coverage, coverage(off))]
                 fn describe() {
                     use #wasm_bindgen::__wbindgen_if_not_std;
                     use #wasm_bindgen::describe::*;
@@ -369,7 +368,7 @@ impl ToTokens for ast::Struct {
                 fn is_none(abi: &Self::Abi) -> bool { *abi == 0 }
             }
 
-            #[allow(clippy::all)]
+            #[automatically_derived]
             impl #wasm_bindgen::convert::TryFromJsValue for #name {
                 type Error = #wasm_bindgen::JsValue;
 
@@ -404,8 +403,8 @@ impl ToTokens for ast::Struct {
                 }
             }
 
+            #[automatically_derived]
             impl #wasm_bindgen::describe::WasmDescribeVector for #name {
-                #[cfg_attr(wasm_bindgen_unstable_test_coverage, coverage(off))]
                 fn describe_vector() {
                     use #wasm_bindgen::describe::*;
                     inform(VECTOR);
@@ -415,6 +414,7 @@ impl ToTokens for ast::Struct {
                 }
             }
 
+            #[automatically_derived]
             impl #wasm_bindgen::convert::VectorIntoWasmAbi for #name {
                 type Abi = <
                     #wasm_bindgen::__rt::alloc::boxed::Box<[#wasm_bindgen::JsValue]>
@@ -428,6 +428,7 @@ impl ToTokens for ast::Struct {
                 }
             }
 
+            #[automatically_derived]
             impl #wasm_bindgen::convert::VectorFromWasmAbi for #name {
                 type Abi = <
                     #wasm_bindgen::__rt::alloc::boxed::Box<[#wasm_bindgen::JsValue]>
@@ -441,6 +442,7 @@ impl ToTokens for ast::Struct {
                 }
             }
 
+            #[automatically_derived]
             impl #wasm_bindgen::__rt::VectorIntoJsValue for #name {
                 fn vector_into_jsvalue(vector: #wasm_bindgen::__rt::alloc::boxed::Box<[#name]>) -> #wasm_bindgen::JsValue {
                     #wasm_bindgen::__rt::js_value_vector_into_jsvalue(vector)
@@ -939,13 +941,14 @@ impl ToTokens for ast::ImportType {
                 use #wasm_bindgen::{JsValue, JsCast, JsObject};
                 use #wasm_bindgen::__rt::core;
 
+                #[automatically_derived]
                 impl WasmDescribe for #rust_name {
-                    #[cfg_attr(wasm_bindgen_unstable_test_coverage, coverage(off))]
                     fn describe() {
                         #description
                     }
                 }
 
+                #[automatically_derived]
                 impl IntoWasmAbi for #rust_name {
                     type Abi = <JsValue as IntoWasmAbi>::Abi;
 
@@ -955,20 +958,23 @@ impl ToTokens for ast::ImportType {
                     }
                 }
 
+                #[automatically_derived]
                 impl OptionIntoWasmAbi for #rust_name {
                     #[inline]
                     fn none() -> Self::Abi {
                         0
                     }
                 }
 
+                #[automatically_derived]
                 impl<'a> OptionIntoWasmAbi for &'a #rust_name {
                     #[inline]
                     fn none() -> Self::Abi {
                         0
                     }
                 }
 
+                #[automatically_derived]
                 impl FromWasmAbi for #rust_name {
                     type Abi = <JsValue as FromWasmAbi>::Abi;
 
@@ -980,11 +986,13 @@ impl ToTokens for ast::ImportType {
                     }
                 }
 
+                #[automatically_derived]
                 impl OptionFromWasmAbi for #rust_name {
                     #[inline]
                     fn is_none(abi: &Self::Abi) -> bool { *abi == 0 }
                 }
 
+                #[automatically_derived]
                 impl<'a> IntoWasmAbi for &'a #rust_name {
                     type Abi = <&'a JsValue as IntoWasmAbi>::Abi;
 
@@ -994,6 +1002,7 @@ impl ToTokens for ast::ImportType {
                     }
                 }
 
+                #[automatically_derived]
                 impl RefFromWasmAbi for #rust_name {
                     type Abi = <JsValue as RefFromWasmAbi>::Abi;
                     type Anchor = core::mem::ManuallyDrop<#rust_name>;
@@ -1007,6 +1016,7 @@ impl ToTokens for ast::ImportType {
                     }
                 }
 
+                #[automatically_derived]
                 impl LongRefFromWasmAbi for #rust_name {
                     type Abi = <JsValue as LongRefFromWasmAbi>::Abi;
                     type Anchor = #rust_name;
@@ -1019,31 +1029,36 @@ impl ToTokens for ast::ImportType {
                 }
 
                 // TODO: remove this on the next major version
+                #[automatically_derived]
                 impl From<JsValue> for #rust_name {
                     #[inline]
                     fn from(obj: JsValue) -> #rust_name {
                         #rust_name { obj: obj.into() }
                     }
                 }
 
+                #[automatically_derived]
                 impl AsRef<JsValue> for #rust_name {
                     #[inline]
                     fn as_ref(&self) -> &JsValue { self.obj.as_ref() }
                 }
 
+                #[automatically_derived]
                 impl AsRef<#rust_name> for #rust_name {
                     #[inline]
                     fn as_ref(&self) -> &#rust_name { self }
                 }
 
 
+                #[automatically_derived]
                 impl From<#rust_name> for JsValue {
                     #[inline]
                     fn from(obj: #rust_name) -> JsValue {
                         obj.obj.into()
                     }
                 }
 
+                #[automatically_derived]
                 impl JsCast for #rust_name {
                     fn instanceof(val: &JsValue) -> bool {
                         #[link(wasm_import_module = "__wbindgen_placeholder__")]
@@ -1592,7 +1607,7 @@ impl ToTokens for ast::Enum {
                 }
             }
 
-            #[allow(clippy::all)]
+            #[automatically_derived]
             impl #wasm_bindgen::convert::TryFromJsValue for #enum_name {
                 type Error = #wasm_bindgen::JsValue;
 
@@ -1609,15 +1624,16 @@ impl ToTokens for ast::Enum {
                 }
             }
 
+            #[automatically_derived]
             impl #wasm_bindgen::describe::WasmDescribeVector for #enum_name {
-                #[cfg_attr(wasm_bindgen_unstable_test_coverage, coverage(off))]
                 fn describe_vector() {
                     use #wasm_bindgen::describe::*;
                     inform(VECTOR);
                     <#wasm_bindgen::JsValue as #wasm_bindgen::describe::WasmDescribe>::describe();
                 }
             }
 
+            #[automatically_derived]
             impl #wasm_bindgen::convert::VectorIntoWasmAbi for #enum_name {
                 type Abi = <
                     #wasm_bindgen::__rt::alloc::boxed::Box<[#wasm_bindgen::JsValue]>
@@ -1631,6 +1647,7 @@ impl ToTokens for ast::Enum {
                 }
             }
 
+            #[automatically_derived]
             impl #wasm_bindgen::convert::VectorFromWasmAbi for #enum_name {
                 type Abi = <
                     #wasm_bindgen::__rt::alloc::boxed::Box<[#wasm_bindgen::JsValue]>
@@ -1644,6 +1661,7 @@ impl ToTokens for ast::Enum {
                 }
             }
 
+            #[automatically_derived]
             impl #wasm_bindgen::__rt::VectorIntoJsValue for #enum_name {
                 fn vector_into_jsvalue(vector: #wasm_bindgen::__rt::alloc::boxed::Box<[#enum_name]>) -> #wasm_bindgen::JsValue {
                     #wasm_bindgen::__rt::js_value_vector_into_jsvalue(vector)

Original file line number	Diff line number	Diff line change
`@@ -222,7 +222,6 @@ impl ToTokens for ast::Struct {`
`222`	`222`	`(quote! {`
`223`	`223`	`#[automatically_derived]`
`224`	`224`	`impl #wasm_bindgen::describe::WasmDescribe for #name {`
`225`		`- #[cfg_attr(wasm_bindgen_unstable_test_coverage, coverage(off))]`
`226`	`225`	`fn describe() {`
`227`	`226`	`use #wasm_bindgen::__wbindgen_if_not_std;`
`228`	`227`	`use #wasm_bindgen::describe::*;`
`@@ -369,7 +368,7 @@ impl ToTokens for ast::Struct {`
`369`	`368`	`fn is_none(abi: &Self::Abi) -> bool { *abi == 0 }`
`370`	`369`	`}`
`371`	`370`
`372`		`- #[allow(clippy::all)]`
	`371`	`+ #[automatically_derived]`
`373`	`372`	`impl #wasm_bindgen::convert::TryFromJsValue for #name {`
`374`	`373`	`type Error = #wasm_bindgen::JsValue;`
`375`	`374`
`@@ -404,8 +403,8 @@ impl ToTokens for ast::Struct {`
`404`	`403`	`}`
`405`	`404`	`}`
`406`	`405`
	`406`	`+ #[automatically_derived]`
`407`	`407`	`impl #wasm_bindgen::describe::WasmDescribeVector for #name {`
`408`		`- #[cfg_attr(wasm_bindgen_unstable_test_coverage, coverage(off))]`
`409`	`408`	`fn describe_vector() {`
`410`	`409`	`use #wasm_bindgen::describe::*;`
`411`	`410`	`inform(VECTOR);`
`@@ -415,6 +414,7 @@ impl ToTokens for ast::Struct {`
`415`	`414`	`}`
`416`	`415`	`}`
`417`	`416`
	`417`	`+ #[automatically_derived]`
`418`	`418`	`impl #wasm_bindgen::convert::VectorIntoWasmAbi for #name {`
`419`	`419`	`type Abi = <`
`420`	`420`	`#wasm_bindgen::__rt::alloc::boxed::Box<[#wasm_bindgen::JsValue]>`
`@@ -428,6 +428,7 @@ impl ToTokens for ast::Struct {`
`428`	`428`	`}`
`429`	`429`	`}`
`430`	`430`
	`431`	`+ #[automatically_derived]`
`431`	`432`	`impl #wasm_bindgen::convert::VectorFromWasmAbi for #name {`
`432`	`433`	`type Abi = <`
`433`	`434`	`#wasm_bindgen::__rt::alloc::boxed::Box<[#wasm_bindgen::JsValue]>`
`@@ -441,6 +442,7 @@ impl ToTokens for ast::Struct {`
`441`	`442`	`}`
`442`	`443`	`}`
`443`	`444`
	`445`	`+ #[automatically_derived]`
`444`	`446`	`impl #wasm_bindgen::__rt::VectorIntoJsValue for #name {`
`445`	`447`	`fn vector_into_jsvalue(vector: #wasm_bindgen::__rt::alloc::boxed::Box<[#name]>) -> #wasm_bindgen::JsValue {`
`446`	`448`	`#wasm_bindgen::__rt::js_value_vector_into_jsvalue(vector)`
`@@ -939,13 +941,14 @@ impl ToTokens for ast::ImportType {`
`939`	`941`	`use #wasm_bindgen::{JsValue, JsCast, JsObject};`
`940`	`942`	`use #wasm_bindgen::__rt::core;`
`941`	`943`
	`944`	`+ #[automatically_derived]`
`942`	`945`	`impl WasmDescribe for #rust_name {`
`943`		`- #[cfg_attr(wasm_bindgen_unstable_test_coverage, coverage(off))]`
`944`	`946`	`fn describe() {`
`945`	`947`	`#description`
`946`	`948`	`}`
`947`	`949`	`}`
`948`	`950`
	`951`	`+ #[automatically_derived]`
`949`	`952`	`impl IntoWasmAbi for #rust_name {`
`950`	`953`	`type Abi = <JsValue as IntoWasmAbi>::Abi;`
`951`	`954`
`@@ -955,20 +958,23 @@ impl ToTokens for ast::ImportType {`
`955`	`958`	`}`
`956`	`959`	`}`
`957`	`960`
	`961`	`+ #[automatically_derived]`
`958`	`962`	`impl OptionIntoWasmAbi for #rust_name {`
`959`	`963`	`#[inline]`
`960`	`964`	`fn none() -> Self::Abi {`
`961`	`965`	`0`
`962`	`966`	`}`
`963`	`967`	`}`
`964`	`968`
	`969`	`+ #[automatically_derived]`
`965`	`970`	`impl<'a> OptionIntoWasmAbi for &'a #rust_name {`
`966`	`971`	`#[inline]`
`967`	`972`	`fn none() -> Self::Abi {`
`968`	`973`	`0`
`969`	`974`	`}`
`970`	`975`	`}`
`971`	`976`
	`977`	`+ #[automatically_derived]`
`972`	`978`	`impl FromWasmAbi for #rust_name {`
`973`	`979`	`type Abi = <JsValue as FromWasmAbi>::Abi;`
`974`	`980`
`@@ -980,11 +986,13 @@ impl ToTokens for ast::ImportType {`
`980`	`986`	`}`
`981`	`987`	`}`
`982`	`988`
	`989`	`+ #[automatically_derived]`
`983`	`990`	`impl OptionFromWasmAbi for #rust_name {`
`984`	`991`	`#[inline]`
`985`	`992`	`fn is_none(abi: &Self::Abi) -> bool { *abi == 0 }`
`986`	`993`	`}`
`987`	`994`
	`995`	`+ #[automatically_derived]`
`988`	`996`	`impl<'a> IntoWasmAbi for &'a #rust_name {`
`989`	`997`	`type Abi = <&'a JsValue as IntoWasmAbi>::Abi;`
`990`	`998`
`@@ -994,6 +1002,7 @@ impl ToTokens for ast::ImportType {`
`994`	`1002`	`}`
`995`	`1003`	`}`
`996`	`1004`
	`1005`	`+ #[automatically_derived]`
`997`	`1006`	`impl RefFromWasmAbi for #rust_name {`
`998`	`1007`	`type Abi = <JsValue as RefFromWasmAbi>::Abi;`
`999`	`1008`	`type Anchor = core::mem::ManuallyDrop<#rust_name>;`
`@@ -1007,6 +1016,7 @@ impl ToTokens for ast::ImportType {`
`1007`	`1016`	`}`
`1008`	`1017`	`}`
`1009`	`1018`
	`1019`	`+ #[automatically_derived]`
`1010`	`1020`	`impl LongRefFromWasmAbi for #rust_name {`
`1011`	`1021`	`type Abi = <JsValue as LongRefFromWasmAbi>::Abi;`
`1012`	`1022`	`type Anchor = #rust_name;`
`@@ -1019,31 +1029,36 @@ impl ToTokens for ast::ImportType {`
`1019`	`1029`	`}`
`1020`	`1030`
`1021`	`1031`	`// TODO: remove this on the next major version`
	`1032`	`+ #[automatically_derived]`
`1022`	`1033`	`impl From<JsValue> for #rust_name {`
`1023`	`1034`	`#[inline]`
`1024`	`1035`	`fn from(obj: JsValue) -> #rust_name {`
`1025`	`1036`	`#rust_name { obj: obj.into() }`
`1026`	`1037`	`}`
`1027`	`1038`	`}`
`1028`	`1039`
	`1040`	`+ #[automatically_derived]`
`1029`	`1041`	`impl AsRef<JsValue> for #rust_name {`
`1030`	`1042`	`#[inline]`
`1031`	`1043`	`fn as_ref(&self) -> &JsValue { self.obj.as_ref() }`
`1032`	`1044`	`}`
`1033`	`1045`
	`1046`	`+ #[automatically_derived]`
`1034`	`1047`	`impl AsRef<#rust_name> for #rust_name {`
`1035`	`1048`	`#[inline]`
`1036`	`1049`	`fn as_ref(&self) -> &#rust_name { self }`
`1037`	`1050`	`}`
`1038`	`1051`
`1039`	`1052`
	`1053`	`+ #[automatically_derived]`
`1040`	`1054`	`impl From<#rust_name> for JsValue {`
`1041`	`1055`	`#[inline]`
`1042`	`1056`	`fn from(obj: #rust_name) -> JsValue {`
`1043`	`1057`	`obj.obj.into()`
`1044`	`1058`	`}`
`1045`	`1059`	`}`
`1046`	`1060`
	`1061`	`+ #[automatically_derived]`
`1047`	`1062`	`impl JsCast for #rust_name {`
`1048`	`1063`	`fn instanceof(val: &JsValue) -> bool {`
`1049`	`1064`	`#[link(wasm_import_module = "__wbindgen_placeholder__")]`
`@@ -1592,7 +1607,7 @@ impl ToTokens for ast::Enum {`
`1592`	`1607`	`}`
`1593`	`1608`	`}`
`1594`	`1609`
`1595`		`- #[allow(clippy::all)]`
	`1610`	`+ #[automatically_derived]`
`1596`	`1611`	`impl #wasm_bindgen::convert::TryFromJsValue for #enum_name {`
`1597`	`1612`	`type Error = #wasm_bindgen::JsValue;`
`1598`	`1613`
`@@ -1609,15 +1624,16 @@ impl ToTokens for ast::Enum {`
`1609`	`1624`	`}`
`1610`	`1625`	`}`
`1611`	`1626`
	`1627`	`+ #[automatically_derived]`
`1612`	`1628`	`impl #wasm_bindgen::describe::WasmDescribeVector for #enum_name {`
`1613`		`- #[cfg_attr(wasm_bindgen_unstable_test_coverage, coverage(off))]`
`1614`	`1629`	`fn describe_vector() {`
`1615`	`1630`	`use #wasm_bindgen::describe::*;`
`1616`	`1631`	`inform(VECTOR);`
`1617`	`1632`	`<#wasm_bindgen::JsValue as #wasm_bindgen::describe::WasmDescribe>::describe();`
`1618`	`1633`	`}`
`1619`	`1634`	`}`
`1620`	`1635`
	`1636`	`+ #[automatically_derived]`
`1621`	`1637`	`impl #wasm_bindgen::convert::VectorIntoWasmAbi for #enum_name {`
`1622`	`1638`	`type Abi = <`
`1623`	`1639`	`#wasm_bindgen::__rt::alloc::boxed::Box<[#wasm_bindgen::JsValue]>`
`@@ -1631,6 +1647,7 @@ impl ToTokens for ast::Enum {`
`1631`	`1647`	`}`
`1632`	`1648`	`}`
`1633`	`1649`
	`1650`	`+ #[automatically_derived]`
`1634`	`1651`	`impl #wasm_bindgen::convert::VectorFromWasmAbi for #enum_name {`
`1635`	`1652`	`type Abi = <`
`1636`	`1653`	`#wasm_bindgen::__rt::alloc::boxed::Box<[#wasm_bindgen::JsValue]>`
`@@ -1644,6 +1661,7 @@ impl ToTokens for ast::Enum {`
`1644`	`1661`	`}`
`1645`	`1662`	`}`
`1646`	`1663`
	`1664`	`+ #[automatically_derived]`
`1647`	`1665`	`impl #wasm_bindgen::__rt::VectorIntoJsValue for #enum_name {`
`1648`	`1666`	`fn vector_into_jsvalue(vector: #wasm_bindgen::__rt::alloc::boxed::Box<[#enum_name]>) -> #wasm_bindgen::JsValue {`
`1649`	`1667`	`#wasm_bindgen::__rt::js_value_vector_into_jsvalue(vector)`