Skip to content

Commit 87e01bc

Browse files
committed
Rebase fallout and review comments
1 parent e4ba33f commit 87e01bc

File tree

2 files changed

+7
-7
lines changed

2 files changed

+7
-7
lines changed

src/cast.rs

+6-6
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ where
1818
{
1919
/// Test whether this JS value is an instance of the type `T`.
2020
///
21-
/// This commit performs a dynamic check (at runtime) using the JS
21+
/// This method performs a dynamic check (at runtime) using the JS
2222
/// `instanceof` operator. This method returns `self instanceof T`.
2323
fn is_instance_of<T>(&self) -> bool
2424
where
@@ -32,7 +32,7 @@ where
3232
///
3333
/// This method will return `Err(self)` is `self.is_instance_of::<T>()`
3434
/// returns `false`, and otherwise it will return `Ok(T)` manufactured with
35-
/// an unchecked cast (verified safe via the `instanceof` operation).
35+
/// an unchecked cast (verified correct via the `instanceof` operation).
3636
fn dyn_into<T>(self) -> Result<T, Self>
3737
where
3838
T: JsCast,
@@ -49,7 +49,7 @@ where
4949
///
5050
/// This method will return `None` is `self.is_instance_of::<T>()`
5151
/// returns `false`, and otherwise it will return `Some(&T)` manufactured
52-
/// with an unchecked cast (verified safe via the `instanceof` operation).
52+
/// with an unchecked cast (verified correct via the `instanceof` operation).
5353
fn dyn_ref<T>(&self) -> Option<&T>
5454
where
5555
T: JsCast,
@@ -66,8 +66,8 @@ where
6666
///
6767
/// This method will return `None` is `self.is_instance_of::<T>()`
6868
/// returns `false`, and otherwise it will return `Some(&mut T)`
69-
/// manufactured with an unchecked cast (verified safe via the `instanceof`
70-
/// operation).
69+
/// manufactured with an unchecked cast (verified correct via the
70+
/// `instanceof` operation).
7171
fn dyn_mut<T>(&mut self) -> Option<&mut T>
7272
where
7373
T: JsCast,
@@ -85,7 +85,7 @@ where
8585
/// `self` and `T` are simple wrappers around `JsValue`. This method **does
8686
/// not check whether `self` is an instance of `T`**. If used incorrectly
8787
/// then this method may cause runtime exceptions in both Rust and JS, this
88-
/// shoudl be used with caution.
88+
/// should be used with caution.
8989
fn unchecked_into<T>(self) -> T
9090
where
9191
T: JsCast,

tests/wasm/jscast.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ use wasm_bindgen::JsCast;
22
use wasm_bindgen::prelude::*;
33
use wasm_bindgen_test::*;
44

5-
#[wasm_bindgen(module = "tests/wasm/jscast.js", version = "*")]
5+
#[wasm_bindgen(module = "tests/wasm/jscast.js")]
66
extern {
77
type JsCast1;
88
#[wasm_bindgen(constructor)]

0 commit comments

Comments
 (0)