Skip to content

Integrating into simd-json #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
CJP10 opened this issue Apr 23, 2021 · 3 comments
Closed

Integrating into simd-json #7

CJP10 opened this issue Apr 23, 2021 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@CJP10
Copy link

CJP10 commented Apr 23, 2021

Would make a lot of sense to use this in simd-json. It should be straight forward to do but might have to make some of the internals public. Let me know what you think and I can help kick this off.

@hkratz
Copy link
Contributor

hkratz commented Apr 24, 2021

Simd-json.rs already uses lookup4 and the alignment changes and runtime dispatch of simdutf8 would not carry over if you tie directly into the 64-byte block processing.

So the main benefit would be removing redundancy and thus not having to convert that piece of code to the "#[target_feature(enable="...")] plus macros" style needed for runtime dispatch.

@hkratz
Copy link
Contributor

hkratz commented May 2, 2021

@CJP10 Right now I have plans for a generic streaming API (see #25) which would make replacing the UTF-8 valdiation in simd-json quite easy. Will take a bit though until I get to it. Simdjson would benefit performance-, maintenance- and architecture-support-wise (aarch64).

@hkratz hkratz added the enhancement New feature or request label May 2, 2021
@hkratz hkratz self-assigned this May 9, 2021
@hkratz
Copy link
Contributor

hkratz commented May 14, 2021

Done with simd-lite/simd-json#190.

@hkratz hkratz closed this as completed May 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants