Skip to content

Commit 8b9bd0f

Browse files
authored
chore: enhance cross-check workflow by adding target platforms and updating job names (#1369)
Signed-off-by: simonsan <[email protected]>
1 parent 7ed7260 commit 8b9bd0f

File tree

2 files changed

+18
-25
lines changed

2 files changed

+18
-25
lines changed

.github/workflows/cross-ci.yml

Lines changed: 16 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ concurrency:
2222

2323
jobs:
2424
cross-check:
25-
name: Cross checking ${{ matrix.job.target }}
25+
name: Cross checking ${{ matrix.job.target }} on ${{ matrix.rust }}
2626
runs-on: ${{ matrix.job.os }}
2727
strategy:
2828
fail-fast: false
@@ -35,12 +35,11 @@ jobs:
3535
target: x86_64-pc-windows-msvc
3636
architecture: x86_64
3737
use-cross: false
38-
# FIXME: `aws-lc-sys` doesn't cross compile
39-
# - os: windows-latest
40-
# os-name: windows
41-
# target: x86_64-pc-windows-gnu
42-
# architecture: x86_64
43-
# use-cross: false
38+
- os: windows-latest
39+
os-name: windows
40+
target: x86_64-pc-windows-gnu
41+
architecture: x86_64
42+
use-cross: false
4443
- os: macos-13
4544
os-name: macos
4645
target: x86_64-apple-darwin
@@ -76,18 +75,16 @@ jobs:
7675
target: i686-unknown-linux-gnu
7776
architecture: i686
7877
use-cross: true
79-
# FIXME: `aws-lc-sys` doesn't cross compile
80-
# - os: ubuntu-latest
81-
# os-name: netbsd
82-
# target: x86_64-unknown-netbsd
83-
# architecture: x86_64
84-
# use-cross: true
85-
# FIXME: `aws-lc-sys` doesn't cross compile
86-
# - os: ubuntu-latest
87-
# os-name: linux
88-
# target: armv7-unknown-linux-gnueabihf
89-
# architecture: armv7
90-
# use-cross: true
78+
- os: ubuntu-latest
79+
os-name: netbsd
80+
target: x86_64-unknown-netbsd
81+
architecture: x86_64
82+
use-cross: true
83+
- os: ubuntu-latest
84+
os-name: linux
85+
target: armv7-unknown-linux-gnueabihf
86+
architecture: armv7
87+
use-cross: true
9188

9289
steps:
9390
- name: Checkout repository

deny.toml

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -183,12 +183,8 @@ allow = [
183183
]
184184
# List of crates to deny
185185
deny = [
186-
187-
188-
# { crate = "[email protected]", reason = "you can specify a reason it is banned" },
189-
# Wrapper crates can optionally be specified to allow the crate when it
190-
# is a direct dependency of the otherwise banned crate
191-
# { crate = "[email protected]", wrappers = ["this-crate-directly-depends-on-ansi_term"] },
186+
{ crate = "aws-lc-rs", reason = "this crate introduces exorbitant build effort and breaks cross-compilation" },
187+
{ crate = "aws-lc-sys", reason = "this crate introduces exorbitant build effort and breaks cross-compilation" },
192188
]
193189

194190
# List of features to allow/deny

0 commit comments

Comments
 (0)