Skip to content

Commit d41dc56

Browse files
committed
Rename look_at to look_to in Rotation trait
1 parent 2c0a3cc commit d41dc56

File tree

2 files changed

+10
-4
lines changed

2 files changed

+10
-4
lines changed

src/quaternion.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -474,7 +474,7 @@ impl<S: BaseFloat> From<Quaternion<S>> for Basis3<S> {
474474

475475
impl<S: BaseFloat> Rotation<Point3<S>> for Quaternion<S> {
476476
#[inline]
477-
fn look_at(dir: Vector3<S>, up: Vector3<S>) -> Quaternion<S> {
477+
fn look_to(dir: Vector3<S>, up: Vector3<S>) -> Quaternion<S> {
478478
Matrix3::look_at(dir, up).into()
479479
}
480480

src/rotation.rs

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,13 @@ where
4040
Self: iter::Product<Self>,
4141
{
4242
/// Create a rotation to a given direction with an 'up' vector.
43-
fn look_at(dir: P::Diff, up: P::Diff) -> Self;
43+
#[deprecated = "Use Rotation::look_to"]
44+
fn look_at(dir: P::Diff, up: P::Diff) -> Self {
45+
Self::look_to(dir, up)
46+
}
47+
48+
/// Create a rotation to a given direction with an 'up' vector.
49+
fn look_to(dir: P::Diff, up: P::Diff) -> Self;
4450

4551
/// Create a shortest rotation to transform vector 'a' into 'b'.
4652
/// Both given vectors are assumed to have unit length.
@@ -185,7 +191,7 @@ impl<'a, S: 'a + BaseFloat> iter::Product<&'a Basis2<S>> for Basis2<S> {
185191

186192
impl<S: BaseFloat> Rotation<Point2<S>> for Basis2<S> {
187193
#[inline]
188-
fn look_at(dir: Vector2<S>, up: Vector2<S>) -> Basis2<S> {
194+
fn look_to(dir: Vector2<S>, up: Vector2<S>) -> Basis2<S> {
189195
Basis2 {
190196
mat: Matrix2::look_to(dir, up),
191197
}
@@ -336,7 +342,7 @@ impl<'a, S: 'a + BaseFloat> iter::Product<&'a Basis3<S>> for Basis3<S> {
336342

337343
impl<S: BaseFloat> Rotation<Point3<S>> for Basis3<S> {
338344
#[inline]
339-
fn look_at(dir: Vector3<S>, up: Vector3<S>) -> Basis3<S> {
345+
fn look_to(dir: Vector3<S>, up: Vector3<S>) -> Basis3<S> {
340346
Basis3 {
341347
mat: Matrix3::look_at(dir, up),
342348
}

0 commit comments

Comments
 (0)