fix(writer): clippy::incorrect_partial_ord_impl_on_ord_type

mkroening · danielverkamp · commit d5fe5634f317 · 2023-11-09T09:50:49.000-08:00
Signed-off-by: Martin Kröning &lt;martin.kroening@eonerc.rwth-aachen.de&gt;
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,3 +1,9 @@
+# Upcoming Release
+
+## Fixed
+- [[#69](https://github.com/rust-vmm/vm-fdt/pull/69)] Fixed
+  `clippy::incorrect_partial_ord_impl_on_ord_type`.
+
 # v0.2.0
 
 ## Added
diff --git a/src/writer.rs b/src/writer.rs
@@ -136,7 +136,7 @@ impl Ord for FdtReserveEntry {
 
 impl PartialOrd for FdtReserveEntry {
     fn partial_cmp(&self, other: &Self) -> Option<Ordering> {
-        self.address.partial_cmp(&other.address)
+        Some(self.cmp(other))
     }
 }
 

Original file line number	Diff line number	Diff line change
`@@ -136,7 +136,7 @@ impl Ord for FdtReserveEntry {`
`136`	`136`
`137`	`137`	`impl PartialOrd for FdtReserveEntry {`
`138`	`138`	`fn partial_cmp(&self, other: &Self) -> Option<Ordering> {`
`139`		`- self.address.partial_cmp(&other.address)`
	`139`	`+ Some(self.cmp(other))`
`140`	`140`	`}`
`141`	`141`	`}`
`142`	`142`