Skip to content

Bump libc dependency version #772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Paul-E opened this issue Apr 13, 2019 · 3 comments
Closed

Bump libc dependency version #772

Paul-E opened this issue Apr 13, 2019 · 3 comments

Comments

@Paul-E
Copy link

Paul-E commented Apr 13, 2019

Currently the libc dependency version is listed as 0.2. There is a call to pthread_atfork, which is in libc. pthread_atfork doesn't appear to be in libc 0.2 though, so the compilation will fail if cargo doesn't grab one of the newer version of libc. The earliest I see it is in 0.2.30

@vks
Copy link
Collaborator

vks commented Apr 14, 2019

On docs.rs, I can find pthread_atfork in 0.2.22, but not in 0.2.21.

@dhardy
Copy link
Member

dhardy commented Apr 15, 2019

getrandom already requires 0.2.29 on UNIX, so although there's no reason not to bump the version, but it won't achieve anything since the next release will require this version anyway.

@vks
Copy link
Collaborator

vks commented Apr 15, 2019

This was fixed in #773.

getrandom already requires 0.2.29 on UNIX, so although there's no reason not to bump the version, but it won't achieve anything since the next release will require this version anyway.

Fair enough, but I think it still makes sense for correctness. In theory, rand does not know about the dependencies of getrandom.

@vks vks closed this as completed Apr 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants