fix(interrupts): replace compiler fences with potentially-synchronizing assembly (#440)

* fix(interrupts): replace compiler fences with potentially-synchronizing assembly

Compiler fences only synchronize with atomic instructions. When creating a thread-local critical section, we need to prevent reordering of any reads and writes across interrupt toggles, not just atomic ones. To achieve this, we omit `nomem` from `asm!`. Since then, the assembly might potentially perform synchronizing operations such as acquiring or releasing a lock, the compiler won't move any reads and writes through these assembly blocks.

Signed-off-by: Martin Kröning <[email protected]>

* fix(interrupts): add `preserves_flags` option

`IF` from `EFLAGS` must not be restored upon exiting the asm block.
https://doc.rust-lang.org/stable/reference/inline-assembly.html#rules-for-inline-assembly

Signed-off-by: Martin Kröning <[email protected]>

---------

Signed-off-by: Martin Kröning <[email protected]>

Author: mkroening

src/instructions/interrupts.rs

@@ -1,7 +1,6 @@
 //! Enabling and disabling interrupts
 
 use core::arch::asm;
-use core::sync::atomic::{compiler_fence, Ordering};
 
 /// Returns whether interrupts are enabled.
 #[inline]
@@ -16,10 +15,10 @@ pub fn are_enabled() -> bool {
 /// This is a wrapper around the `sti` instruction.
 #[inline]
 pub fn enable() {
-    // Prevent earlier writes to be moved beyond this point
-    compiler_fence(Ordering::Release);
+    // Omit `nomem` to imitate a lock release. Otherwise, the compiler
+    // is free to move reads and writes through this asm block.
     unsafe {
-        asm!("sti", options(nomem, nostack));
+        asm!("sti", options(preserves_flags, nostack));
     }
 }
 
@@ -28,10 +27,10 @@ pub fn enable() {
 /// This is a wrapper around the `cli` instruction.
 #[inline]
 pub fn disable() {
-    // Prevent future writes to be moved before this point.
-    compiler_fence(Ordering::Acquire);
+    // Omit `nomem` to imitate a lock acquire. Otherwise, the compiler
+    // is free to move reads and writes through this asm block.
     unsafe {
-        asm!("cli", options(nomem, nostack));
+        asm!("cli", options(preserves_flags, nostack));
     }
 }