Skip to content

Commit fff01fd

Browse files
committed
uefi: mem: cleanup unnecessary key duplication
1 parent f7f4fa8 commit fff01fd

File tree

1 file changed

+3
-8
lines changed

1 file changed

+3
-8
lines changed

uefi/src/mem/memory_map/impl_.rs

Lines changed: 3 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@ use uefi_raw::PhysicalAddress;
1313
#[allow(dead_code)] // TODO: github.com/rust-osdev/uefi-rs/issues/1247
1414
pub struct MemoryMapRef<'a> {
1515
buf: &'a [u8],
16-
key: MemoryMapKey,
1716
meta: MemoryMapMeta,
1817
len: usize,
1918
}
@@ -24,7 +23,7 @@ impl<'a> MemoryMap for MemoryMapRef<'a> {
2423
}
2524

2625
fn key(&self) -> MemoryMapKey {
27-
self.key
26+
self.meta.map_key
2827
}
2928

3029
fn len(&self) -> usize {
@@ -55,7 +54,6 @@ impl Index<usize> for MemoryMapRef<'_> {
5554
#[derive(Debug)]
5655
pub struct MemoryMapRefMut<'a> {
5756
buf: &'a mut [u8],
58-
key: MemoryMapKey,
5957
meta: MemoryMapMeta,
6058
len: usize,
6159
}
@@ -66,7 +64,7 @@ impl<'a> MemoryMap for MemoryMapRefMut<'a> {
6664
}
6765

6866
fn key(&self) -> MemoryMapKey {
69-
self.key
67+
self.meta.map_key
7068
}
7169

7270
fn len(&self) -> usize {
@@ -297,7 +295,6 @@ impl Drop for MemoryMapBackingMemory {
297295
pub struct MemoryMapOwned {
298296
/// Backing memory, properly initialized at this point.
299297
pub(crate) buf: MemoryMapBackingMemory,
300-
pub(crate) key: MemoryMapKey,
301298
pub(crate) meta: MemoryMapMeta,
302299
pub(crate) len: usize,
303300
}
@@ -309,7 +306,6 @@ impl MemoryMapOwned {
309306
assert!(meta.desc_size >= mem::size_of::<MemoryDescriptor>());
310307
let len = meta.entry_count();
311308
MemoryMapOwned {
312-
key: MemoryMapKey(0),
313309
buf,
314310
meta,
315311
len,
@@ -337,7 +333,7 @@ impl MemoryMap for MemoryMapOwned {
337333
}
338334

339335
fn key(&self) -> MemoryMapKey {
340-
self.key
336+
self.meta.map_key
341337
}
342338

343339
fn len(&self) -> usize {
@@ -360,7 +356,6 @@ impl MemoryMapMut for MemoryMapOwned {
360356
fn sort(&mut self) {
361357
let mut reference = MemoryMapRefMut {
362358
buf: self.buf.as_mut_slice(),
363-
key: self.key,
364359
meta: self.meta,
365360
len: self.len,
366361
};

0 commit comments

Comments
 (0)