Skip to content

Likely possible to revert #168 in the next days #171

Closed
@jamesmunns

Description

@jamesmunns

Hey! We ran into the same root issue re: gc-sections fixed by #168, I wanted to highlight this upstream regression will likely be fixed by rust-lang/rust#85531, and you may decide to revert your hotfix.

It doesn't seem that passing --gc-sections twice causes problems (at least with rust-lld), so feel free to close this if you'd like to keep it, but I wanted to make sure you were in the loop.

Activity

phil-opp

phil-opp commented on May 21, 2021

@phil-opp
Member

Great, thanks a lot for letting me know!

I think we'll probably keep the extra --gc-sections arg for now to ensure that people have a working crate even if they're using one of nightlies released between rust-lang/rust#85274 and rust-lang/rust#85531. In the long term, I'm happy to remove the extra argument again, but probably only on the current main branch (cc #170), not on the v0.9 hotfix. (This assumes that passing --gc-sections twice really doesn't cause any problems. If it does, we will of course do the revert.)

As a side note, I planned to update my blog_os project with a manual --gc-sections arg too in order to prevent binary bloat. It's good to know that I no longer have to do that after rust-lang/rust#85531. So thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @phil-opp@jamesmunns

        Issue actions

          Likely possible to revert #168 in the next days · Issue #171 · rust-osdev/bootloader