Skip to content

Commit d7bf02f

Browse files
shivkr6cathay4t
authored andcommitted
Use netlink-packet-core 0.8.1
Signed-off-by: Shivang K Raghuvanshi <[email protected]>
1 parent 1129cbd commit d7bf02f

File tree

14 files changed

+59
-57
lines changed

14 files changed

+59
-57
lines changed

Cargo.toml

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -12,10 +12,7 @@ repository = "https://github.com/rust-netlink/netlink-packet-netfilter"
1212
description = "netlink packet types for the netfilter subprotocol"
1313

1414
[dependencies]
15-
anyhow = "1.0.32"
16-
byteorder = "1.3.4"
17-
netlink-packet-core = { version = "0.7.0" }
18-
netlink-packet-utils = { version = "0.5.1" }
15+
netlink-packet-core = { version = "0.8.1" }
1916
bitflags = "2.3"
2017
libc = "0.2.77"
2118
derive_more = "0.99.16"

src/buffer.rs

Lines changed: 5 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -7,11 +7,9 @@ use crate::{
77
},
88
nflog::NfLogMessage,
99
};
10-
use anyhow::Context;
11-
use netlink_packet_utils::{
12-
buffer,
13-
nla::{DefaultNla, NlaBuffer, NlasIterator},
14-
DecodeError, Parseable, ParseableParametrized,
10+
use netlink_packet_core::{
11+
buffer, fields, DecodeError, DefaultNla, ErrorContext, NlaBuffer,
12+
NlasIterator, Parseable, ParseableParametrized,
1513
};
1614

1715
buffer!(NetfilterBuffer(NETFILTER_HEADER_LEN) {
@@ -30,11 +28,10 @@ impl<'a, T: AsRef<[u8]> + ?Sized> NetfilterBuffer<&'a T> {
3028
where
3129
F: Fn(NlaBuffer<&[u8]>) -> Result<U, DecodeError>,
3230
{
33-
Ok(self
34-
.nlas()
31+
self.nlas()
3532
.map(|buf| f(buf?))
3633
.collect::<Result<Vec<_>, _>>()
37-
.context("failed to parse NLAs")?)
34+
.context("failed to parse NLAs")
3835
}
3936

4037
pub fn default_nlas(&self) -> Result<Vec<DefaultNla>, DecodeError> {

src/constants.rs

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,5 @@
11
// SPDX-License-Identifier: MIT
22

3-
pub use netlink_packet_core::constants::*;
4-
53
pub const AF_UNSPEC: u8 = libc::AF_UNSPEC as u8;
64
pub const AF_UNIX: u8 = libc::AF_UNIX as u8;
75
pub const AF_LOCAL: u8 = libc::AF_LOCAL as u8;

src/message.rs

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,9 @@
11
// SPDX-License-Identifier: MIT
22

33
use netlink_packet_core::{
4+
buffer, fields, getter, setter, DecodeError, DefaultNla, Emitable,
45
NetlinkDeserializable, NetlinkHeader, NetlinkPayload, NetlinkSerializable,
5-
};
6-
use netlink_packet_utils::{
7-
buffer, nla::DefaultNla, DecodeError, Emitable, Parseable,
8-
ParseableParametrized,
6+
Parseable, ParseableParametrized,
97
};
108

119
use crate::{buffer::NetfilterBuffer, nflog::NfLogMessage};

src/nflog/message.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
// SPDX-License-Identifier: MIT
22

3-
use netlink_packet_utils::{
4-
nla::DefaultNla, DecodeError, Emitable, Parseable, ParseableParametrized,
3+
use netlink_packet_core::{
4+
DecodeError, DefaultNla, Emitable, Parseable, ParseableParametrized,
55
};
66

77
use crate::{

src/nflog/nlas/config/config_cmd.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
// SPDX-License-Identifier: MIT
22

3-
use netlink_packet_utils::nla::Nla;
3+
use netlink_packet_core::Nla;
44

55
const NFULA_CFG_CMD: u16 = libc::NFULA_CFG_CMD as u16;
66
const NFULNL_CFG_CMD_NONE: u8 = libc::NFULNL_CFG_CMD_NONE as u8;

src/nflog/nlas/config/config_flags.rs

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,7 @@
33
use std::mem::size_of;
44

55
use bitflags::bitflags;
6-
use byteorder::{BigEndian, ByteOrder};
7-
use netlink_packet_utils::nla::Nla;
6+
use netlink_packet_core::{emit_u16_be, Nla};
87

98
const NFULA_CFG_FLAGS: u16 = libc::NFULA_CFG_FLAGS as u16;
109

@@ -34,6 +33,6 @@ impl Nla for ConfigFlags {
3433
}
3534

3635
fn emit_value(&self, buffer: &mut [u8]) {
37-
BigEndian::write_u16(buffer, self.bits());
36+
emit_u16_be(buffer, self.bits()).unwrap();
3837
}
3938
}

src/nflog/nlas/config/config_mode.rs

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,8 @@
11
// SPDX-License-Identifier: MIT
22

3-
use netlink_packet_utils::{buffer, errors::DecodeError, nla::Nla, Parseable};
3+
use netlink_packet_core::{
4+
buffer, fields, getter, setter, DecodeError, Nla, Parseable,
5+
};
46

57
const NFULA_CFG_MODE: u16 = libc::NFULA_CFG_MODE as u16;
68
const NFULNL_COPY_NONE: u8 = libc::NFULNL_COPY_NONE as u8;

src/nflog/nlas/config/nla.rs

Lines changed: 5 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,9 @@
11
// SPDX-License-Identifier: MIT
22

3-
use anyhow::Context;
4-
use byteorder::{BigEndian, ByteOrder};
53
use derive_more::{From, IsVariant};
6-
use netlink_packet_utils::{
7-
nla::{DefaultNla, Nla, NlaBuffer},
8-
parsers::{parse_u16_be, parse_u32_be, parse_u8},
9-
DecodeError, Parseable,
4+
use netlink_packet_core::{
5+
emit_u32_be, parse_u16_be, parse_u32_be, parse_u8, DecodeError, DefaultNla,
6+
ErrorContext, Nla, NlaBuffer, Parseable,
107
};
118

129
use crate::{
@@ -63,11 +60,11 @@ impl Nla for ConfigNla {
6360
ConfigNla::Cmd(attr) => attr.emit_value(buffer),
6461
ConfigNla::Mode(attr) => attr.emit_value(buffer),
6562
ConfigNla::NlBufSiz(buf_siz) => {
66-
BigEndian::write_u32(buffer, *buf_siz)
63+
emit_u32_be(buffer, *buf_siz).unwrap();
6764
}
6865
ConfigNla::Timeout(attr) => attr.emit_value(buffer),
6966
ConfigNla::QThresh(q_thresh) => {
70-
BigEndian::write_u32(buffer, *q_thresh)
67+
emit_u32_be(buffer, *q_thresh).unwrap();
7168
}
7269
ConfigNla::Flags(attr) => attr.emit_value(buffer),
7370
ConfigNla::Other(attr) => attr.emit_value(buffer),

src/nflog/nlas/config/timeout.rs

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,7 @@
22

33
use std::{convert::TryInto, mem::size_of, time::Duration};
44

5-
use byteorder::{BigEndian, ByteOrder};
6-
use netlink_packet_utils::nla::Nla;
5+
use netlink_packet_core::{emit_u32_be, Nla};
76

87
const NFULA_CFG_TIMEOUT: u16 = libc::NFULA_CFG_TIMEOUT as u16;
98

@@ -36,6 +35,6 @@ impl Nla for Timeout {
3635
}
3736

3837
fn emit_value(&self, buffer: &mut [u8]) {
39-
BigEndian::write_u32(buffer, self.hundredth);
38+
emit_u32_be(buffer, self.hundredth).unwrap();
4039
}
4140
}

0 commit comments

Comments
 (0)