Skip to content

Commit 58a9f67

Browse files
committed
shape: Remove usages of deprecated .reshape()
1 parent 8dd7ad8 commit 58a9f67

File tree

3 files changed

+19
-19
lines changed

3 files changed

+19
-19
lines changed

tests/broadcast.rs

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -5,12 +5,12 @@ use ndarray::prelude::*;
55
fn broadcast_1() {
66
let a_dim = Dim([2, 4, 2, 2]);
77
let b_dim = Dim([2, 1, 2, 1]);
8-
let a = ArcArray::linspace(0., 1., a_dim.size()).reshape(a_dim);
9-
let b = ArcArray::linspace(0., 1., b_dim.size()).reshape(b_dim);
8+
let a = ArcArray::linspace(0., 1., a_dim.size()).into_shape(a_dim).unwrap();
9+
let b = ArcArray::linspace(0., 1., b_dim.size()).into_shape(b_dim).unwrap();
1010
assert!(b.broadcast(a.dim()).is_some());
1111

1212
let c_dim = Dim([2, 1]);
13-
let c = ArcArray::linspace(0., 1., c_dim.size()).reshape(c_dim);
13+
let c = ArcArray::linspace(0., 1., c_dim.size()).into_shape(c_dim).unwrap();
1414
assert!(c.broadcast(1).is_none());
1515
assert!(c.broadcast(()).is_none());
1616
assert!(c.broadcast((2, 1)).is_some());
@@ -31,8 +31,8 @@ fn broadcast_1() {
3131
fn test_add() {
3232
let a_dim = Dim([2, 4, 2, 2]);
3333
let b_dim = Dim([2, 1, 2, 1]);
34-
let mut a = ArcArray::linspace(0.0, 1., a_dim.size()).reshape(a_dim);
35-
let b = ArcArray::linspace(0.0, 1., b_dim.size()).reshape(b_dim);
34+
let mut a = ArcArray::linspace(0.0, 1., a_dim.size()).into_shape(a_dim).unwrap();
35+
let b = ArcArray::linspace(0.0, 1., b_dim.size()).into_shape(b_dim).unwrap();
3636
a += &b;
3737
let t = ArcArray::from_elem((), 1.0f32);
3838
a += &t;
@@ -43,7 +43,7 @@ fn test_add() {
4343
#[cfg(feature = "std")]
4444
fn test_add_incompat() {
4545
let a_dim = Dim([2, 4, 2, 2]);
46-
let mut a = ArcArray::linspace(0.0, 1., a_dim.size()).reshape(a_dim);
46+
let mut a = ArcArray::linspace(0.0, 1., a_dim.size()).into_shape(a_dim).unwrap();
4747
let incompat = ArcArray::from_elem(3, 1.0f32);
4848
a += &incompat;
4949
}

tests/dimension.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -55,8 +55,8 @@ fn remove_axis() {
5555
let a = ArcArray::<f32, _>::zeros(vec![4, 5, 6]);
5656
let _b = a
5757
.index_axis_move(Axis(1), 0)
58-
.reshape((4, 6))
59-
.reshape(vec![2, 3, 4]);
58+
.to_shape((4, 6)).unwrap()
59+
.to_shape(vec![2, 3, 4]).unwrap();
6060
}
6161

6262
#[test]

tests/oper.rs

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -16,24 +16,24 @@ use approx::assert_abs_diff_eq;
1616
use defmac::defmac;
1717

1818
fn test_oper(op: &str, a: &[f32], b: &[f32], c: &[f32]) {
19-
let aa = rcarr1(a);
20-
let bb = rcarr1(b);
21-
let cc = rcarr1(c);
19+
let aa = CowArray::from(arr1(a));
20+
let bb = CowArray::from(arr1(b));
21+
let cc = CowArray::from(arr1(c));
2222
test_oper_arr::<f32, _>(op, aa.clone(), bb.clone(), cc.clone());
2323
let dim = (2, 2);
24-
let aa = aa.reshape(dim);
25-
let bb = bb.reshape(dim);
26-
let cc = cc.reshape(dim);
24+
let aa = aa.to_shape(dim).unwrap();
25+
let bb = bb.to_shape(dim).unwrap();
26+
let cc = cc.to_shape(dim).unwrap();
2727
test_oper_arr::<f32, _>(op, aa.clone(), bb.clone(), cc.clone());
2828
let dim = (1, 2, 1, 2);
29-
let aa = aa.reshape(dim);
30-
let bb = bb.reshape(dim);
31-
let cc = cc.reshape(dim);
29+
let aa = aa.to_shape(dim).unwrap();
30+
let bb = bb.to_shape(dim).unwrap();
31+
let cc = cc.to_shape(dim).unwrap();
3232
test_oper_arr::<f32, _>(op, aa.clone(), bb.clone(), cc.clone());
3333
}
3434

3535

36-
fn test_oper_arr<A, D>(op: &str, mut aa: ArcArray<f32, D>, bb: ArcArray<f32, D>, cc: ArcArray<f32, D>)
36+
fn test_oper_arr<A, D>(op: &str, mut aa: CowArray<f32, D>, bb: CowArray<f32, D>, cc: CowArray<f32, D>)
3737
where
3838
D: Dimension,
3939
{
@@ -65,7 +65,7 @@ where
6565
}
6666
"neg" => {
6767
assert_eq!(-&aa, cc);
68-
assert_eq!(-aa.clone(), cc);
68+
assert_eq!(-aa.into_owned(), cc);
6969
}
7070
_ => panic!(),
7171
}

0 commit comments

Comments
 (0)