-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix compilation for Android targets #59
Conversation
See bevyengine/bevy#6901 (comment) for an example failure. |
@alice-i-cecile you could have temporary pinpoint |
Sorry about this, thanks for the fix. |
@tyranron can you help me maintain this? I don't have any project now that uses this crate, so I need someone who can at least be able to test if it builds. |
@tyranron Buld has failed :/ |
@Nercury I tried fixing the failure in https://github.com/Nercury/android_logger-rs/pull/60 |
Invites are sent both on github and on crates.io. Thanks for joining :) |
@Nercury thanks 🍻 |
Additionally: - temporary disable target tests Co-authored-by: Kai Ren <[email protected]>
Btw @tyranron, @Nercury if you'd like; we'd be happy to host the Current repos here include:
You'd still be the owners/maintainers + would add you to the org. One benefit would just be that it helps to collate more of the utility Rust crates that are helpful for mobile development in one discoverable place. Another benefit might also be that it helps with pooling resources in case you do also want help with maintaining the project over time since there will be shared interests amongst the devs for the related projects. |
@rib thanks. I'd like to. |
I've just sent you and @Nercury an invite to the rust-mobile organisation. I think it would then be up to @Nercury to follow the instructions here: https://docs.github.com/en/repositories/creating-and-managing-repositories/transferring-a-repository for transferring a repo (I assume only @Nercury can do that as the owner of this repo) |
Yep, sorry to imply more pressure there! We had lots of other options (pin a version, use a fork, remove from CI), but wanted to let upstream know that they'd broken stuff <3 Thanks a ton for fixing this and making this tool! |
I haven't heard back since I sent out the email inviting @Nercury and @tyranron, so not sure if @Nercury would be ok with transferring the repo to rust-mobile or not currently. @tyranron said they would be happy to see the repo transferred (and they are a member of rust-mobile now), but it would need an OK from @Nercury to actually transfer the repo. |
Fixes #58
Additionally, reworks CI pipeline:
--target ${{ matrix.target }}
dtolnay/rust-toolchain
action (actions-rs
seems to be somewhat deprecated)