Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compilation for Android targets #59

Merged
merged 2 commits into from
Dec 20, 2022
Merged

Fix compilation for Android targets #59

merged 2 commits into from
Dec 20, 2022

Conversation

tyranron
Copy link
Contributor

Fixes #58

Additionally, reworks CI pipeline:

  • runs checks for --target ${{ matrix.target }}
  • switches to dtolnay/rust-toolchain action (actions-rs seems to be somewhat deprecated)

@alice-i-cecile
Copy link

merges on Bevy main repo are blocked until https://github.com/Nercury/android_logger-rs/pull/59 is merged and a new version of android_logger is published

See bevyengine/bevy#6901 (comment) for an example failure.

@tyranron
Copy link
Contributor Author

@alice-i-cecile you could have temporary pinpoint bevy to previous version like =0.11.1. No need to push maintainer this hard 😅

@Nercury
Copy link
Collaborator

Nercury commented Dec 20, 2022

Sorry about this, thanks for the fix.

@Nercury
Copy link
Collaborator

Nercury commented Dec 20, 2022

@tyranron can you help me maintain this? I don't have any project now that uses this crate, so I need someone who can at least be able to test if it builds.
And it's ok to ping me on gitgub.

@Nercury Nercury merged commit 4cb0b46 into rust-mobile:master Dec 20, 2022
@Nercury
Copy link
Collaborator

Nercury commented Dec 20, 2022

@tyranron Buld has failed :/

@mockersf
Copy link
Contributor

@Nercury I tried fixing the failure in https://github.com/Nercury/android_logger-rs/pull/60

@tyranron tyranron deleted the fix-ci-check branch December 20, 2022 13:02
@tyranron
Copy link
Contributor Author

@Nercury

@tyranron can you help me maintain this?

Yes. Please, add me to project maintainers and crate owners, and I'll polish the repo and code, along with the CI pipeline.

@Nercury
Copy link
Collaborator

Nercury commented Dec 20, 2022

Invites are sent both on github and on crates.io. Thanks for joining :)

@tyranron
Copy link
Contributor Author

@Nercury thanks 🍻

tyranron added a commit that referenced this pull request Dec 20, 2022
Additionally:
- temporary disable target tests

Co-authored-by: Kai Ren <[email protected]>
@tyranron tyranron self-assigned this Dec 20, 2022
@tyranron tyranron added enhancement Improvement of existing features or bugfix k::toolchain Related to project toolchain k::refactor Refactoring, technical debt elimination and other improvements of existing code base labels Dec 20, 2022
@rib
Copy link
Member

rib commented Dec 20, 2022

Btw @tyranron, @Nercury if you'd like; we'd be happy to host the android_logger repo under the rust-mobile organisation that we recently created to split out several repos from the rust-windowing organisation (ref: rust-mobile/ndk#372)

Current repos here include:

  • ndk/ndk-sys
  • cargo-apk
  • cargo-subcommand
  • android-activity (+ older ndk-glue + android-glue-rs)
  • xbuild

You'd still be the owners/maintainers + would add you to the org.

One benefit would just be that it helps to collate more of the utility Rust crates that are helpful for mobile development in one discoverable place.

Another benefit might also be that it helps with pooling resources in case you do also want help with maintaining the project over time since there will be shared interests amongst the devs for the related projects.

@tyranron
Copy link
Contributor Author

@rib thanks. I'd like to.

@rib
Copy link
Member

rib commented Dec 20, 2022

I've just sent you and @Nercury an invite to the rust-mobile organisation. I think it would then be up to @Nercury to follow the instructions here: https://docs.github.com/en/repositories/creating-and-managing-repositories/transferring-a-repository for transferring a repo (I assume only @Nercury can do that as the owner of this repo)

@alice-i-cecile
Copy link

@alice-i-cecile you could have temporary pinpoint bevy to previous version like =0.11.1. No need to push maintainer this hard 😅

Yep, sorry to imply more pressure there! We had lots of other options (pin a version, use a fork, remove from CI), but wanted to let upstream know that they'd broken stuff <3

Thanks a ton for fixing this and making this tool!

@MarijnS95
Copy link
Member

@Nercury @rib while not related to this PR: any progress on transferring the repo?

@rib
Copy link
Member

rib commented Jan 19, 2023

I haven't heard back since I sent out the email inviting @Nercury and @tyranron, so not sure if @Nercury would be ok with transferring the repo to rust-mobile or not currently.

@tyranron said they would be happy to see the repo transferred (and they are a member of rust-mobile now), but it would need an OK from @Nercury to actually transfer the repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement of existing features or bugfix k::refactor Refactoring, technical debt elimination and other improvements of existing code base k::toolchain Related to project toolchain
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crate compilation broken on Android
6 participants