Skip to content

Commit 379260b

Browse files
authored
Merge pull request #22 from jackh726/minutes
Update minutes and skill tree
2 parents d346bb4 + 16193eb commit 379260b

13 files changed

+231
-6
lines changed

minutes/design-2020-03-10.md

+13
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,13 @@
1+
# traits design meeting 2020.03.10
2+
3+
## topic
4+
5+
Discussion on impl Trait (mostly)
6+
7+
[Zulip thread](https://rust-lang.zulipchat.com/#narrow/stream/144729-wg-traits/topic/design.20meeting.202020.2E03.2E10/near/190216727)
8+
9+
## summary
10+
11+
Key points in the discussion:
12+
* [updates on Interner](https://rust-lang.zulipchat.com/#narrow/stream/144729-wg-traits/topic/design.20meeting.202020.2E03.2E10/near/190219031)
13+
* [impl Trait](https://rust-lang.zulipchat.com/#narrow/stream/144729-wg-traits/topic/design.20meeting.202020.2E03.2E10/near/190219649)

minutes/design-2020-03-17.md

+15
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,15 @@
1+
# traits design meeting 2020.03.17
2+
3+
## topic
4+
5+
Sprint discussion, builtin traits and types
6+
7+
[Zulip thread](https://rust-lang.zulipchat.com/#narrow/stream/144729-wg-traits/topic/design.20meeting.202020.2E03.2E17/near/190902377)
8+
9+
## summary
10+
11+
Key points in the discussion:
12+
* [`TyData::Fn`](https://rust-lang.zulipchat.com/#narrow/stream/144729-wg-traits/topic/design.20meeting.202020.2E03.2E17/near/190904085)
13+
* [sprint discussion](https://rust-lang.zulipchat.com/#narrow/stream/144729-wg-traits/topic/design.20meeting.202020.2E03.2E17/near/190905134)
14+
* [builtin traits](https://rust-lang.zulipchat.com/#narrow/stream/144729-wg-traits/topic/design.20meeting.202020.2E03.2E17/near/190907418)
15+
* [recursive solver vs SLG](https://rust-lang.zulipchat.com/#narrow/stream/144729-wg-traits/topic/design.20meeting.202020.2E03.2E17/near/190909029)

minutes/design-2020-03-24.md

+14
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,14 @@
1+
# traits design meeting 2020.03.24
2+
3+
## topic
4+
5+
Sprint recap, next sprint goals
6+
7+
[Zulip thread](https://rust-lang.zulipchat.com/#narrow/stream/144729-wg-traits/topic/design.20meeting.202020.2E03.2E24/near/191663614)
8+
9+
## summary
10+
11+
Key points in the discussion:
12+
* [Things accomplished](https://rust-lang.zulipchat.com/#narrow/stream/144729-wg-traits/topic/design.20meeting.202020.2E03.2E24/near/191664933)
13+
* [Tracing](https://rust-lang.zulipchat.com/#narrow/stream/144729-wg-traits/topic/design.20meeting.202020.2E03.2E24/near/191665617)
14+
* [Next sprint discussion](https://rust-lang.zulipchat.com/#narrow/stream/144729-wg-traits/topic/design.20meeting.202020.2E03.2E24/near/191665917)

minutes/design-2020-03-31.md

+16
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,16 @@
1+
# traits design meeting 2020.03.31
2+
3+
## topic
4+
5+
New sprint, who dis
6+
7+
[Zulip thread](https://rust-lang.zulipchat.com/#narrow/stream/144729-wg-traits/topic/design.20meeting.202020.2E03.2E31/near/192441350)
8+
9+
## summary
10+
11+
Key points in the discussion:
12+
* [How to organize the sprint](https://rust-lang.zulipchat.com/#narrow/stream/144729-wg-traits/topic/design.20meeting.202020.2E03.2E31/near/192443140)
13+
* [Chalk releases](https://rust-lang.zulipchat.com/#narrow/stream/144729-wg-traits/topic/design.20meeting.202020.2E03.2E31/near/192444969)
14+
* [What is needed in the book?](https://rust-lang.zulipchat.com/#narrow/stream/144729-wg-traits/topic/design.20meeting.202020.2E03.2E31/near/192446459)
15+
* [Implied bounds](https://rust-lang.zulipchat.com/#narrow/stream/144729-wg-traits/topic/design.20meeting.202020.2E03.2E31/near/192447465)
16+
* [Planning design meetings](https://rust-lang.zulipchat.com/#narrow/stream/144729-wg-traits/topic/design.20meeting.202020.2E03.2E31/near/192448605)

minutes/design-2020-04-07.md

+17
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,17 @@
1+
# traits design meeting 2020.04.07
2+
3+
## topic
4+
5+
const in Chalk
6+
7+
[Zulip thread](https://rust-lang.zulipchat.com/#narrow/stream/144729-wg-traits/topic/design.20meeting.202020.2E04.2E07/near/193239347)
8+
9+
## summary
10+
11+
Key points in the discussion:
12+
* [Recent activity](https://rust-lang.zulipchat.com/#narrow/stream/144729-wg-traits/topic/design.20meeting.202020.2E04.2E07/near/193240567)
13+
* [what is a const](https://rust-lang.zulipchat.com/#narrow/stream/144729-wg-traits/topic/design.20meeting.202020.2E04.2E07/near/193241542)
14+
* [design considerations for chalk consts](https://rust-lang.zulipchat.com/#narrow/stream/144729-wg-traits/topic/design.20meeting.202020.2E04.2E07/near/193242623)
15+
* [Mututal recursion of consts](https://rust-lang.zulipchat.com/#narrow/stream/144729-wg-traits/topic/design.20meeting.202020.2E04.2E07/near/193243417)
16+
* [When do we want to implement](https://rust-lang.zulipchat.com/#narrow/stream/144729-wg-traits/topic/design.20meeting.202020.2E04.2E07/near/193246061)
17+
* [`Fold` and `Visit` naming](https://rust-lang.zulipchat.com/#narrow/stream/144729-wg-traits/topic/design.20meeting.202020.2E04.2E07/near/193246520)

minutes/design-2020-04-14.md

+15
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,15 @@
1+
# traits design meeting 2020.04.14
2+
3+
## topic
4+
5+
Sprint progress review
6+
7+
[Zulip thread](https://rust-lang.zulipchat.com/#narrow/stream/144729-wg-traits/topic/design.20meeting.202020.2E04.2E14/near/193948519)
8+
9+
## summary
10+
11+
Key points in the discussion:
12+
* [Recent activity](https://rust-lang.zulipchat.com/#narrow/stream/144729-wg-traits/topic/design.20meeting.202020.2E04.2E14/near/193949754)
13+
* [Sprint progress review](https://rust-lang.zulipchat.com/#narrow/stream/144729-wg-traits/topic/design.20meeting.202020.2E04.2E14/near/193950312)
14+
* [Chalk book](https://rust-lang.zulipchat.com/#narrow/stream/144729-wg-traits/topic/design.20meeting.202020.2E04.2E14/near/193951120)
15+
* [Chalk releases](https://rust-lang.zulipchat.com/#narrow/stream/144729-wg-traits/topic/design.20meeting.202020.2E04.2E14/near/193953084)

minutes/design-2020-04-21.md

+15
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,15 @@
1+
# traits design meeting 2020.04.21
2+
3+
## topic
4+
5+
Implied bounds
6+
7+
[Zulip thread](https://rust-lang.zulipchat.com/#narrow/stream/144729-wg-traits/topic/design.20meeting.202020.2E04.2E21/near/194853430)
8+
9+
## summary
10+
11+
Key points in the discussion:
12+
* [Recent activity](https://rust-lang.zulipchat.com/#narrow/stream/144729-wg-traits/topic/design.20meeting.202020.2E04.2E21/near/194853602)
13+
* [What are implied bounds](https://rust-lang.zulipchat.com/#narrow/stream/144729-wg-traits/topic/design.20meeting.202020.2E04.2E21/near/194854642)
14+
* [Reasoning of `FromEnv`](https://rust-lang.zulipchat.com/#narrow/stream/144729-wg-traits/topic/design.20meeting.202020.2E04.2E21/near/194856679)
15+
* [WellFormed goals](https://rust-lang.zulipchat.com/#narrow/stream/144729-wg-traits/topic/design.20meeting.202020.2E04.2E21/near/194858563)

minutes/design-2020-04-28.md

+16
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,16 @@
1+
# traits design meeting 2020.04.28
2+
3+
## topic
4+
5+
Builtin types/traits, link check, opaque types, const types
6+
7+
[Zulip thread](https://rust-lang.zulipchat.com/#narrow/stream/144729-wg-traits/topic/design.20meeting.202020.2E04.2E28/near/195618205)
8+
9+
## summary
10+
11+
Key points in the discussion:
12+
* [Recent activity](https://rust-lang.zulipchat.com/#narrow/stream/144729-wg-traits/topic/design.20meeting.202020.2E04.2E28/near/195618377)
13+
* [Builtin types/traits](https://rust-lang.zulipchat.com/#narrow/stream/144729-wg-traits/topic/design.20meeting.202020.2E04.2E28/near/195619901)
14+
* [Link check](https://rust-lang.zulipchat.com/#narrow/stream/144729-wg-traits/topic/design.20meeting.202020.2E04.2E28/near/195622231)
15+
* [Opaque types](https://rust-lang.zulipchat.com/#narrow/stream/144729-wg-traits/topic/design.20meeting.202020.2E04.2E28/near/195624119)
16+
* [const types](https://rust-lang.zulipchat.com/#narrow/stream/144729-wg-traits/topic/design.20meeting.202020.2E04.2E28/near/195625661)

minutes/design-2020-05-05.md

+16
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,16 @@
1+
# traits design meeting 2020.05.05
2+
3+
## topic
4+
5+
leak check, `ObjectSafe` and `Outlives` goals, const PR discussion
6+
7+
[Zulip thread](https://rust-lang.zulipchat.com/#narrow/stream/144729-wg-traits/topic/design.20meeting.202020.2E05.2E05/near/196359047)
8+
9+
## summary
10+
11+
Key points in the discussion:
12+
* [Recent activity](https://rust-lang.zulipchat.com/#narrow/stream/144729-wg-traits/topic/design.20meeting.202020.2E05.2E05/near/196359487)
13+
* [Universe transition in rustc](https://rust-lang.zulipchat.com/#narrow/stream/144729-wg-traits/topic/design.20meeting.202020.2E05.2E05/near/196360573)
14+
* [Leak cheak](https://rust-lang.zulipchat.com/#narrow/stream/144729-wg-traits/topic/design.20meeting.202020.2E05.2E05/near/196361190)
15+
* [`ObjectSafe` and `Outlives`](https://rust-lang.zulipchat.com/#narrow/stream/144729-wg-traits/topic/design.20meeting.202020.2E05.2E05/near/196363704)
16+
* [const PR discussion](https://rust-lang.zulipchat.com/#narrow/stream/144729-wg-traits/topic/design.20meeting.202020.2E05.2E05/near/196365991)

minutes/design-2020-05-12.md

+14
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,14 @@
1+
# traits design meeting 2020.05.12
2+
3+
## topic
4+
5+
Sprint recap
6+
7+
[Zulip thread](https://rust-lang.zulipchat.com/#narrow/stream/144729-wg-traits/topic/design.20meeting.202020.2E05.2E12/near/197329732)
8+
9+
## summary
10+
11+
Key points in the discussion:
12+
* [Recent activity](https://rust-lang.zulipchat.com/#narrow/stream/144729-wg-traits/topic/design.20meeting.202020.2E05.2E12/near/197329871)
13+
* [How do we want to keep minutes](https://rust-lang.zulipchat.com/#narrow/stream/144729-wg-traits/topic/design.20meeting.202020.2E05.2E12/near/197330803)
14+
* [Sprint recap](https://rust-lang.zulipchat.com/#narrow/stream/144729-wg-traits/topic/design.20meeting.202020.2E05.2E12/near/197332669)

roadmap.toml

+6-6
Original file line numberDiff line numberDiff line change
@@ -96,7 +96,7 @@ items = [
9696
{ label="support the `Sized` trait", status="Complete", href="https://github.com/rust-lang/chalk/issues/261" },
9797
{ label="support the `Clone` trait", status="Complete", href="https://github.com/rust-lang/chalk/issues/363" },
9898
{ label="support the `Copy` trait", status="Complete", href="https://github.com/rust-lang/chalk/issues/363" },
99-
{ label="model `ObjectSafe` goals", status="Assigned", href="https://github.com/rust-lang/chalk/pull/434" },
99+
{ label="model `ObjectSafe` goals", status="Complete", href="https://github.com/rust-lang/chalk/pull/434" },
100100
{ label="support the `Unsized` trait", status="Assigned", href="https://github.com/rust-lang/chalk/pull/427" },
101101
{ label="extend `TypeName` with builtin types", href="https://github.com/rust-lang/chalk/issues/368" },
102102
{ label="support the `Fn` traits", status="Blocked" },
@@ -116,10 +116,10 @@ href = "https://github.com/rust-lang/wg-traits/issues/18"
116116
requires = [ "map-chalk-types-to-rustc-types", "chalk-const", "chalk-builtin", "chalk-outlives" ]
117117
items = [
118118
{ label="remove old chalk support", status="Complete", href="https://github.com/rust-lang/rust/pull/69247" },
119-
{ label="exploratory integration to better uncover requirements", href="https://github.com/rust-lang/rust/pull/69406", status="Assigned" },
120-
{ label="map rustc types to chalk types", status="Assigned" },
121-
{ label="map rustc predicates to chalk goals, clauses", status="Assigned" },
122-
{ label="implement RustIrDatabase in trait", status="Assigned" },
119+
{ label="exploratory integration to better uncover requirements", href="https://github.com/rust-lang/rust/pull/69406", status="Complete" },
120+
{ label="map rustc types to chalk types", status="Complete" },
121+
{ label="map rustc predicates to chalk goals, clauses", status="Complete" },
122+
{ label="implement RustIrDatabase in trait", status="Complete" },
123123
]
124124

125125
[[group]]
@@ -138,7 +138,7 @@ label = "Improve ability to debug chalk from within rustc or rust-analyzer"
138138
requires = [ ]
139139
items = [
140140
{ label="Integrate tracing library", href="https://github.com/rust-lang/chalk/issues/337", status="Assigned" },
141-
{ label="Extract standalone examples automatically" },
141+
{ label="Extract standalone examples automatically", href="https://github.com/rust-lang/chalk/issues/365" },
142142
]
143143

144144
[[goal]]

sprints/2020-1.md

+4
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
FIXME: add an overview of work done in 2020 sprint 1
2+
3+
Link to summary blog post:
4+
https://blog.rust-lang.org/inside-rust/2020/03/28/traits-sprint-1.html

sprints/2020-2.md

+70
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,70 @@
1+
# wg-traits sprint 2020-03-31 ..
2+
3+
**Pulled from https://hackmd.io/kYWsWI9IS0213x0qX_1RDw on 2020/5/14**
4+
5+
* Goal: Rustc integration MVP ([tracking issue](https://github.com/rust-lang/wg-traits/issues/18))
6+
* Initial integration work landed
7+
* Made a lot of progress towards extending chalk to support builtin types and traits
8+
* Currently using some hacks in rustc for some of them
9+
* Next steps:
10+
* Extend chalk to be able to represent all of the Rust types [chalk#368](https://github.com/rust-lang/chalk/issues/368)
11+
* Connect rustc types to the builtin chalk types
12+
* Auto trait handling for builtin chalk types
13+
* Handling int and float literal inference variables
14+
* Region / outlives integration
15+
* Bound inference variables, perhaps?
16+
* Goal: Plan for what const integration looks like ([tracking issue](https://github.com/rust-lang/wg-traits/issues/15))
17+
* Held [initial meeting](https://zulip-archive.rust-lang.org/144729wgtraits/23279designmeeting20200407.html) and designed a minimal subset
18+
* Implementing a [pending PR](https://github.com/rust-lang/chalk/pull/393) which uncovered some interesting questions about how to represent constants
19+
* Next steps:
20+
* [Resolve `GenericArg` handling](https://github.com/rust-lang/chalk/issues/452)
21+
* Land [chalk#393](https://github.com/rust-lang/chalk/pull/393) which will offer basic constant support
22+
* it has been reviewed and we are working out the [list of test cases](https://hackmd.io/Ah_J6nFQSbuUiVOsH5acLg)
23+
* next steps:
24+
* incorporate some mention into the chalk book
25+
* Goal: Move towards alignment of rustc and chalk types, and towards extracting a shared library ([tracking issue](https://github.com/rust-lang/wg-traits/issues/16))
26+
* [Doc from meeting](https://hackmd.io/roRq0qHMQ6CyRJxj_FsPSQ)
27+
* Extended chalk types to support builtin rust types and traits
28+
* Refactoring of predicates on rustc side to be interned and match chalk conventions [rust-lang/rust#72055](https://github.com/rust-lang/rust/pull/72055)
29+
* Next steps:
30+
* Finalize naming conventions and rename as necessary
31+
* Create issues around rustc side
32+
* Goal: basic support for impl Trait ([tracking issue](https://github.com/rust-lang/chalk/issues/335))
33+
* basic support has landed: [PR #324](https://github.com/rust-lang/chalk/pull/324), :tada:
34+
* working now on adding better generics support
35+
* [Next steps](https://github.com/rust-lang/chalk/issues/335#issuecomment-615254659)
36+
* Goal: progress towards removing leak check in rustc ([tracking issue](https://github.com/rust-lang/rust/issues/59490))
37+
* Landed [#70950](https://github.com/rust-lang/rust/pull/70950) which aligns NLL with lexical checker
38+
* but to truly remove leak check we have to resolve some back-compat interactions
39+
* Next steps:
40+
* rustc refactoring to move leak check to occur later, which unblocks lazy norm and a few other changes
41+
* explore a smarter variant of leak check that takes into account implied bounds and is able to continue accepting wasm-bindgen
42+
* Goal: exploration and research
43+
* exploring recursive solver (flodiebold)
44+
* initial version has landed and been integrated into rust-analyzer
45+
* Follow-up items:
46+
* fix coinduction [chalk#399](https://github.com/rust-lang/chalk/issues/399)
47+
* revisiting the chalk-solve crate structure
48+
* documenting how it works in chalk-book
49+
* comparison between it and SLG checker
50+
* explore converting semantic-to-syntactic equality
51+
* [draft PR opened](https://github.com/rust-lang/chalk/pull/401)
52+
* create a chalk file from any given program
53+
* [draft PR opened](https://github.com/rust-lang/chalk/pull/430) and it's starting to work
54+
* Goal: increase Chalk performance (very open-ended)
55+
* Create a set of benchmarks
56+
* no progress
57+
* Add tracing support
58+
* opened a [draft PR](https://github.com/rust-lang/chalk/pull/409)
59+
* Track memory usage and try to decrease as necessary
60+
* no progress
61+
* Goal: add more to Chalk book
62+
* Added [chalk big picture](http://rust-lang.github.io/chalk/book/#high-level-view-of-how-chalk-works) material
63+
* Moved content from [rustc-dev-guide](https://rustc-dev-guide.rust-lang.org/traits/chalk-overview.html)
64+
* Added [table tracking the well-known traits](http://rust-lang.github.io/chalk/book/clauses/well_known_traits.html#current-state)
65+
* Next steps:
66+
* glossary and notation for common terms
67+
* the `?0` notation
68+
* the `^0` notation
69+
* the `!0` notation
70+
* what is a "bound variable", an "inference variable", and a "placeholder variable", and what do they *mean* semantically

0 commit comments

Comments
 (0)