Skip to content

Add command/workflow to go from S-waiting-on-author to S-waiting-on-review #553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
XAMPPRocky opened this issue May 18, 2020 · 1 comment

Comments

@XAMPPRocky
Copy link
Member

Currently the status labels for PRs are mostly manually updated by triagers, it would be nice if authors of PRs could more easily update the status when it's S-waiting-on-author when they believe they have completed the necessary changes.

Potential Solutions

  • Detect when the author has requested a review using GitHub's request review feature and automatically update labels.
  • Add some kind of @rustbot review command.

I think ideally we would have both, as @rustbot review is easy to teach, but more people are using GitHub's review features as it better integrates with GitHub notifications, and the @rustbot review command could be implemented so that it uses GitHub's request review feature.

@kellda
Copy link
Contributor

kellda commented Sep 10, 2021

I think it has been fixed by #1381...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants