Update proc macro2 #455
Merged
Update proc macro2 #455
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lu-zero
force-pushed
the
update_proc_macro
branch
from
08459ca to
c67e48b
Compare
|
looks like the new rustfmt has different ideas regarding the style and there is something quite fishy going on windows and x86 but it is unrelated to this set. |
This was referenced May 21, 2018
Merged
|
Unfortunately we're hit by a slew of bugs here:
|
|
I also don't know what's going on yet with Windows, that's just Linux :( |
Currently this causes bugs on nightly due to upstream rustc bugs, this should be temporary
dtolnay
approved these changes
May 21, 2018
|
Ok Windows looks back to "normal", I think this PR is now purely blocked on figuring out mergefunc |
|
Ok I've pushed a commit that will hopefully thwart mergefunc, let's see how it pans out. |
|
Alright, all green now! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update to the latest version of proc_macro2, quote and syn.