Skip to content

API for constants in vendor interface #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
BurntSushi opened this issue Sep 17, 2017 · 2 comments
Closed

API for constants in vendor interface #14

BurntSushi opened this issue Sep 17, 2017 · 2 comments

Comments

@BurntSushi
Copy link
Member

Some vendor intrinsics come with various constants defined that give special meaning to integer values. The _SIDD_* constants, for example, are used with the packed compare intrinsics.

What should we do about these? Should we define them at all? If we do, should they go in their own separate module, or should they live in the same flat namespace as the rest of the intrinsic functions?

@gnzlbg
Copy link
Contributor

gnzlbg commented Nov 20, 2017

Should we define them at all?

Yes.

If we do, should they go in their own separate module, or should they live in the same flat namespace as the rest of the intrinsic functions?

Right now they live in the same module, which is what the C API does (and any "nicer" solution won't be what C does).

Having said this, there aren't that many constants, so we could put them in their own modules.

Currently we are basically dumping everything in the vendor module, so this is at least tangentially related to: how "clean" do we want vendor to be? The answer to this question doesn't need to be the same for all architectures.

@alexcrichton
Copy link
Member

I'm gonna close this now due to #263

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants