Skip to content

CI fails on powerpc64-unknown-linux-gnu #2608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
est31 opened this issue Dec 12, 2020 · 2 comments · Fixed by #2609
Closed

CI fails on powerpc64-unknown-linux-gnu #2608

est31 opened this issue Dec 12, 2020 · 2 comments · Fixed by #2609
Labels
bug

Comments

@est31
Copy link
Member

est31 commented Dec 12, 2020

Since merging of #2517, the master branch CI fails on powerpc64-unknown-linux-gnu. Link to a failing build. Relevant excerpt from the log:

error: failed to run custom build command for `ring v0.16.17`

Caused by:
  process didn't exit successfully: `/checkout/target/release/build/ring-69b64e93d224eaca/build-script-build` (exit code: 101)
  --- stderr
  thread 'main' panicked at 'called `Option::unwrap()` on a `None` value', /cargo/registry/src/github.com-1ecc6299db9ec823/ring-0.16.17/build.rs:375:10

The failing line is here. It turns out that ring doesn't support the powerpc platform: briansmith/ring#389

I think the best resolution would be to disable the builtin rustls support on the powerpc platform.

cc @kinnison
@est31 est31 added the bug label Dec 12, 2020
@kinnison
Copy link
Contributor

Hmm, that's not ideal no. Please do sort a PR for that if you can.

est31 added a commit to est31/rustup that referenced this issue Dec 12, 2020
@est31
Don't build rustls on platforms unsupported by ring
bab69df 
The ring crate only supports a limited set of platforms.
Don't compile with rustls enabled on platforms that it
doesn't support.

Closes rust-lang#2608
@est31 est31 mentioned this issue Dec 12, 2020
Merged
@est31
Copy link
Member Author

est31 commented Dec 12, 2020

Please do sort a PR for that if you can.

@kinnison → #2609

est31 added a commit to est31/rustup that referenced this issue Dec 12, 2020
@est31
Don't build rustls on platforms unsupported by ring
30235e2 
The ring crate only supports a limited set of platforms.
Don't compile with rustls enabled on platforms that it
doesn't support.

Closes rust-lang#2608
est31 added a commit to est31/rustup that referenced this issue Dec 12, 2020
@est31
Don't build rustls on platforms unsupported by ring
c4e6045 
The ring crate only supports a limited set of platforms.
Don't compile with rustls enabled on platforms that it
doesn't support.

Closes rust-lang#2608
est31 added a commit to est31/rustup that referenced this issue Dec 13, 2020
@est31
Don't build rustls on platforms unsupported by ring
d1bf829 
The ring crate only supports a limited set of platforms.
Don't compile with rustls enabled on platforms that it
doesn't support.

Closes rust-lang#2608
est31 added a commit to est31/rustup that referenced this issue Dec 13, 2020
@est31
Don't build rustls on platforms unsupported by ring
2cd00df 
The ring crate only supports a limited set of platforms.
Don't compile with rustls enabled on platforms that it
doesn't support.

Closes rust-lang#2608
est31 added a commit to est31/rustup that referenced this issue Dec 13, 2020
@est31
Don't build rustls on platforms unsupported by ring
b53045e 
The ring crate only supports a limited set of platforms.
Don't compile with rustls enabled on platforms that it
doesn't support.

Closes rust-lang#2608
est31 added a commit to est31/rustup that referenced this issue Dec 13, 2020
@est31
Don't build rustls on platforms unsupported by ring
03865fa 
The ring crate only supports a limited set of platforms.
Don't compile with rustls enabled on platforms that it
doesn't support.

Closes rust-lang#2608
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Don't build rustls on platforms unsupported by ring est31/rustup
2 participants
@kinnison @est31