Skip to content

Commit ca77c78

Browse files
committed
feat(tracing): log nothing unless RUST_LOG is set
1 parent 54dd3d0 commit ca77c78

File tree

3 files changed

+3
-3
lines changed

3 files changed

+3
-3
lines changed

doc/dev-guide/src/tracing.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ cargo build --features=otel
3030
Run the operation you want to analyze:
3131

3232
```sh
33-
RUSTUP_FORCE_ARG0="rustup" ./target/debug/rustup-init show
33+
RUST_LOG='info' RUSTUP_FORCE_ARG0='rustup' ./target/debug/rustup-init show
3434
```
3535

3636
And [look in Jaeger for a trace](http://localhost:16686/search?service=rustup).

src/bin/rustup-init.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,7 @@ fn maybe_trace_rustup() -> Result<utils::ExitCode> {
8585
)])),
8686
)
8787
.install_batch(opentelemetry_sdk::runtime::Tokio)?;
88-
let env_filter = EnvFilter::try_from_default_env().unwrap_or(EnvFilter::new("INFO"));
88+
let env_filter = EnvFilter::try_from_default_env().unwrap_or(EnvFilter::new("OFF"));
8989
let telemetry = tracing_opentelemetry::layer().with_tracer(tracer);
9090
let subscriber = Registry::default().with(env_filter).with(telemetry);
9191
tracing::subscriber::set_global_default(subscriber)?;

src/test.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -270,7 +270,7 @@ static TRACER: Lazy<opentelemetry_sdk::trace::Tracer> = Lazy::new(|| {
270270
.unwrap();
271271

272272
global::set_text_map_propagator(TraceContextPropagator::new());
273-
let env_filter = EnvFilter::try_from_default_env().unwrap_or(EnvFilter::new("INFO"));
273+
let env_filter = EnvFilter::try_from_default_env().unwrap_or(EnvFilter::new("OFF"));
274274
let telemetry = tracing_opentelemetry::layer().with_tracer(tracer.clone());
275275
let subscriber = Registry::default().with(env_filter).with(telemetry);
276276
tracing::subscriber::set_global_default(subscriber).unwrap();

0 commit comments

Comments
 (0)