feat(cli/rustup-mode)!: set log level to DEBUG on --verbose if RUSTUP_LOG is unset

Author: rami3l

src/bin/rustup-init.rs

@@ -93,7 +93,7 @@ async fn run_rustup_inner(
     utils::current_exe()?;
 
     match process.name().as_deref() {
-        Some("rustup") => rustup_mode::main(current_dir, process).await,
+        Some("rustup") => rustup_mode::main(current_dir, process, console_filter).await,
         Some(n) if n.starts_with("rustup-setup") || n.starts_with("rustup-init") => {
             // NB: The above check is only for the prefix of the file
             // name. Browsers rename duplicates to

src/cli/rustup_mode.rs

@@ -10,6 +10,7 @@ use clap::{builder::PossibleValue, Args, CommandFactory, Parser, Subcommand, Val
 use clap_complete::Shell;
 use itertools::Itertools;
 use tracing::{info, trace, warn};
+use tracing_subscriber::{reload::Handle, EnvFilter, Registry};
 
 use crate::{
     cli::{
@@ -68,12 +69,12 @@ fn handle_epipe(res: Result<utils::ExitCode>) -> Result<utils::ExitCode> {
     after_help = RUSTUP_HELP,
 )]
 struct Rustup {
-    /// Enable verbose output
-    #[arg(short, long)]
+    /// Enable verbose output, limit console logger level to 'DEBUG' if 'RUSTUP_LOG' is unset
+    #[arg(short, long, overrides_with = "quiet")]
     verbose: bool,
 
-    /// Disable progress output
-    #[arg(short, long, conflicts_with = "verbose")]
+    /// Disable progress output, limit console logger level to 'WARN' if 'RUSTUP_LOG' is unset
+    #[arg(short, long, overrides_with = "verbose")]
     quiet: bool,
 
     /// Release channel (e.g. +stable) or custom toolchain to set override
@@ -532,7 +533,11 @@ enum SetSubcmd {
 }
 
 #[tracing::instrument(level = "trace", fields(args = format!("{:?}", process.args_os().collect::<Vec<_>>())))]
-pub async fn main(current_dir: PathBuf, process: &Process) -> Result<utils::ExitCode> {
+pub async fn main(
+    current_dir: PathBuf,
+    process: &Process,
+    console_filter: Handle<EnvFilter, Registry>,
+) -> Result<utils::ExitCode> {
     self_update::cleanup_self_updater(process)?;
 
     use clap::error::ErrorKind::*;
@@ -570,6 +575,19 @@ pub async fn main(current_dir: PathBuf, process: &Process) -> Result<utils::Exit
         }
     };
 
+    if process.var("RUSTUP_LOG").is_err() {
+        if matches.quiet {
+            console_filter
+                .modify(|it| *it = EnvFilter::new("rustup=WARN"))
+                .expect("error reloading `EnvFilter` for console_logger")
+        }
+        if matches.verbose {
+            console_filter
+                .modify(|it| *it = EnvFilter::new("rustup=DEBUG"))
+                .expect("error reloading `EnvFilter` for console_logger")
+        }
+    }
+
     let cfg = &mut common::set_globals(current_dir, matches.quiet, process)?;
 
     if let Some(t) = &matches.plus_toolchain {

src/process.rs

@@ -17,6 +17,8 @@ use anyhow::{Context, Result};
 use tracing::subscriber::DefaultGuard;
 #[cfg(feature = "test")]
 use tracing_subscriber::util::SubscriberInitExt;
+#[cfg(feature = "test")]
+use tracing_subscriber::{reload::Handle, EnvFilter, Registry};
 
 pub mod filesource;
 pub mod terminalsource;
@@ -177,6 +179,7 @@ impl Default for OsProcess {
 #[cfg(feature = "test")]
 pub struct TestProcess {
     pub process: Process,
+    pub console_filter: Handle<EnvFilter, Registry>,
     _guard: DefaultGuard, // guard is dropped at the end of the test
 }
 
@@ -230,10 +233,11 @@ impl TestProcess {
 impl From<TestContext> for TestProcess {
     fn from(inner: TestContext) -> Self {
         let inner = Process::TestProcess(inner);
-        let guard = crate::cli::log::tracing_subscriber(&inner).0.set_default();
+        let (tracing_subscriber, console_filter) = crate::cli::log::tracing_subscriber(&inner);
         Self {
             process: inner,
-            _guard: guard,
+            console_filter,
+            _guard: tracing_subscriber.set_default(),
         }
     }
 }

src/test/mock/clitools.rs

@@ -790,7 +790,12 @@ impl Config {
         }
 
         let tp = process::TestProcess::new(&*self.workdir.borrow(), &arg_strings, vars, "");
-        let process_res = rustup_mode::main(tp.process.current_dir().unwrap(), &tp.process).await;
+        let process_res = rustup_mode::main(
+            tp.process.current_dir().unwrap(),
+            &tp.process,
+            tp.console_filter.clone(),
+        )
+        .await;
         // convert Err's into an ec
         let ec = match process_res {
             Ok(process_res) => process_res,

tests/suite/cli-ui/rustup/rustup_help_cmd_stdout.toml

@@ -30,8 +30,10 @@ Arguments:
   [+toolchain]  Release channel (e.g. +stable) or custom toolchain to set override
 
 Options:
-  -v, --verbose  Enable verbose output
-  -q, --quiet    Disable progress output
+  -v, --verbose  Enable verbose output, limit console logger level to 'DEBUG' if 'RUSTUP_LOG' is
+                 unset
+  -q, --quiet    Disable progress output, limit console logger level to 'WARN' if 'RUSTUP_LOG' is
+                 unset
   -h, --help     Print help
   -V, --version  Print version
 

tests/suite/cli-ui/rustup/rustup_help_flag_stdout.toml

@@ -30,8 +30,10 @@ Arguments:
   [+toolchain]  Release channel (e.g. +stable) or custom toolchain to set override
 
 Options:
-  -v, --verbose  Enable verbose output
-  -q, --quiet    Disable progress output
+  -v, --verbose  Enable verbose output, limit console logger level to 'DEBUG' if 'RUSTUP_LOG' is
+                 unset
+  -q, --quiet    Disable progress output, limit console logger level to 'WARN' if 'RUSTUP_LOG' is
+                 unset
   -h, --help     Print help
   -V, --version  Print version
 

tests/suite/cli-ui/rustup/rustup_only_options_stdout.toml

@@ -32,10 +32,10 @@ Arguments:
 
 Options:
   -v, --verbose
-          Enable verbose output
+          Enable verbose output, limit console logger level to 'DEBUG' if 'RUSTUP_LOG' is unset
 
   -q, --quiet
-          Disable progress output
+          Disable progress output, limit console logger level to 'WARN' if 'RUSTUP_LOG' is unset
 
   -h, --help
           Print help

tests/suite/cli_rustup.rs

@@ -84,24 +84,7 @@ async fn rustup_stable_quiet() {
 
 "
             ),
-            for_host!(
-                r"info: syncing channel updates for 'stable-{0}'
-info: latest update on 2015-01-02, rust version 1.1.0 (hash-stable-1.1.0)
-info: downloading component 'cargo'
-info: downloading component 'rust-docs'
-info: downloading component 'rust-std'
-info: downloading component 'rustc'
-info: removing previous version of component 'cargo'
-info: removing previous version of component 'rust-docs'
-info: removing previous version of component 'rust-std'
-info: removing previous version of component 'rustc'
-info: installing component 'cargo'
-info: installing component 'rust-docs'
-info: installing component 'rust-std'
-info: installing component 'rustc'
-info: cleaning up downloads & tmp directories
-"
-            ),
+            "",
         )
         .await;
 }