Skip to content

Let-Else is not formated correctly after else #5660

@erwanvivien

Description

@erwanvivien
fn main() {
    let position:      Option<usize> = None;
    let mut normal: Option<usize> =  None;
    let mut tex_coords: Option<usize>    = None;

    let (Some( position), Some(    normal), Some(tex_coords  )) = (position, normal, tex_coords) else {
        return;
 };
 }

Does not format the let-else at all, resulting in:

fn main() {
    let position: Option<usize> = None;
    let mut normal: Option<usize> = None;
    let mut tex_coords: Option<usize> = None;

    let (Some( position), Some(    normal), Some(tex_coords  )) = (position, normal, tex_coords) else {
        return;
 };

}
# How to reproduce
$ rustfmt .\src\main.rs

Version:

$ rustfmt --version
rustfmt 1.5.1-stable (897e3755 2022-11-02)

Activity

ytmimi

ytmimi commented on Jan 16, 2023

@ytmimi
Contributor

Thanks for reaching out!

rustfmt doesn't support formatting let-else as the rules for how they should be formatted were not decided until about 2 weeks ago. You can check out rust-lang/style-team#165 (comment) for more details. Support for let-else formatting will be added in a future release.

To be notified when let-else support is added you can follow tracking issue #4914

erwanvivien

erwanvivien commented on Jan 16, 2023

@erwanvivien
Author

Alright, thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @ytmimi@erwanvivien

        Issue actions

          Let-Else is not formated correctly after else · Issue #5660 · rust-lang/rustfmt